[GitHub] [pulsar-client-node] massakam merged pull request #163: Use Buffer::Copy instead of Buffer::New

2021-07-19 Thread GitBox
massakam merged pull request #163: URL: https://github.com/apache/pulsar-client-node/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [pulsar-client-node] massakam commented on pull request #163: Use Buffer::Copy instead of Buffer::New

2021-07-19 Thread GitBox
massakam commented on pull request #163: URL: https://github.com/apache/pulsar-client-node/pull/163#issuecomment-883039565 I got it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-node] hrsakai commented on pull request #163: Use Buffer::Copy instead of Buffer::New

2021-07-19 Thread GitBox
hrsakai commented on pull request #163: URL: https://github.com/apache/pulsar-client-node/pull/163#issuecomment-883036429 > The following part doesn't need to be modified because ptr is not shared_ptr, right? This issue seems to occure if adding same pointer to `Napi::Buffer::New`,

[GitHub] [pulsar-dotpulsar] DrinkStar opened a new issue #82: How to create a new topic by dotpulsar?

2021-07-19 Thread GitBox
DrinkStar opened a new issue #82: URL: https://github.com/apache/pulsar-dotpulsar/issues/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-client-node] massakam commented on pull request #163: Use Buffer::Copy instead of Buffer::New

2021-07-19 Thread GitBox
massakam commented on pull request #163: URL: https://github.com/apache/pulsar-client-node/pull/163#issuecomment-883013636 The following part doesn't need to be modified because `ptr` is not shared_ptr, right? https://github.com/apache/pulsar-client-node/blob/07c6b1dd8132aed4e3d50ba182

[GitHub] [pulsar-client-node] hrsakai opened a new pull request #163: Use Buffer::Copy instead of Buffer::New

2021-07-19 Thread GitBox
hrsakai opened a new pull request #163: URL: https://github.com/apache/pulsar-client-node/pull/163 In our enviroment, sometimes we get following error. ``` # # Fatal error in , line 0 # Check failed: result.second. # # # #FailureMessage Object: 0x7ffe7bd5eda0 1: 0

[GitHub] [pulsar-manager] Huanli-Meng commented on pull request #403: Added chinese version..

2021-07-19 Thread GitBox
Huanli-Meng commented on pull request #403: URL: https://github.com/apache/pulsar-manager/pull/403#issuecomment-882972418 As confirmed with Guowei, he is responsible for updating the doc based on the cloud-manager doc (chinese version) and only review some uncovered contents. -- This

Re: [Doc] Upgrade Docusuraus

2021-07-19 Thread Anonymitaet _
Hi all, Just a gentle reminder: If you have any suggestions on the Pulsar website, do not hesitate to leave your comments here (https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#) before EOD July 28 (GMT +8). Thanks! On 2021/7/14, 11:48, "Anonymitaet _" w

Re: [DISCUSS] Releasing Pulsar-client-go 0.6.0

2021-07-19 Thread Ming Luo
+1 Thanks Ming On Mon, 19 Jul 2021 at 18:55, Neng Lu wrote: > +1 > > Neng Lu > > On 2021/07/19 08:44:11 "r...@apache.org" wrote: > > Hello Everyone: > > > > I hope you’ve all been doing well. In the past two months, we have > > fixed a number of bugs related to connection leaks and added > > so

Re: [DISCUSS] Releasing Pulsar-client-go 0.6.0

2021-07-19 Thread Neng Lu
+1 Neng Lu On 2021/07/19 08:44:11 "r...@apache.org" wrote: > Hello Everyone: > > I hope you’ve all been doing well. In the past two months, we have > fixed a number of bugs related to connection leaks and added > some new features. For more information refer to: > > https://github.com/apache/p

Re: Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Neng Lu
Based on my local test, it's fine for String Schema. On 2021/07/19 18:47:49 Devin Bost wrote: > > This leads to an IncompatibleClassChangeError when you have a Function or > > a Connector that is using Schema.JSON(Pojo.class) > > I just noticed this detail. Do we have a sense of how often people

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Enrico Olivelli
Il Lun 19 Lug 2021, 20:48 Devin Bost ha scritto: > > This leads to an IncompatibleClassChangeError when you have a Function > or > > a Connector that is using Schema.JSON(Pojo.class) > > I just noticed this detail. Do we have a sense of how often people are > using Schema.JSON in Functions/Conne

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Devin Bost
> This leads to an IncompatibleClassChangeError when you have a Function or > a Connector that is using Schema.JSON(Pojo.class) I just noticed this detail. Do we have a sense of how often people are using Schema.JSON in Functions/Connectors? Most of our functions are using a string schema, so it'

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Devin Bost
> I think Sijie is referring to using KubernetesRuntime to deploy functions > where each function/source/sink runs as an independent statefulset in K8s. > In this scenario, it is possible to have fine grained control over which > version of the function container the function is using. Not everybo

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Devin Bost
> For example, if you are upgrading Flink from one version to the other > version, you have to make a save point in the previous version for all > the Flink jobs. > Upgrade the Flink cluster and resume jobs in a new version. > > https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/ops/

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Sijie Guo
On Mon, Jul 19, 2021 at 10:32 AM Jerry Peng wrote: > > I agree that the best we can do right now is to just clearly document this > as a potential problem when updating 2.7 to 2.8. > > We should definitely make every attempt to not make BC breaking changes. > However, there are times when we have

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Sijie Guo
On Mon, Jul 19, 2021 at 12:50 AM Enrico Olivelli wrote: > > Sijie, > Thank you for your feedback > Some additional considerations inline > > Il Lun 19 Lug 2021, 06:47 Sijie Guo ha scritto: > > > I don't think this is a big problem. Because people can recompile the > > function and submit the func

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Devin Bost
Is the client at least backwards compatible so that we could have all of our teams upgrade functions before a broker upgrade is scheduled? We have hundreds of functions running in production that are maintained by many different teams and departments. If upgrades of the functions need be all happe

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Jerry Peng
I agree that the best we can do right now is to just clearly document this as a potential problem when updating 2.7 to 2.8. We should definitely make every attempt to not make BC breaking changes. However, there are times when we have to make these tough decisions for one reason or another. The bi

Re: [DISCUSS] Releasing Pulsar-client-go 0.6.0

2021-07-19 Thread Rui Fu
+1, Thanks Rui Fu 在 2021年7月19日 +0800 PM4:44,r...@apache.org ,写道: > Hello Everyone: > > I hope you’ve all been doing well. In the past two months, we have > fixed a number of bugs related to connection leaks and added > some new features. For more information refer to: > > https://github.com/apach

Re: [DISCUSS] Releasing Pulsar-client-go 0.6.0

2021-07-19 Thread Enrico Olivelli
+1 Enrico Il giorno lun 19 lug 2021 alle ore 10:44 r...@apache.org < ranxiaolong...@gmail.com> ha scritto: > Hello Everyone: > > I hope you’ve all been doing well. In the past two months, we have > fixed a number of bugs related to connection leaks and added > some new features. For more informa

[DISCUSS] Releasing Pulsar-client-go 0.6.0

2021-07-19 Thread r...@apache.org
Hello Everyone: I hope you’ve all been doing well. In the past two months, we have fixed a number of bugs related to connection leaks and added some new features. For more information refer to: https://github.com/apache/pulsar-client-go/milestone/7?closed=1 For that reason, I think we should be

Re: Problems with Functions/IO in Upgrading Pulsar from 2.7 to 2.8

2021-07-19 Thread Enrico Olivelli
Sijie, Thank you for your feedback Some additional considerations inline Il Lun 19 Lug 2021, 06:47 Sijie Guo ha scritto: > I don't think this is a big problem. Because people can recompile the > function and submit the function. Most of the computing/streaming > engines ask users to recompile th