[GitHub] [pulsar-client-node] nkurihar closed issue #93: Producer connection status

2021-07-06 Thread GitBox
nkurihar closed issue #93: URL: https://github.com/apache/pulsar-client-node/issues/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [pulsar-client-node] nkurihar commented on issue #93: Producer connection status

2021-07-06 Thread GitBox
nkurihar commented on issue #93: URL: https://github.com/apache/pulsar-client-node/issues/93#issuecomment-875208548 Fixed: https://github.com/apache/pulsar-client-node/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: Re: Re: Discussion about https://github.com/apache/pulsar/pull/11112

2021-07-06 Thread Enrico Olivelli
Il Mar 6 Lug 2021, 21:30 Neng Lu ha scritto: > IMHO, The old runtime should not be able to run the new functions. This is not possible to enforce this because we cannot change old code. > > > New functions require resource initialization via hooks. If the actual > `setup()` method is not calle

Re: Re: Re: Discussion about https://github.com/apache/pulsar/pull/11112

2021-07-06 Thread Neng Lu
IMHO, The old runtime should not be able to run the new functions. New functions require resource initialization via hooks. If the actual `setup()` method is not called (or only a default no-op one is called), then the function is not properly initialized and there'll be problems if they are e

Re: Re: Discussion about https://github.com/apache/pulsar/pull/11112

2021-07-06 Thread Sijie Guo
So there are two compatibility issues we need to consider here. 1) Old runtime to run new functions. 2) New runtime to run old functions. Making the methods with default no-op implementation will resolve 1). Is that correct? We can use reflection to check if the methods exist or not to solve 2),

Re: [VOTE] Apache Pulsar Adapters Release 2.8.0 Candidate 1

2021-07-06 Thread Sijie Guo
Thanks! +1 for this release (despite there are issues reported by Penghui and Rajan) - checked the signatures - checked the staged artifacts - Sijie On Tue, Jul 6, 2021 at 8:42 AM Enrico Olivelli wrote: > > Sijie, > > Il giorno mar 6 lug 2021 alle ore 17:30 Sijie Guo ha > scritto: > > > Hi En

Re: Re: Discussion about https://github.com/apache/pulsar/pull/11112

2021-07-06 Thread Neng Lu
I think the reason is for keeping the original `Function` unchanged, so that existing implemented functions are not affected. On 2021/07/06 03:34:49 Sijie Guo wrote: > Thank you for starting the discussion! > > I have added this proposal to PIP-86: > https://github.com/apache/pulsar/wiki/PIP-86

[Doc] generate docs from code automatically

2021-07-06 Thread Anonymitaet _
Hi Pulsarers, With the rapid adoption of Pulsar, our community is providing many features and enhancements for *Pulsar command-line tools* and *Pulsar configuration*, that is great! Previously, the docs of them are updated *manually*, which is time-consuming and error-prone. To improve the pro

Re: [VOTE] Apache Pulsar Adapters Release 2.8.0 Candidate 1

2021-07-06 Thread Enrico Olivelli
Sijie, Il giorno mar 6 lug 2021 alle ore 17:30 Sijie Guo ha scritto: > Hi Enrico, > > Where is the release process documented? > > I can't find it in > https://github.com/apache/pulsar/wiki/Release-process or in the > pulsar-adapters wiki page. > it is here, in the pulsar-adapters repo https://

Re: [VOTE] Apache Pulsar Adapters Release 2.8.0 Candidate 1

2021-07-06 Thread Sijie Guo
Hi Enrico, Where is the release process documented? I can't find it in https://github.com/apache/pulsar/wiki/Release-process or in the pulsar-adapters wiki page. - Sijie On Mon, Jul 5, 2021 at 2:34 AM Enrico Olivelli wrote: > > Any other vote please ? > > We need at least one more +1 from a PM