[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #71: Basic partitioned producer

2021-06-18 Thread GitBox
blankensteiner commented on a change in pull request #71: URL: https://github.com/apache/pulsar-dotpulsar/pull/71#discussion_r654686078 ## File path: samples/Producing/Program.cs ## @@ -50,7 +50,7 @@ private static async Task Main() private static async Task ProduceMes

[GitHub] [pulsar-adapters] lhotari commented on pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
lhotari commented on pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#issuecomment-863779446 @codelipenghui @sijie Please review. This PR makes CI green and we should then be ready for the 2.8.0 release of pulsar-adapters. -- This is an automated message from the

[GitHub] [pulsar-adapters] codelipenghui commented on a change in pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
codelipenghui commented on a change in pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#discussion_r654194531 ## File path: pulsar-client-kafka-compat/pulsar-client-kafka_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java

[GitHub] [pulsar-adapters] eolivelli commented on a change in pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
eolivelli commented on a change in pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#discussion_r654228733 ## File path: pulsar-client-kafka-compat/pulsar-client-kafka_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java ###

[GitHub] [pulsar-adapters] eolivelli commented on pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
eolivelli commented on pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#issuecomment-863846611 @codelipenghui I like the fact that with this patch all tests passed -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [pulsar-adapters] dlg99 commented on pull request #22: Fixing integration tests KafkaApiTest

2021-06-18 Thread GitBox
dlg99 commented on pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#issuecomment-863581306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [pulsar-adapters] lhotari closed issue #12: Integration tests fail

2021-06-18 Thread GitBox
lhotari closed issue #12: URL: https://github.com/apache/pulsar-adapters/issues/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar-adapters] dlg99 opened a new pull request #22: Fixing integration tests KafkaApiTest

2021-06-18 Thread GitBox
dlg99 opened a new pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22 ### Motivation KafkaApiTest is failing ### Modifications 1. conversion between Pulsar topic name and Kafka TopicPartition ended up with TopicPartition using name with "-partition

[GitHub] [pulsar-adapters] codelipenghui merged pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
codelipenghui merged pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [pulsar-adapters] eolivelli commented on pull request #14: [pulsar-spark] added option for configuring Pulsar client

2021-06-18 Thread GitBox
eolivelli commented on pull request #14: URL: https://github.com/apache/pulsar-adapters/pull/14#issuecomment-863849216 @atezs82 can you please rebase this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-adapters] lhotari commented on issue #12: Integration tests fail

2021-06-18 Thread GitBox
lhotari commented on issue #12: URL: https://github.com/apache/pulsar-adapters/issues/12#issuecomment-863950453 Fixed by #19 and #22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #71: Basic partitioned producer

2021-06-18 Thread GitBox
blankensteiner commented on pull request #71: URL: https://github.com/apache/pulsar-dotpulsar/pull/71#issuecomment-863779058 @jiazhai Sure, I'll do that today :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar-adapters] dlg99 commented on a change in pull request #22: Fixed integration tests

2021-06-18 Thread GitBox
dlg99 commented on a change in pull request #22: URL: https://github.com/apache/pulsar-adapters/pull/22#discussion_r654211393 ## File path: pulsar-client-kafka-compat/pulsar-client-kafka_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java ###

[jira] [Commented] (PULSAR-16) Download page broken links

2021-06-18 Thread Penghui Li (Jira)
[ https://issues.apache.org/jira/browse/PULSAR-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365515#comment-17365515 ] Penghui Li commented on PULSAR-16: -- Hi [~sebb] Thanks for reporting the issue, I have fi