[GitHub] [pulsar-client-node] hrsakai merged pull request #153: Support Reader Listener

2021-05-19 Thread GitBox
hrsakai merged pull request #153: URL: https://github.com/apache/pulsar-client-node/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [pulsar-client-node] k2la commented on a change in pull request #153: Support Reader Listener

2021-05-19 Thread GitBox
k2la commented on a change in pull request #153: URL: https://github.com/apache/pulsar-client-node/pull/153#discussion_r635809844 ## File path: src/Reader.cc ## @@ -66,33 +105,41 @@ class ReaderNewInstanceWorker : public Napi::AsyncWorker { pulsar_result result =

[GitHub] [pulsar-client-node] k2la commented on pull request #155: added functionality for orderingKey in Message.cc

2021-05-19 Thread GitBox
k2la commented on pull request #155: URL: https://github.com/apache/pulsar-client-node/pull/155#issuecomment-844751290 By https://github.com/apache/pulsar-client-node/pull/156, the CI issue already fixed and merged into the master branch. Please rebase your code to make the CI pass. -

[GitHub] [pulsar-client-node] k2la merged pull request #156: Call client.close on tests

2021-05-19 Thread GitBox
k2la merged pull request #156: URL: https://github.com/apache/pulsar-client-node/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar-manager] michaeljmarshall opened a new pull request #384: Use the Apache Pulsar Helm chart

2021-05-19 Thread GitBox
michaeljmarshall opened a new pull request #384: URL: https://github.com/apache/pulsar-manager/pull/384 ### Motivation In reading through the `pulsar-manager` documentation, I noticed that the README points to the StreamNative helm chart. I believe this is likely because the StreamN

[GitHub] [pulsar-manager] aileen5150 opened a new issue #383: Failed to get failureDomains list

2021-05-19 Thread GitBox
aileen5150 opened a new issue #383: URL: https://github.com/apache/pulsar-manager/issues/383 本地通过docker-compose部署了pulsar standalone,pulsar manager 并在pulsar standalone conf文件中设置了jwt鉴权,目前pulsar manager中能正常查看tenants namespaces topics tokens,可以正常增加token,但clusters报错 Failed to get failureDomains

Re: [Java][Client] Important behaviour change on empty key from 2.7.x to 2.8.x

2021-05-19 Thread PengHui Li
> Users of `Message` API should always check `hasKey()` before trying to do `getKey()`. (A better API would have been to return an `Optional`). > In any case, I'd rather not change the behavior of this right now, but leave it in the same form as 2.7 and earlier versions. Make sense Thanks, Pengh