Re: why not process bk error code LedgerFencedException

2021-02-01 Thread yang chen
https://github.com/apache/pulsar/blob/1f7448e42a7946582090e3676c20dcfb06e6398b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java#L170, here, it will close the current ledger, but if the Exception is LedgerFencedException, should we fence the current ledger directly? S

Re: [Discuss] draft PIP for "Changes to GitHub Actions based Pulsar CI"

2021-02-01 Thread Ali Ahmed
We will need some simple connectors without dependencies, to replace the existing ones for basic integration testing. I can write those. On Mon, Feb 1, 2021 at 1:17 PM Sijie Guo wrote: > Yes. I was doing the work there and hopefully will get there soon. > > - Sijie > > On Mon, Feb 1, 2021 at 1

Re: [Discuss] draft PIP for "Changes to GitHub Actions based Pulsar CI"

2021-02-01 Thread Sijie Guo
Yes. I was doing the work there and hopefully will get there soon. - Sijie On Mon, Feb 1, 2021 at 12:40 PM Ali Ahmed wrote: > I recommend we move the connectors away for the pulsar repo to reduce the > load on the main ci pipeline. The new repo seems ready. > https://github.com/apache/pulsar-co

Re: [Discuss] draft PIP for "Changes to GitHub Actions based Pulsar CI"

2021-02-01 Thread Ali Ahmed
I recommend we move the connectors away for the pulsar repo to reduce the load on the main ci pipeline. The new repo seems ready. https://github.com/apache/pulsar-connectors. -Ali On Fri, Jan 29, 2021 at 9:22 AM Sijie Guo wrote: > Currently, Github Actions are shared across one large `apache` >

Re: Fixing flaky tests: help needed

2021-02-01 Thread Lari Hotari
Dear Pulsar community members, Thanks for picking up the work so quickly! I noticed that at least Renkai and Michael already pushed pull requests to fix the flaky tests that were mentioned in the previous email. Some of the PRs have already been merged. Here are 3 more flaky tests with links to a

Re: Fixing flaky tests: help needed

2021-02-01 Thread Lari Hotari
Good idea. I have created https://github.com/apache/pulsar/pull/9398 for adding the issue template for reporting flaky tests. BR, Lari On Sat, Jan 30, 2021 at 8:51 PM Sijie Guo wrote: > > I've been > using this type of template for reporting a flaky test: > https://gist.github.com/lhotari/a5c67

[GitHub] [pulsar-client-node] zhengdai closed issue #139: fatal error: pulsar/c/message.h: No such file or directory

2021-02-01 Thread GitBox
zhengdai closed issue #139: URL: https://github.com/apache/pulsar-client-node/issues/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g