Yunze,
Thanks for you suggestion. Protobuf does have the ability to check whether
a field is existed. But if we want to use this ability, we should get a
Protobuf object first.
In this proposal, RAW_METADATA_MAGIC_NUMBER is used to indicate what type
object we can get from the bytebuf of Entry. I
I think protobuf has the ability to check if a field is enabled. i.e.
RAW_METADATA_MAGIC_NUMBER and RAW_METADATA_SIZE are included in the protobuf-ed
struct. In Kafka, a magic number represents the version of protocol not if the
feature is enabled. If we need a *real* magic number, we must make
+1
Best Regards,
Jennifer
On Mon, Nov 16, 2020 at 8:24 AM PengHui Li wrote:
> +1
> On Nov 15, 2020, 10:48 PM +0800, Jia Zhai , wrote:
> > +1
> >
> > Best Regards.
> >
> >
> > Jia Zhai
> >
> > Beijing, China
> >
> > Mobile: +86 15810491983
> >
> >
> >
> >
> > On Fri, Nov 13, 2020 at 12:32 PM Si
+1
On Nov 15, 2020, 10:48 PM +0800, Jia Zhai , wrote:
> +1
>
> Best Regards.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Fri, Nov 13, 2020 at 12:32 PM Sijie Guo wrote:
>
> > I have cloned the changes to pulsar-connectors, pulsar-adapters, and
> > pulsar-presto. They
I'm happy to announce that we have unanimously approved this release.
There are 3 approving votes, 3 of which are binding:
* Enrico Olivelli
* Sijie Guo
* Jia Zhai
1 non-binding +1 votes:
* Yong Zhang
There are no disapproving votes.
Thank you for the help!
Hi Andre,
Thanks for this proposal. Besides Sijie's comments, there is also a PIP 70:
https://github.com/apache/pulsar/wiki/PIP-70%3A-Introduce-lightweight-raw-Message-metadata,
do you think it could help on this proposal? We have discussed this
consumer filter before, and the performance and pena
+1
Best Regards.
Jia Zhai
Beijing, China
Mobile: +86 15810491983
On Fri, Nov 13, 2020 at 12:32 PM Sijie Guo wrote:
> I have cloned the changes to pulsar-connectors, pulsar-adapters, and
> pulsar-presto. They can be built independently.
>
> However, there is one challenge that we release
