Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Shivji Kumar Jha
+1 Regards, Shivji Kumar Jha http://www.shivjijha.com/ +91 8884075512 On Thu, Oct 29, 2020 at 8:29 AM Jia Zhai wrote: > +1 > > Best Regards. > > > Jia Zhai > > Beijing, China > > Mobile: +86 15810491983 > > > > > On Thu, Oct 29, 2020 at 9:02 AM Sijie Guo wrote: > > > > Would it make sense to

Re: [DISCUSS] PIP-Add ProtobufNative Schema Support

2020-10-28 Thread Yuva raj
Hi Guowei, How does the nested protobuf will be handled? Lets say protobuf A embeds B do we register both of the schemas in the schema registry in single schema? On Wed, 28 Oct 2020 at 20:02, ηŽ‹ε›½δΌŸ wrote: > ProtobufNative Schema Support proposes to import a new protobuf-v3 >

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Jia Zhai
+1 Best Regards. Jia Zhai Beijing, China Mobile: +86 15810491983 On Thu, Oct 29, 2020 at 9:02 AM Sijie Guo wrote: > > Would it make sense to create a PIP to document this proposal and > possible > decision that is later made when the proposal is approved? > > Proposals usually start with

Re: [DISCUSS] PIP-Add ProtobufNative Schema Support

2020-10-28 Thread Jia Zhai
Thanks Guowei for the initiative. Support native protobuf would be a great enhancement for current schema. πŸ‘ Best Regards. Jia Zhai Beijing, China Mobile: +86 15810491983 On Wed, Oct 28, 2020 at 10:32 PM ηŽ‹ε›½δΌŸ wrote: > ProtobufNative Schema Support proposes to import a new protobuf-v3

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Sijie Guo
> Would it make sense to create a PIP to document this proposal and possible decision that is later made when the proposal is approved? Proposals usually start with a discussion. If there is no major disagreement, a PIP is usually required for documenting major changes. A vote thread is used for

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Lari Hotari
This sounds good. Would it make sense to create a PIP to document this proposal and possible decision that is later made when the proposal is approved? I can find a PIP that is slightly related, it's https://github.com/apache/pulsar/wiki/PIP-47%3A-Time-Based-Release-Plan . It's probably not neces

[DISCUSS] PIP-Add ProtobufNative Schema Support

2020-10-28 Thread ηŽ‹ε›½δΌŸ
ProtobufNative Schema Support proposes to import a new protobuf-v3 schema based on protobuf native Descriptor, Current `ProtobufSchema` is based on AVRO schema, this Causes the following restrictions : ProtobufSchema based on avro-protobuf only works only when JVM classloader can load `J

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Jinfeng Huang
Hi Yong, Awesome~ I just can't wait to try it. Best Regards, Jennifer On Wed, Oct 28, 2020 at 7:37 PM Enrico Olivelli wrote: > In BookKeeper project we have a script that does the merge to the target > branch, handles cherry picks and also updates GitHub milestones and labels > > it should wor

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Enrico Olivelli
In BookKeeper project we have a script that does the merge to the target branch, handles cherry picks and also updates GitHub milestones and labels it should work well on Pulsar Repository as well https://github.com/apache/bookkeeper/blob/master/dev/bk-merge-pr3.py Enrico Il giorno mer 28 ott 2

Re: [DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Yuva raj
This is awesome! On Wed, 28 Oct 2020 at 16:22, Yong Zhang wrote: > Hi developers, > I want to introduce a command for cherry-picking PRs automatically. > > When we releasing a minor version of Pulsar, we need to cherry-pick the bug > fix PRs > into the release branch. Cherry-pick a lot of PRs w

[DISCUSS] Introduce a cherry-pick command for cherry-picking PRs automatically

2020-10-28 Thread Yong Zhang
Hi developers, I want to introduce a command for cherry-picking PRs automatically. When we releasing a minor version of Pulsar, we need to cherry-pick the bug fix PRs into the release branch. Cherry-pick a lot of PRs will take a long time and sometimes there has some conflict need to resolve. I

Slack digest for #dev - 2020-10-28

2020-10-28 Thread Apache Pulsar Slack
2020-10-27 13:49:15 UTC - Lari Hotari: The flakiness problem is really bad. It's hard to get a pass. It takes 5-6 attempts in many cases to get a PR to pass. 2020-10-27 13:49:41 UTC - Lari Hotari: I created an issue for InactiveTopicDeleteTest:

[GitHub] [pulsar-manager] g0715158 opened a new issue #349: Hope to perform performance testing under the front-end third-party high version dependency package

2020-10-28 Thread GitBox
g0715158 opened a new issue #349: URL: https://github.com/apache/pulsar-manager/issues/349 The dependencies between packages are messy. You can tune them if you have time. For example, webpack. Some packages require version 3.0.0|4.0.0 when they depend on it. Some packages also require 4.1