[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r491006106 ## File path: pulsar-version.txt ## @@ -1 +1 @@ -2.5.0 +2.6.1 Review comment: Yes. I think the C++ client used for testing should be the

[GitHub] [pulsar-manager] Huanli-Meng commented on a change in pull request #337: Update readme file

Huanli-Meng commented on a change in pull request #337: URL: https://github.com/apache/pulsar-manager/pull/337#discussion_r490906248 ## File path: README.md ## @@ -113,6 +104,28 @@ The Pulsar Manager can be deployed as part of [Pulsar Helm Chart](https://github ``` A

[GitHub] [pulsar-client-node] savearray2 commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

savearray2 commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490864912 ## File path: pulsar-version.txt ## @@ -1 +1 @@ -2.5.0 +2.6.1 Review comment: Would you like me to change this to ```2.6.0``` instead

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490842089 ## File path: tests/end_to_end.test.js ## @@ -376,5 +376,53 @@ const Pulsar = require('../index.js'); await reader.close(); await

Slack digest for #dev - 2020-09-18

2020-09-17 16:58:32 UTC - Stepan Mazurov: are wire protocols different? 2020-09-17 23:57:55 UTC - Addison Higham: Hey, sorry @Jonathan Ellis I didn't see this till now, were you able to get this resolved? 2020-09-18 00:01:41 UTC - Addison Higham: that dependency is actually internal to

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490811096 ## File path: tests/end_to_end.test.js ## @@ -376,5 +376,53 @@ const Pulsar = require('../index.js'); await reader.close(); await

[GitHub] [pulsar-client-node] savearray2 commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

savearray2 commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490790233 ## File path: tests/end_to_end.test.js ## @@ -376,5 +376,53 @@ const Pulsar = require('../index.js'); await reader.close(); awai

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490757691 ## File path: tests/end_to_end.test.js ## @@ -376,5 +376,53 @@ const Pulsar = require('../index.js'); await reader.close(); await

[GitHub] [pulsar-client-node] massakam commented on pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#issuecomment-694700191 Please resolve the conflict. This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490747820 ## File path: tests/end_to_end.test.js ## @@ -376,5 +376,53 @@ const Pulsar = require('../index.js'); await reader.close(); await

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #121: Includes Support for ZSTD and SNAPPY Compression

massakam commented on a change in pull request #121: URL: https://github.com/apache/pulsar-client-node/pull/121#discussion_r490745802 ## File path: pulsar-version.txt ## @@ -1 +1 @@ -2.5.0 +2.6.1 Review comment: ZSTD and SNAPPY seem to be available from Pulsar v2.6.0.