Re: Apache Pulsar coding guide

2019-11-01 Thread Sijie Guo
Jinfeng, Thank you for driving this effort! Given the tight dependencies between these two communities, I think it is okay to use the coding guide from BookKeeper. A lot of Pulsar committers are also BookKeeper committers. Having a consistent coding guide between two communities would actually he

Re: [ DISCUSS ]PIP-50: Package Management

2019-11-01 Thread Sijie Guo
Hi Yong, Thank you for putting this together. The overall approach looks good to me. Since we already use bookkeeper for package management, this proposal just abstracts the package management into a common facility. That seems totally reasonable. I have two suggestions: 1) make the package stor

Re: [discuss]About api documentation

2019-11-01 Thread Sijie Guo
Guangning, Thank you for bringing this topic up and driving the efforts for making the Pulsar website great. Comments inline. On Sat, Nov 2, 2019 at 9:51 AM Guangning E wrote: > Recently, community users complained about API documents, including > missing, wrong version, wrong link, contradict

[discuss]About api documentation

2019-11-01 Thread Guangning E
Recently, community users complained about API documents, including missing, wrong version, wrong link, contradictory content, etc. After doing some work and communicating with the asf framework group through Jira https://issues.apache.org/jira/browse/INFRA-19358, I found that the latest version of

Re: [PIP-48] Hierarchical admin api

2019-11-01 Thread Matteo Merli
On Thu, Oct 31, 2019 at 4:12 AM Sijie Guo wrote: > > Hi Matteo, > > I think the main proposal that Florentin and Steven proposed is to define a > `scope` for each restful api. I get the "scope" part, though it comes out confusing in proposal since there are multiple statements either not accurate

Slack digest for #dev - 2019-11-01

2019-11-01 Thread Apache Pulsar Slack
2019-10-31 10:57:12 UTC - Florentin Dubois: I am not confident to create a new api using grpc. Because, this make hard to integrate with the web environment. 2019-10-31 11:19:11 UTC - Vladimir Shchur: Hi! Can someone give a comment regarding this method