Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Sijie Guo
It is the time for the community to discuss. Since 2.4 has already accumulated 1+ month changes, we should be ready to cut a release soon. So ideally we should just wrap the in progress changes and release 2.4.0. If the features are not started yet, we can push those features to 2.5.0. That what we

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Jerry Peng
Are we collecting a list of still in-progress features for 2.4 or are we collecting a list of all the features going into 2.4? On Mon, Apr 22, 2019 at 9:36 PM Sijie Guo wrote: > I think Penghui was just trying to collect a list of features to be > included in 2.4.0 and have a discussion thread t

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Sijie Guo
I think Penghui was just trying to collect a list of features to be included in 2.4.0 and have a discussion thread to include any missed items. So that he can have a better estimation on when to cut the 2.4.0 release. “Feature Freeze” is probably not the right word here, but it is a common concept

[GitHub] [pulsar-client-node] nkurihar closed issue #7: Add Tests and Test Framework

2019-04-22 Thread GitBox
nkurihar closed issue #7: Add Tests and Test Framework URL: https://github.com/apache/pulsar-client-node/issues/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar-client-node] nkurihar commented on issue #7: Add Tests and Test Framework

2019-04-22 Thread GitBox
nkurihar commented on issue #7: Add Tests and Test Framework URL: https://github.com/apache/pulsar-client-node/issues/7#issuecomment-485636236 Fixed by: https://github.com/apache/pulsar-client-node/pull/26 https://github.com/apache/pulsar-client-node/pull/27 -

[GitHub] [pulsar-client-node] nkurihar merged pull request #27: Add scripts for tests in docker container

2019-04-22 Thread GitBox
nkurihar merged pull request #27: Add scripts for tests in docker container URL: https://github.com/apache/pulsar-client-node/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-client-node] nkurihar merged pull request #28: Upgrade js-yaml to fix security vulnerability

2019-04-22 Thread GitBox
nkurihar merged pull request #28: Upgrade js-yaml to fix security vulnerability URL: https://github.com/apache/pulsar-client-node/pull/28 This is an automated message from the Apache Git Service. To respond to the message, pl

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Jerry Peng
Yup the PMC usually need to vote on something like this and be in agreement before such a freeze can take into effect. -Jerry On Mon, Apr 22, 2019 at 8:24 PM Matteo Merli wrote: > Negative acks also would be a new feature of 2.4, not just its exposure in > interceptors. > > On Mon, Apr 22, 2019

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Matteo Merli
Negative acks also would be a new feature of 2.4, not just its exposure in interceptors. On Mon, Apr 22, 2019 at 8:07 PM Matteo Merli wrote: > NodeJS client was meant for 2.4 as well. > > On Mon, Apr 22, 2019 at 8:06 PM Matteo Merli > wrote: > >> Replicated subscriptions are meant for 2.4 >> >>

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Matteo Merli
Finally, we never had the concept of a feature freeze. Before declaring one, and with immediate effect, it would have to be discussed to get an agreement around it On Mon, Apr 22, 2019 at 8:16 PM Matteo Merli wrote: > Negative acks also would be a new feature of 2.4, not just its exposure in > i

[GitHub] [pulsar-client-node] hrsakai commented on a change in pull request #27: Add scripts for tests in docker container

2019-04-22 Thread GitBox
hrsakai commented on a change in pull request #27: Add scripts for tests in docker container URL: https://github.com/apache/pulsar-client-node/pull/27#discussion_r277505239 ## File path: pulsar-test-service-start.sh ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the Ap

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Matteo Merli
NodeJS client was meant for 2.4 as well. On Mon, Apr 22, 2019 at 8:06 PM Matteo Merli wrote: > Replicated subscriptions are meant for 2.4 > > On Mon, Apr 22, 2019 at 7:58 PM PengHui Li > wrote: > >> Hi all, >> >> >> There are already a lot of great features in 2.4.0. It is time to release >> 2.

Re: Release 2.4.0 - Feature Freeze

2019-04-22 Thread Matteo Merli
Replicated subscriptions are meant for 2.4 On Mon, Apr 22, 2019 at 7:58 PM PengHui Li wrote: > Hi all, > > > There are already a lot of great features in 2.4.0. It is time to release > 2.4.0 now. I am calling a feature freeze for 2.4.0. We are not going to > accept any new features from now. Peo

Release 2.4.0 - Feature Freeze

2019-04-22 Thread PengHui Li
Hi all, There are already a lot of great features in 2.4.0. It is time to release 2.4.0 now. I am calling a feature freeze for 2.4.0. We are not going to accept any new features from now. People still have time to complete the ongoing features and any bug fixes. The code change will be freeze in

[GitHub] [pulsar-client-node] merlimat commented on a change in pull request #27: Add scripts for tests in docker container

2019-04-22 Thread GitBox
merlimat commented on a change in pull request #27: Add scripts for tests in docker container URL: https://github.com/apache/pulsar-client-node/pull/27#discussion_r277498047 ## File path: pulsar-test-service-start.sh ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the A

[GitHub] [pulsar-client-node] hrsakai opened a new pull request #28: Upgrade js-yaml to fix security vulnerability

2019-04-22 Thread GitBox
hrsakai opened a new pull request #28: Upgrade js-yaml to fix security vulnerability URL: https://github.com/apache/pulsar-client-node/pull/28 upgrade js-yaml from `3.13.0` to `3.13.1`. `tar` package also has security vulnerability, but the latest version of `node-gyp` package(requires

Slack digest for #dev - 2019-04-22

2019-04-22 Thread Apache Pulsar Slack
2019-04-21 09:38:01 UTC - DT: @DT has joined the channel 2019-04-21 11:42:07 UTC - pradeep: @pradeep has joined the channel

[GitHub] [pulsar-client-node] hrsakai opened a new pull request #27: Add scripts for tests in docker container

2019-04-22 Thread GitBox
hrsakai opened a new pull request #27: Add scripts for tests in docker container URL: https://github.com/apache/pulsar-client-node/pull/27 `docker-tesh.sh` script executes tests in following steps. 1. Run docker container 2. Download/install cpp client pkg 3. Download pulsar distrib