Re: PIP-27: add checklist in github pull request template

2019-01-02 Thread Matteo Merli
Instead of placing this content in PULL_REQUEST_TEMPLATE.md I would rather have it in CONTRIBUTING.md file. The reason is that currently even the minimal PULL_REQUEST_TEMPLATE is being left as it is and not interpreted as a "template" to modifiy when creating a PR. Also I'd change the current tem

Re: PIP-27: add checklist in github pull request template

2019-01-02 Thread Sijie Guo
If there is no objection or no more review comments, I would like to merge and close the issue tomorrow. (btw, happy new year to everyone in the community!) - Sijie On Wed, Dec 26, 2018 at 9:41 AM Sijie Guo wrote: > FYI. I've updated the pull request to incorporate Eren's suggestions. > > - Si