Re: PIP-27: add checklist in github pull request template

+1, for Eren's and Raj's useful comments. On Wed, Dec 26, 2018 at 3:36 AM Eren Avsarogullari < erenavsarogull...@gmail.com> wrote: > Thanks Sijie. > > On Tue, 25 Dec 2018 at 18:14, Sijie Guo wrote: > > > Thank y'all for your feedback. I created a PR for this PIP - > > https://github.com/apache/p

Re: PIP-27: add checklist in github pull request template

Thanks Sijie. On Tue, 25 Dec 2018 at 18:14, Sijie Guo wrote: > Thank y'all for your feedback. I created a PR for this PIP - > https://github.com/apache/pulsar/pull/3252 > > However I missed Eren's comments before. I will incorporate your comments > into the PR. > > Thank you, > Sijie > > On Fri,

Re: PIP-27: add checklist in github pull request template

Thank y'all for your feedback. I created a PR for this PIP - https://github.com/apache/pulsar/pull/3252 However I missed Eren's comments before. I will incorporate your comments into the PR. Thank you, Sijie On Fri, Dec 21, 2018 at 2:28 PM Eren Avsarogullari < erenavsarogull...@gmail.com> wrote: