Re: Guidance for new persistence implementation

2025-05-29 Thread Yufei Gu
Hi Keith, I don't think we’ve reached consensus on having NoSQL impl its own top-level module in the main Polaris repo. We only floated MongoDB as a possible single-module in the main repo, with a clear justification. More broadly, I’m worried about packing every new persistence implementation in

Re: Guidance for new persistence implementation

2025-05-28 Thread Keith Chapman
Hi Yufei, Thanks for putting this together, much appreciated. The document does highlight some useful design principles (such as not mixing business logic and leaking implementation details) which are true in general. These are not necessarily limited to persistence IMHO. We have discussed persis

Re: Guidance for new persistence implementation

2025-05-27 Thread Dmitri Bourlatchkov
That location is fine, although I do not really see why contributing to Persistence should be any different from contributing to other areas of Polaris code. Cheers, Dmitri. On Tue, May 27, 2025 at 7:03 PM Yufei Gu wrote: > Dmitri, we could place it along with existing contribution guidelines,

Re: Guidance for new persistence implementation

2025-05-27 Thread Yufei Gu
Dmitri, we could place it along with existing contribution guidelines, https://polaris.apache.org/community/contributing-guidelines/, but I'm open to suggestions. Yufei On Tue, May 27, 2025 at 2:10 PM Dmitri Bourlatchkov wrote: > Hi Yufei, > > I posted some comments in the doc. > > Where do yo

Re: Guidance for new persistence implementation

2025-05-27 Thread Dmitri Bourlatchkov
Hi Yufei, I posted some comments in the doc. Where do you intend to publish it? Do we need a special process for Persistence code contributions on top of our general contribution guidelines? Thanks, Dmitri. On Tue, May 27, 2025 at 4:30 PM Yufei Gu wrote: > Hi folks, > > After meeting with a