Re: [DISCUSS] CODEOWNERS file

2025-06-13 Thread Jean-Baptiste Onofré
Hi I agree to remove the file. It doesn’t have any impact on committee privileges (that’s manage on whimsy). Regards JB Le ven. 13 juin 2025 à 19:17, Yufei Gu a écrit : > Agreed to remove automatic tagging. Just one minor concern, does removing > CODEOWNERS impact committers' write privilege?

Re: [DISCUSS] CODEOWNERS file

2025-06-13 Thread Dmitri Bourlatchkov
I'm fine with removing CODEOWNERS completely. However, AFAIK CODEOWNERS allows selective attribution by regex or something like that. How about we keep CODEOWNERS but link committers to code areas voluntarily? I mean each committer could personally make a PR against CODEOWNERS to get notified on

Re: [DISCUSS] CODEOWNERS file

2025-06-13 Thread Dmitri Bourlatchkov
AFAIK, CODEOWNERS is just for notifications. Write access is configured differently. Cheers, Dmitri. On Fri, Jun 13, 2025 at 1:18 PM Yufei Gu wrote: > Agreed to remove automatic tagging. Just one minor concern, does removing > CODEOWNERS impact committers' write privilege? I hope not. > > Yufei

Re: [DISCUSS] CODEOWNERS file

2025-06-13 Thread Yufei Gu
Agreed to remove automatic tagging. Just one minor concern, does removing CODEOWNERS impact committers' write privilege? I hope not. Yufei On Fri, Jun 13, 2025 at 9:48 AM Eric Maynard wrote: > I agree that the automatic tagging is getting out of hand, thanks for > raising this. I think just de

Re: [DISCUSS] CODEOWNERS file

2025-06-13 Thread Eric Maynard
I agree that the automatic tagging is getting out of hand, thanks for raising this. I think just deleting CODEOWNERS is a pretty good idea. Once that's done however, I worry that a potential contributor might not know who to tag on a PR and might either just pick someone randomly or be stuck waiti