Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-20 Thread Yufei Gu
+1 Thanks for working on this, Adnan! It's also nice to mention it in the changelog as Dmitri pointed out. Yufei On Fri, Sep 19, 2025 at 8:58 AM Dmitri Bourlatchkov wrote: > +0 As I commented in GH, code changes LGTM (as of commit f0b6896), but I > believe we ought to mention the change in API

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Dmitri Bourlatchkov
+1 (binding, also approved in GH) Thanks for the CHANGELOG update, Adnan! Given that the purpose of this vote is to confirm the REST API response changes, I believe the CHANGELOG update does _not_ invalidate previously cast votes. Cheers, Dmitri. On Fri, Sep 19, 2025 at 6:41 PM Adnan Hemani wr

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Adnan Hemani
Thanks all - I’ve pushed the change to the CHANGELOG. Dmitri, please take a look and let us know if that changes your vote! Best, Adnan Hemani > On Sep 19, 2025, at 3:20 PM, Honah J. wrote: > > +1 (non-binding) and +1 for adding that to the changelog. > > Thanks Adnan for working on this! >

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Honah J.
+1 (non-binding) and +1 for adding that to the changelog. Thanks Adnan for working on this! Best regards, Jonas On Fri, Sep 19, 2025 at 5:19 PM Michael Collado wrote: > +1 > > Mike > > On Fri, Sep 19, 2025 at 10:46 AM Alexandre Dutra > wrote: > > > +1 for the change and +1 for the changelog.

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Michael Collado
+1 Mike On Fri, Sep 19, 2025 at 10:46 AM Alexandre Dutra wrote: > +1 for the change and +1 for the changelog. Thanks Adnan! > > On Fri, Sep 19, 2025 at 7:39 PM Yufei Gu wrote: > > > > +1 Thanks for working on this, Adnan! It's also nice to mention it in the > > changelog as Dmitri pointed out.

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Alexandre Dutra
+1 for the change and +1 for the changelog. Thanks Adnan! On Fri, Sep 19, 2025 at 7:39 PM Yufei Gu wrote: > > +1 Thanks for working on this, Adnan! It's also nice to mention it in the > changelog as Dmitri pointed out. > > Yufei > > > On Fri, Sep 19, 2025 at 8:58 AM Dmitri Bourlatchkov > wrote:

Re: [VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-19 Thread Dmitri Bourlatchkov
+0 As I commented in GH, code changes LGTM (as of commit f0b6896), but I believe we ought to mention the change in API behaviour in CHANGELOG.md Cheers, Dmitri. On Thu, Sep 18, 2025 at 9:46 PM Adnan Hemani wrote: > Hi all, > > I propose that we make a change to the OpenAPI spec to return the ne

[VOTE] Change Create APIs to Return Newly-Created Objects

2025-09-18 Thread Adnan Hemani
Hi all, I propose that we make a change to the OpenAPI spec to return the newly created object in each of the following APIs: createCatalog, createPrincipalRole, and createCatalogRole. ML thread regarding this topic here . A dra