Re: [DISCUSS] Injecting RealmContext

2025-06-09 Thread yun zou
Hi Dmitri, Thanks a lot for the clarification! I didn't realize PolarisMetaStoreManager is a request-scoped bean. I have to say that the whole implementation is kind of confusing. Although I do agree that those *MetastoreManagerImpl is not needed after the request ends, i am afraid things may not

Re: [DISCUSS] Injecting RealmContext

2025-06-09 Thread Michael Collado
I'd prefer to avoid having the APIs reflect the scope of the implementation beans under the hood. On the other hand, I don't like forcing methods at the bottom of the call stack requiring parameters because they're necessary later on. I liked passing CallContext around because it didn't really matt

Re: [DISCUSS] Injecting RealmContext

2025-06-09 Thread Dmitri Bourlatchkov
Thanks for stating your concerns, Yun! Re: MetastoreManager, I believe the current state of that code is actually the source of confusion and I'm trying to clarify that. For example, TransactionalMetaStoreManagerImpl is currently created per realm. However, this class does not carry any state. It

Re: Polaris Event Persistence Schema

2025-06-09 Thread Adnan Hemani
Hi Yufei, Thanks for the comments, I’ve addressed all of them. The second half of the document briefly outlines how we will transform the Polaris internal persistence events into Iceberg Events to return back as part of the Iceberg Event Endpoint. Best, Adnan Hemani > On Jun 8, 2025, at 4:02 

Re: [DISCUSS] Injecting RealmContext

2025-06-09 Thread yun zou
Hi Dmitri, Thanks for bringing that up! I am not an expert with CDI, based my recent experience with CDI, while CDI does help making development simpler under many cases, it does also make things more complicated under some scenarios. Especially when injecting a request scoped object into applica