Re: [Proposal] Distinguish Iceberg vs non-Iceberg APIs in Polaris

2025-01-29 Thread Honah J.
Hi everyone, Thanks for the feedback! I've created PR: https://github.com/apache/polaris/pull/906 to implement the proposed solution. I've also linked the PR to the issue pointed out by Robert. Best regards, Honah On Wed, Jan 29, 2025 at 1:54 AM Robert Stupp wrote: > Noting: there's an issue t

Re: Proposal: Use of Realm Instead of RealmId

2025-01-29 Thread Yufei Gu
Having a consistent name across the system is a huge benefit for users and developers. There would be less confusion and less cognitive burden for everyone. Otherwise, people may keep thinking "realm" and "realmId" are different things. As I said in the proposal, the name "realm" is already widely

Re: Proposal: Use of Realm Instead of RealmId

2025-01-29 Thread Eric Maynard
> Renaming `RealmId` to `Realm` and then also add another `RealmXyz` type makes it difficult to distinguish, causing unnecessary more confusion. I didn't see another such type in Yufei's PR , unless you're talking about the ImmutableRealmId type you add

Re: Proposal: Use of Realm Instead of RealmId

2025-01-29 Thread Robert Stupp
Thinking more about this, having a huge change just for a nomenclature thing is really not worth the effort, so I'm against such a rename. On 29.01.25 11:02, Robert Stupp wrote: Let's take a step back. The documented contract of the old `RealmContext` was to provide the realm-ID from a REST r

Re: Identifying "copied code"

2025-01-29 Thread Jean-Baptiste Onofré
Hi Robert, Thanks for this work ! As you said, it's pretty hard to do all by magic, but any "tool" that can help is welcome. I would also remind any contributor that it's important to update LICENSE when a contributor copies code from another project. So I hope we would not need this gradle task

Identifying "copied code"

2025-01-29 Thread Robert Stupp
Hi, recently there are discussions related to the 0.9.0rcX releases about properly mentioning code/files from other projects. Although there is no technical solution to automatically identify such code/files (unless you have a big machinery just for that topic...), I think we can at least he

Re: Proposal: Use of Realm Instead of RealmId

2025-01-29 Thread Robert Stupp
Let's take a step back. The documented contract of the old `RealmContext` was to provide the realm-ID from a REST request - nothing more, nothing less - that's all what's been implemented. And this is exactly the reason why the current type is called `RealmId`. Renaming `RealmId` to `Realm`

[Iceberg Summit 25] Registration is live!

2025-01-29 Thread Jean-Baptiste Onofré
Hi folks, I'm very happy to share that the registration for the Iceberg Summit 2025 is officially live! https://www.icebergsummit2025.com/ We are looking forward to see you there (in person or virtual ;)) ! Regards JB

Re: [Proposal] Distinguish Iceberg vs non-Iceberg APIs in Polaris

2025-01-29 Thread Robert Stupp
Noting: there's an issue to track this: https://github.com/apache/polaris/issues/553 On 28.01.25 21:24, Yufei Gu wrote: Thanks Honah for picking it up. The approach looks good to me overall. Left some comments in the PR. Yufei On Tue, Jan 28, 2025 at 7:22 AM Dmitri Bourlatchkov wrote: Usi