Hi Ryan
1. For the LICENSE file, I agree with you: the LICENSE should only
contain 3rd party *code* included in the *source*
release (dependencies don't matter here).
2. For the NOTICE file, I don't think it should be so "simple" for two reasons:
2.1 According to the section 4.d of the ALv2, the N
Hi,
I did a new pass on NOTICE and LICENSE file. For context and reminder:
1. NOTICE file should be minimal, and not list license information, so
it's not correct in RC1. The NOTICE file should also contain NOTICE
files from ALv2 software used by Polaris.
2. LICENSE file is also not correct in RC
Hi,
Maven versioning only partially adheres to semver:
https://books.sonatype.com/mvnref-book/reference/pom-relationships-sect-pom-syntax.html
Regarding the -SNAPSHOT token, the docs do not mention the case when the
qualifier is -SNAPSHOT but I believe it’s expanded just the
same. However the .S
Hi Dmitri
No, it's not correct as it doesn't respect the Maven SNAPSHOT, that
expects -SNAPSHOT (not .SNAPSHOT).
So, I think it's better to keep 1.0.0-incubating-SNAPSHOT and use
1.0.0-incubating at release time.
Regards
JB
On Thu, Nov 21, 2024 at 8:04 PM Dmitri Bourlatchkov
wrote:
>
> Hi All,
I cancel this vote to fix the different issues identified in RC1.
Regards
JB
On Sun, Nov 17, 2024 at 7:00 AM Jean-Baptiste Onofré wrote:
>
> Hi everyone,
>
> I propose that we release the following RC as the official Apache
> Polaris 0.9.0-incubating release.
>
> * This corresponds to the tag: a
Good point, Yufei... I mis-interpreted the spec :|
On Thu, Nov 21, 2024 at 2:41 PM Yufei Gu wrote:
> I think *1.0.0-incubating-SNAPSHOT *is the valid one per my understanding.
>
> A pre-release version MAY be denoted by appending a hyphen and a series of
> > dot separated identifiers immediately
I agree for NOTICE.
The problem is that the gradle part generating LICENSE scan the
transitive (jersey-json coming from dropwizard), whereas it should
not, especially for source distribution.
I made changes a while ago but it has not been included (it was when
landed at ASF, it has been probably
I think *1.0.0-incubating-SNAPSHOT *is the valid one per my understanding.
A pre-release version MAY be denoted by appending a hyphen and a series of
> dot separated identifiers immediately following the patch version.
> Identifiers MUST comprise only ASCII alphanumerics and hyphens
> [0-9A-Za-z-]
Wouldn't that cause issues with maven repositories when trying to upload
the artifacts (possibly miscategorized as release artifacts instead of
snapshots)?
On Thu, Nov 21, 2024 at 11:06 AM Dmitri Bourlatchkov
wrote:
> Hi All,
>
> This may be nitpicky but the current version in local builds is
>
-1 (binding)
I don't think that the license documentation is sufficient. It looks like
the LICENSE file for the source tarball was auto-generated from
dependencies and doesn't document the difference between dependencies and
sources that are included. There is at least one library, jersey-json, th
Hi All,
This may be nitpicky but the current version in local builds is
"1.0.0-incubating-SNAPSHOT", which does not appear to follow semver [1].
I suppose a semver-compatible version number would be
"1.0.0-incubating.SNAPSHOT" (a dot instead of the second dash).
Would it work from your POV?
Tha
Good call Dmitri.
I agree with this plan.
Is everyone happy with that ?
Regards
JB
On Thu, Nov 21, 2024 at 12:46 AM Dmitri Bourlatchkov
wrote:
>
> I believe the 0.9.0 release was meant to be a trial release to test the
> process. With that in mind, in-memory polaris still works fine in 0.9.0.
12 matches
Mail list logo
