kdebski85 commented on code in PR #352:
URL: https://github.com/apache/poi/pull/352#discussion_r1086343835
##
poi-examples/src/main/java/org/apache/poi/examples/xwpf/usermodel/BetterHeaderFooterExample.java:
##
@@ -48,7 +49,7 @@ public static void main(String[] args) throws IOEx
asfgit closed pull request #423: Bump mockito-core from 4.11.0 to 5.1.0
URL: https://github.com/apache/poi/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
gastaldi opened a new pull request, #425:
URL: https://github.com/apache/poi/pull/425
`ERROR: java.lang.UnsatisfiedLinkError: no awt in java.library.path` is
thrown when attempting to build a native image that depends on AWT on macOS.
See the following issue for more details:
-
pjfanning commented on code in PR #425:
URL: https://github.com/apache/poi/pull/425#discussion_r1096547662
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -63,7 +63,7 @@ protected SXSSFSheet(SXSSFWorkbook workbook, XSSFSheet
xSheet, int randomAcc
asfgit closed pull request #424: Bump org.mockito:mockito-core from 4.11.0 to
5.1.1
URL: https://github.com/apache/poi/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #424:
URL: https://github.com/apache/poi/pull/424#issuecomment-1416777934
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416778735
Can you close this? - I committed
https://github.com/apache/poi/commit/040181c42fdfbe15b706e8ae81f5e2f6fe87554c
and there are a few more similar cases in the code that should probably be
cha
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416780526
The catch you modified - that was only added recently and no release has
ever included it. Are you sure that InternalError catch was not enough?
--
This is an automated message from the Apa
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416780928
Thanks, I noticed that `SheetUtil` also uses some AWT code in
`org.apache.poi.ss.util.SheetUtil.getCellWidth` that could use this try-catch
as well
--
This is an automated message from the
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416781069
Can you share the stack traces you are getting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416781744
> The catch you modified - that was only added recently and no release has
ever included it. Are you sure that InternalError catch was not enough?
Yes, I am sure. The thrown exception is
gastaldi closed pull request #425: Catch `Throwable` when using the AWT classes
URL: https://github.com/apache/poi/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416782086
Here is the stacktrace without the system property set:
```
Caused by: java.lang.UnsatisfiedLinkError: no awt in java.library.path
at
org.graalvm.nativeimage.builder/com.orac
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416782228
Thanks - the exception name is enough for me - so UnsatisfiedLinkError is
the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416782378
> Thanks - the exception name is enough for me - so UnsatisfiedLinkError is
the issue
Yes, as I mentioned in the first comment of this PR 😄
--
This is an automated message from the A
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416782615
So I updated SheetUtil in
https://github.com/apache/poi/commit/040181c42fdfbe15b706e8ae81f5e2f6fe87554c -
is that enough?
--
This is an automated message from the Apache Git Service.
To re
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416782703
This is the stacktrace when the `org.apache.poi.ss.ignoreMissingFontSystem`
is set to `true`:
```java
Caused by: java.lang.NoClassDefFoundError: Could not initialize class
java.awt.
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416783091
> So I updated SheetUtil in
[040181c](https://github.com/apache/poi/commit/040181c42fdfbe15b706e8ae81f5e2f6fe87554c)
- is that enough?
I think you also need to add catch any AWT operati
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416784344
Can you provide a stack trace where getFontAt fails? If that is failing, I
think there will be loads of changes needed.
Would it not be easier to install fonts yourself?
--
This is a
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416785554
The problem is that AWT is not available in a GraalVM native image built in
MacOS because of https://github.com/oracle/graal/issues/4124, so I get
`NoClassDefFoundError`s and the `java.lang.Un
xzel23 commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1416840963
Wouldn't it be better to guard awt calls by checking for headless mode
instead of catching UnsatisfiedLinkError?
--
This is an automated message from the Apache Git Service.
To respond to the
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1418244514
@xzel23 this issue is hard to test. I ran the SXSSF tests with GraalVM on my
Mac and had no issues (with and without this code change).
We have no POI road map for a POI 6 release that
xzel23 commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1418247446
@pjfanning I see this as rather a GraalVM problem than a POI one. If you
couldn't reproduce the problem on your Mac (the GraalVM issue has already been
fixed on Windows but not on MacOS), it's p
gastaldi commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1418257194
I managed to bypass the AWT issues by replacing the methods in the classes
that use it.
See https://github.com/quarkiverse/quarkus-poi
--
This is an automated message from the Apache
pjfanning commented on PR #425:
URL: https://github.com/apache/poi/pull/425#issuecomment-1418267841
I reverted the bulk of my recent changes with
https://github.com/apache/poi/commit/43551babf1cf628aa184a2f9445412815781dc9e -
the new code still treats UnsatisfiedLinkError as meaning AWT is
dependabot[bot] opened a new pull request, #426:
URL: https://github.com/apache/poi/pull/426
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.12.22 to 1.12.23.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-b
dependabot[bot] opened a new pull request, #427:
URL: https://github.com/apache/poi/pull/427
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.12.22 to 1.12.23.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:
asfgit closed pull request #426: Bump net.bytebuddy:byte-buddy from 1.12.22 to
1.12.23
URL: https://github.com/apache/poi/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
asfgit closed pull request #427: Bump net.bytebuddy:byte-buddy-agent from
1.12.22 to 1.12.23
URL: https://github.com/apache/poi/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #426:
URL: https://github.com/apache/poi/pull/426#issuecomment-1424362742
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #427:
URL: https://github.com/apache/poi/pull/427#issuecomment-1424362768
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
gtoison opened a new pull request, #428:
URL: https://github.com/apache/poi/pull/428
SXSSFCell.getColumnIndex() gets slow when writing thousands of columns
because we linearly search through all the cells in a row.
Since the column index is already known when creating a new cell we can j
pjfanning commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425758240
* `new SXSSFCell(this, type, column)` sets _columnIndex
* getColumIndex() uses _columnIndex and only searches the row if
_columnIndex is not set
--
This is an automated message fro
gtoison commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425835852
Ah that's great! Indeed I noticed the performance problem using 5.2.3 but
did not see that some improvements were made
Thanks to the changes I suppose that this PR is not needed.
Unless yo
pjfanning commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425874890
I don't to want to merge this - can you close it? I think the existing
changes are sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gtoison commented on PR #428:
URL: https://github.com/apache/poi/pull/428#issuecomment-1425902041
I've tested the snapshot build and it seems better indeed, looking forward
to 5.2.4!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
gtoison closed pull request #428: Performance improvements when writing many
cells with SXSSF
URL: https://github.com/apache/poi/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #429:
URL: https://github.com/apache/poi/pull/429
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.12.23 to 1.13.0.
Changelog
Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";>net.b
dependabot[bot] opened a new pull request, #430:
URL: https://github.com/apache/poi/pull/430
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.12.23 to 1.13.0.
Changelog
Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";
dependabot[bot] opened a new pull request, #431:
URL: https://github.com/apache/poi/pull/431
Bumps org.cyclonedx.bom from 1.7.3 to 1.7.4.
[
from 1.12.23 to 1.14.0.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b
dependabot[bot] opened a new pull request, #434:
URL: https://github.com/apache/poi/pull/434
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.12.23 to 1.14.0.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-bu
asfgit closed pull request #434: Bump net.bytebuddy:byte-buddy from 1.12.23 to
1.14.0
URL: https://github.com/apache/poi/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dependabot[bot] commented on PR #433:
URL: https://github.com/apache/poi/pull/433#issuecomment-1438288758
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
asfgit closed pull request #433: Bump net.bytebuddy:byte-buddy-agent from
1.12.23 to 1.14.0
URL: https://github.com/apache/poi/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] commented on PR #434:
URL: https://github.com/apache/poi/pull/434#issuecomment-1438288722
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
pjfanning commented on PR #435:
URL: https://github.com/apache/poi/pull/435#issuecomment-1451875992
* issue is https://bz.apache.org/bugzilla/show_bug.cgi?id=66503
* would it be possible to add a test?
--
This is an automated message from the Apache Git Service.
To respond to the messag
kiddkaffeine closed pull request #435: Add entries for Excel 4 (legacy pre-VBA)
macros
URL: https://github.com/apache/poi/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
kiddkaffeine commented on PR #435:
URL: https://github.com/apache/poi/pull/435#issuecomment-1452928882
Yes, I need a little bit of time. I will close this and resubmit separately
for composite and OOXML, with tests. The first one will come shortly.
--
This is an automated message from t
kiddkaffeine opened a new pull request, #436:
URL: https://github.com/apache/poi/pull/436
This includes a composite (non-OOXML) Excel document with a Excel 4 macro.
In the pre-OOXML world, these macros are binary and I'm not sure how to handle
them, so this just marks their presence. (In
dependabot[bot] opened a new pull request, #437:
URL: https://github.com/apache/poi/pull/437
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.14.0 to 1.14.1.
Changelog
Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";>net.by
dependabot[bot] opened a new pull request, #438:
URL: https://github.com/apache/poi/pull/438
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.14.0 to 1.14.1.
Changelog
Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md";>
asfgit closed pull request #437: Bump net.bytebuddy:byte-buddy from 1.14.0 to
1.14.1
URL: https://github.com/apache/poi/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit closed pull request #438: Bump net.bytebuddy:byte-buddy-agent from
1.14.0 to 1.14.1
URL: https://github.com/apache/poi/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dependabot[bot] commented on PR #437:
URL: https://github.com/apache/poi/pull/437#issuecomment-1458935996
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #438:
URL: https://github.com/apache/poi/pull/438#issuecomment-1458936015
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] opened a new pull request, #439:
URL: https://github.com/apache/poi/pull/439
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from
4.11.0 to 5.2.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core'
asfgit closed pull request #439: Bump org.mockito:mockito-core from 4.11.0 to
5.2.0
URL: https://github.com/apache/poi/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #439:
URL: https://github.com/apache/poi/pull/439#issuecomment-1464844388
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
leeseojune53 opened a new pull request, #440:
URL: https://github.com/apache/poi/pull/440
Changed Duplicated codes in `XSSFCellStyle`.
`getBorder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request, #441:
URL: https://github.com/apache/poi/pull/441
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy)
from 1.14.1 to 1.14.2.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:by
dependabot[bot] opened a new pull request, #442:
URL: https://github.com/apache/poi/pull/442
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from
1.14.1 to 1.14.2.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:byte-bud
pjfanning commented on PR #440:
URL: https://github.com/apache/poi/pull/440#issuecomment-1466606046
I'm not sure if this is worth the effort? Limited number of contributors to
validate this. Their time is better spent on bugs and feature enhancements.
--
This is an automated message from
asfgit closed pull request #442: Bump net.bytebuddy:byte-buddy from 1.14.1 to
1.14.2
URL: https://github.com/apache/poi/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit closed pull request #441: Bump net.bytebuddy:byte-buddy-agent from
1.14.1 to 1.14.2
URL: https://github.com/apache/poi/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dependabot[bot] commented on PR #442:
URL: https://github.com/apache/poi/pull/442#issuecomment-1466959814
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
dependabot[bot] commented on PR #441:
URL: https://github.com/apache/poi/pull/441#issuecomment-1466959837
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let me kn
leeseojune53 commented on PR #440:
URL: https://github.com/apache/poi/pull/440#issuecomment-1467181870
Ok I will close this PR
Sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
leeseojune53 closed pull request #440: Refactor XSSFCellStyle getBorder
URL: https://github.com/apache/poi/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
rascmatt opened a new pull request, #443:
URL: https://github.com/apache/poi/pull/443
Simplify loop and avoid code point to string conversions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rascmatt commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474314063
The following is a JMH benchmark I ran with 3 different versions.
Unfortunately I was unable to get JMH running with Gradle, so I ran this in an
external Maven Project.
The latest rele
pjfanning commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140647602
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
rascmatt commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140650040
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
pjfanning commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140652528
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
pjfanning commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140653374
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
pjfanning commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474345524
> Following you will find the results of a JMH benchmark I ran with 3
different versions. Unfortunately I was unable to get JMH running with Gradle,
so I ran this in an external Maven Project
pjfanning commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140652528
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
rascmatt commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140725183
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
rascmatt commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140725467
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
rascmatt commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474419787
https://github.com/rascmatt/poi-benchmark
The (updated) benchmark with code and results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
pjfanning commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474422688
thanks - looks good. Let me look over this but it looks like this should be
safe to merge over the coming days.
--
This is an automated message from the Apache Git Service.
To respond to th
pjfanning commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474516597
I added
https://github.com/apache/poi/commit/0275daa5deae2e0069badd1f46268abb43fbc3dc -
not exactly what is in your PR. Could you try this out in your benchmark?
--
This is an automated me
pjfanning commented on PR #436:
URL: https://github.com/apache/poi/pull/436#issuecomment-1474554346
I added this but then reverted it due to
https://github.com/apache/poi/actions/runs/4452719179/jobs/7820620683
Causes issues like this:
```
Caused by: java.lang.IllegalStateEx
rascmatt commented on PR #443:
URL: https://github.com/apache/poi/pull/443#issuecomment-1474801750
Thank you, I added this version to the benchmark and it looks good. In
addition I added a benchmark for a more integrated setting
(https://github.com/rascmatt/poi-benchmark/commit/d7fa4a8b2842
rascmatt closed pull request #443: [Bug-66532] Improve performance of
SheetDataWriter
URL: https://github.com/apache/poi/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dependabot[bot] opened a new pull request, #444:
URL: https://github.com/apache/poi/pull/444
Bumps com.github.spotbugs from 5.0.13 to 5.0.14.
[