Re: [PR] Improve readability and remove redundant cast at HSSFChart.java [poi]

2024-02-19 Thread via GitHub
asfgit closed pull request #596: Improve readability and remove redundant cast at HSSFChart.java URL: https://github.com/apache/poi/pull/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Improve readability and remove redundant cast at HSSFChart.java [poi]

2024-02-19 Thread via GitHub
rh-id commented on PR #596: URL: https://github.com/apache/poi/pull/596#issuecomment-1952459855 I'm using Java 21 and yes gradle build success. I thought this is not deliberate because it has import Record class and no usage of java.lang.Record. Perhaps we should just close this PR?

Re: [PR] Improve readability and remove redundant cast at HSSFChart.java [poi]

2024-02-19 Thread via GitHub
pjfanning commented on code in PR #596: URL: https://github.com/apache/poi/pull/596#discussion_r1494489151 ## poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java: ## @@ -113,7 +113,7 @@ private HSSFChart(HSSFSheet sheet, ChartRecord chartRecord) { public void cr