pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2313307233
Thanks @str4danya - I merged most of what was in your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
asfgit closed pull request #682: CellUtil constants to enum - CellPropertyType
URL: https://github.com/apache/poi/pull/682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733325952
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733325366
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733278057
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -461,70 +611,93 @@ private static boolean styleMapsMatch(final Map newProps,
* same style.
*
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733276730
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -381,31 +498,64 @@ public static void setFont(Cell cell, Font font) {
*
*
* @param cell
str4danya commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733276465
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
str4danya commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733275169
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733275138
##
poi/src/main/java/org/apache/poi/ss/usermodel/CellPropertyType.java:
##
@@ -0,0 +1,63 @@
+/*
+ Lic
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733274823
##
poi/src/main/java/org/apache/poi/ss/usermodel/CellPropertyCategory.java:
##
@@ -0,0 +1,30 @@
+/*
+
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733273831
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java:
##
@@ -2778,6 +2778,51 @@ void test59132() throws IOException {
@Disabled("bug 59442")
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733273063
##
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java:
##
@@ -164,6 +165,64 @@ void testBug57294() throws IOException {
wbBack.close();
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733161230
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -850,22 +1019,22 @@ public static Cell translateUnicodeValues(Cell cell) {
}
static {
-
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733159282
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -302,40 +398,38 @@ public static void copyCell(Cell srcCell, Cell destCell,
CellCopyPolicy policy,
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733157631
##
poi/src/main/java/org/apache/poi/ss/util/CellUtil.java:
##
@@ -302,40 +398,38 @@ public static void copyCell(Cell srcCell, Cell destCell,
CellCopyPolicy policy,
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733154710
##
poi-ooxml/src/test/java/org/apache/poi/ss/tests/util/TestXSSFCellUtil.java:
##
@@ -90,6 +127,42 @@ public void testSetForegroundColorCellStylePropertyToNull()
throws IO
pjfanning commented on code in PR #682:
URL: https://github.com/apache/poi/pull/682#discussion_r1733152647
##
poi-ooxml/src/test/java/org/apache/poi/ss/tests/util/TestXSSFCellUtil.java:
##
@@ -19,22 +19,15 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312953033
Ok - thanks. I'll look at this again but for now, if type erasure stops you
adding overloading methods - then create methods with slightly different names
for the cases where you want to use
str4danya commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312921004
Hello, I hadn't thought of that.
I have reverted the support for CellUtils constants. The tests have also
been edited, duplicating the tests for CellUtils and CellPropertyType.
Look at
pjfanning commented on PR #682:
URL: https://github.com/apache/poi/pull/682#issuecomment-2312065256
Thanks but we could not accept this PR in its current form. In Apache POI,
we never remove code without first deprecating it. You have removed lots of
CellUtil code. This would need to be ret
20 matches
Mail list logo
