Re: [Bug 59634] XSSFWorkbook#close() violates contract from Workbook#close()

2016-05-27 Thread Dominik Stadler
+1, close() is the final thing you do on objects based on the Closeable interface, I am surprised the javadoc for Workbook states it differently. If we want to have a way to "release" resources while still having the object available, we should use a differently named method for this as close() is

RE: [Bug 59634] XSSFWorkbook#close() violates contract from Workbook#close()

2016-05-27 Thread Murphy, Mark
This seems a little counterintuitive to me. I would expect that once a Workbook is closed, it cannot be used. Closing should be the last thing you do with a Workbook. I would be more inclined to fix the documentation than to allow differing behavior between Workbooks read from the file system, a