Re: [PATCHES] poi as calculation engine

2017-05-30 Thread Javen O'Neal
> How about we adopt a full lazy-evaluation approach for Formula objects? I opened bug 61136 [1] and took a stab at full lazy evaluation [2]. Travis, would you be willing to test the memory consumption and execution speed with these changes in HSSF and XSSF relative to trunk and your patch (8ab388

Re: [PATCHES] poi as calculation engine

2017-05-30 Thread Javen O'Neal
How about we adopt a full lazy-evaluation approach for Formula objects? Either _byteEncoding and _encodedTokenLen should be provided or _ptgTokens should be provided. Only when the other is needed should Ptg.readTokens or Ptg.serializeTokens be called. As I understand it, reading and serializing t

[PATCHES] poi as calculation engine

2017-05-30 Thread moparisthebest
formulas, and it takes ~21 minutes to evaluate. If I apply these 2 patches to disable double formula validation: https://bz.apache.org/bugzilla/show_bug.cgi?id=61033 The same thing executes in 11 minutes. In the interest of completeness, I tried SXSSF with a -1 row limit but killed it at the ~50

[Bug 59826] Apply ant-generated patch.tar.gz patches

2016-07-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59826 Javen O'Neal changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 59826] New: Apply ant-generated patch.tar.gz patches

2016-07-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59826 Bug ID: 59826 Summary: Apply ant-generated patch.tar.gz patches Product: POI Version: 3.15-dev Hardware: Other OS: Linux Status: NEW Severity

Re: How do those of you who use Git produce patches

2016-06-24 Thread Nick Burch
repo, push the changes to your fork, then open a pull request Otherwise, something like this should give you all the patches pending: git diff --stat --cached origin/master And this for the diffs: git diff --cached origin/master

How do those of you who use Git produce patches

2016-06-24 Thread Murphy, Mark
I have a small change to xwpf that I am working on in a local Git repository, but I need to know how to create a patch. The documentation on the How to contribute page isn't particularly helpful.

Re: Format of submitted patches

2016-01-17 Thread David North
the manual way > Approach 3 - the git way > """ > > What is the current preference among the POI committers and community? I usually check things in and apologise for them afterwards ;) Seriously, though, I tend to use Eclipse to generate patches, though it does share

Re: Format of submitted patches

2016-01-17 Thread David North
the manual way > Approach 3 - the git way > """ > > What is the current preference among the POI committers and community? I usually check things in and apologise for them afterwards ;) Seriously, though, I tend to use Eclipse to generate patches, though it does share

Re: Format of submitted patches

2016-01-17 Thread Nick Burch
. In the event of a git pull request, we get an email sent to the list with a summary of the request and a link. Going to the link shows you all about it and allows a graphical review, going to .patch (append ".patch" to the URL) gets you the raw git patches to r

Re: Format of submitted patches

2016-01-16 Thread Andreas Beeker
> What is the current preference among the POI committers and community? Receiving a patch: I haven't checked how to receive the git pull requests as I'm not having a local POI git repository - so this is currently my least preferred format. Apart of that, I don't care if approach 1 or 2 is used

Format of submitted patches

2016-01-15 Thread Javen O'Neal
>From http://poi.apache.org/guidelines.html#SubmittingPatches """ You may create your patch file using either of the following approaches (the committers recommend the first): Approach 1 - use Ant Approach 2 - the manual way Approach 3 - the git way """ What is the current preference among the POI

[Bug 58326] Forbidden APIs patches

2015-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 Andreas Beeker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Bug 58326] Forbidden APIs patches

2015-09-08 Thread Dominik Stadler
Hi, Thanks Andi for this huge piece of work, I think we are nearly there now, seems the Calendar-to-Date stuff in DateUtil still messes this up at some point :( I narrowed it down a bit, the following works with "CET" for me (my local timezone), but fails with "UTC", so there is something flaky h

[Bug 58326] Forbidden APIs patches

2015-09-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 --- Comment #4 from Andreas Beeker --- The charset fixes are applied with r1701713 So it looks like, there's only - a probably not so easy to catch - error with CellDateFormatter to fix ... -- You are receiving this mail because: You are th

[Bug 58326] Forbidden APIs patches

2015-09-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 --- Comment #3 from Andreas Beeker --- first set of changes for locale and timezone settings with r1701688 also includes fixes for - name shadowing - unused deprecated method "getClipRect" in classes extending Graphics2d - HexDump - replaced i

[Bug 58326] Forbidden APIs patches

2015-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 --- Comment #2 from Dominik Stadler --- I like the separate LocaleUtil class which encapsulates the selection of all these items, I think it would be good to apply these changes now without enabling more forbidden-api-checks in order to get t

[Bug 58326] Forbidden APIs patches

2015-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 Dominik Stadler changed: What|Removed |Added Severity|normal |enhancement -- You are receiving th

[Bug 58326] New: Forbidden APIs patches

2015-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 Bug ID: 58326 Summary: Forbidden APIs patches Product: POI Version: 3.13-dev Hardware: All OS: All Status: NEW Keywords: PatchAvailable

[Bug 58326] Forbidden APIs patches

2015-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58326 --- Comment #1 from Andreas Beeker --- Created attachment 33060 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33060&action=edit [PATCH] patch for forbidden apis - v1 -- You are receiving this mail because: You are the assignee for th

Patches

2015-05-14 Thread David North
Hi, We have a few patches which we're hoping to tidy up and get accepted over the next couple of months. https://bz.apache.org/bugzilla/show_bug.cgi?id=56705 - any further thoughts on this, in particular, response to our last comment? https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

Re: Another beta vs patches & final?

2013-11-15 Thread Andreas Beeker
Hi Nick, is there actually any difference between releasing the final vs. another beta? e.g. an extended testsuite? crosschecks with tika? Not sure, if this makes sense, but I think fixing the BiffViewer or its test cases would be a nice feature for a final milestone. Andi --

Another beta vs patches & final?

2013-11-13 Thread Nick Burch
Hi All It's now almost 2 months since our last beta release. What do people think about the next release? Do we roll another beta, to get feedback? Or do we all make a big push to get the outstanding patches applied (of which there are still a lot...), then go for 3.10 final in a few

Re: Feedback on my patches

2013-11-04 Thread Yegor Kozlov
First of all, thank you for your patches and interest in the POI project. Your contributions are appreciated ! Please always change status from NEEDINFO to NEW when you upload patches to existing / old bugs. I have a bookmark that returns all open POI bugs and it does not include NEEDINFO: https

Re: Feedback on my patches

2013-11-03 Thread Nick Burch
ng with your patch applied! Also, try to avoid fixing whitespace at teh same time as fixing/adding logic. We do have somewhat of a whitespace mess in places, as we only recently finally agreed on a standard... Generally best to do 2 patches if needed, one with whitesapce only, and one with logic

Feedback on my patches

2013-11-03 Thread Andreas Beeker
ty and see what could be done - apart of that, is there bug-wishlist? If your time permits, please have a look at my open patches - I'm looking forward to your feedback ;) (ordered by (my guessed) severity ...) - [PATCH] Multiple Saves Causes Slide Corruption https://issues.apache.org/bugzilla/s

Re: GSoC applicants, please prepare patches or working code

2012-04-12 Thread Evgeniy Berlog
Hi Yegor, I have updated patch with drawing utility. https://issues.apache.org/bugzilla/show_bug.cgi?id=53058 Thanks With best regards, Evgeniy Berlog - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional comm

Re: GSoC applicants, please prepare patches or working code

2012-04-12 Thread adeel khan
, Yegor Kozlov wrote: > Hello Evgeniy, Adel, Lakshani , GSoC applicants > > To make the GSoC selection process more accurate I encourage you to > make a next step after submission. Please provide working patches or > code that will advance your proposal. > > We have to estimate

Re: GSoC applicants, please prepare patches or working code

2012-04-12 Thread Yegor Kozlov
ts >> >> To make the GSoC selection process more accurate I encourage you to >> make a next step after submission. Please provide working patches or >> code that will advance your proposal. >> >> We have to estimate coding skills of each participant, not only

Re: GSoC applicants, please prepare patches or working code

2012-04-11 Thread Evgeniy Berlog
Berlog 10.04.2012 14:20, Yegor Kozlov wrote: Hello Evgeniy, Adel, Lakshani , GSoC applicants To make the GSoC selection process more accurate I encourage you to make a next step after submission. Please provide working patches or code that will advance your proposal. We have to estimate coding

GSoC applicants, please prepare patches or working code

2012-04-10 Thread Yegor Kozlov
Hello Evgeniy, Adel, Lakshani , GSoC applicants To make the GSoC selection process more accurate I encourage you to make a next step after submission. Please provide working patches or code that will advance your proposal. We have to estimate coding skills of each participant, not only proposal

DO NOT REPLY [Bug 50607] Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 --- Comment #4 from Aniket 2011-01-19 08:51:36 EST --- (In reply to comment #3) > *** Bug 50384 has been marked as a duplicate of this bug. *** Thanks Yegor. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=ema

DO NOT REPLY [Bug 50607] Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 --- Comment #3 from Yegor Kozlov 2011-01-19 07:32:08 EST --- *** Bug 50384 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mai

DO NOT REPLY [Bug 50607] Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 Yegor Kozlov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50607] Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 Aniket changed: What|Removed |Added OS/Version||All --- Comment #1 from Aniket 2011-01-1

DO NOT REPLY [Bug 50607] Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 Aniket changed: What|Removed |Added OS/Version||Windows 7 -- Configure bugmail: https://

DO NOT REPLY [Bug 50607] New: Submitting patches for two new function implementations(CLEAN and ADDRESS).

2011-01-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50607 Summary: Submitting patches for two new function implementations(CLEAN and ADDRESS). Product: POI Version: 3.8-dev Platform: PC Status: NEW Severity

DO NOT REPLY [Bug 21325] [PATCH] Praveen's patches

2008-12-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=21325 Yegor Kozlov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|