Re: [PR] Handle missing font system error on Java 21 [poi]

2024-01-28 Thread via GitHub
centic9 commented on PR #578: URL: https://github.com/apache/poi/pull/578#issuecomment-1914064522 Unfortunately the check on `ExceptionUtil.isFatal()` is now causing failures in cases where we would like graceful handling, e.g. *UnsatisfiedLinkError` here usually indicates that font-librari

Re: [PR] Handle missing font system error on Java 21 [poi]

2024-01-25 Thread via GitHub
asfgit closed pull request #578: Handle missing font system error on Java 21 URL: https://github.com/apache/poi/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Handle missing font system error on Java 21 [poi]

2024-01-24 Thread via GitHub
centic9 commented on PR #578: URL: https://github.com/apache/poi/pull/578#issuecomment-1908755047 I think here it will be fine as we only handle it when the system property is set to true and only some JDK code for computing the text-length is called at that point, so the chance for other u

Re: [PR] Handle missing font system error on Java 21 [poi]

2024-01-24 Thread via GitHub
pjfanning commented on PR #578: URL: https://github.com/apache/poi/pull/578#issuecomment-1908198665 @centic9 - is ok to treat all non-fatal exceptions in this try block as meaning we are likely to be missing fonts? So far, trying to specify specific exception types is just running into issu

[PR] Handle missing font system error on Java 21 [poi]

2024-01-22 Thread via GitHub
liff opened a new pull request, #578: URL: https://github.com/apache/poi/pull/578 In Java 21 the RuntimeException from `sun.awt.FontConfiguration` is not wrapped in an `InternalError` anymore and appears directly as a `RuntimeException` when constructing a `TextLayout`. So, when `ign