Re: [PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-07-08 Thread via GitHub
pjfanning commented on PR #770: URL: https://github.com/apache/poi/pull/770#issuecomment-3049452746 Thanks @GermanAlejo - merged. I will have a look out for issues and if there are, I may need to revert this. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-07-08 Thread via GitHub
pjfanning merged PR #770: URL: https://github.com/apache/poi/pull/770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org Fo

Re: [PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-06-07 Thread via GitHub
GermanAlejo commented on PR #770: URL: https://github.com/apache/poi/pull/770#issuecomment-2952861944 I have added a couple of tests, however I am not knowledgeable in testing so please let me know If this should be done in any way different or if it is insufficient and I will update the PR

Re: [PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-06-07 Thread via GitHub
GermanAlejo commented on PR #770: URL: https://github.com/apache/poi/pull/770#issuecomment-2952860144 I discovered this bug while using the library myself. The method setBulletStyle from XSLFTextParagraph class calls setBulletAutoNumber method, which expects a int as a parameter (startAt) t

Re: [PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-05-27 Thread via GitHub
pjfanning commented on PR #770: URL: https://github.com/apache/poi/pull/770#issuecomment-2912087922 This won't be accepted unless there is a detailed description of why this is needed and test cases are needed. -- This is an automated message from the Apache Git Service. To respond to the

[PR] Bugfix setBulletStyle in XSLFTextParagraph [poi]

2025-03-11 Thread via GitHub
GermanAlejo opened a new pull request, #770: URL: https://github.com/apache/poi/pull/770 Having a 0 here throws IllegalArgumentException, the method setBulletAutoNumber requires 1 as minimun as argument. -- This is an automated message from the Apache Git Service. To respond to the messag