Re: [DISCUSS] Github issues vs Jira issues

2020-11-09 Thread Mukul Kumar Singh
Thanks for starting this thread Marton. I have worked with Github issues for other projects and find the tracking rudimentary. Basically absence of good queries, saving older queries, lack of dashboards are my biggest objections to this. I feel we can use some of the plugins with Github and

Re: Enabling Ratis on OM by default

2020-11-24 Thread Mukul Kumar Singh
+1 Thanks, Mukul On 24/11/20 12:30 pm, Lokesh Jain wrote: +1 Regards Lokesh On 24-Nov-2020, at 11:05 AM, Shashikant Banerjee wrote: +1 Thanks Shashi On Tue, Nov 24, 2020 at 8:39 AM Bharat Viswanadham wrote: +1 Thanks, Bharat On Mon, Nov 23, 2020 at 4:21 PM Vivek Ratnavel wrote:

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-11 Thread Mukul Kumar Singh
+1, for the merge of the feature branch. Based on the status on the wiki and the current state of SCM HA branch, we are in good state to merge. Thanks, Mukul On 11/03/21 10:22 am, Shashikant Banerjee wrote: Thank you all for the suggestions and feedback. The SCM HA wiki is set up here: http

Re: [VOTE] - Merge SCM-HA Branch - HDDS-2823

2021-03-19 Thread Mukul Kumar Singh
+1. Thanks everyone for the collaborative effort. Thanks, Mukul On 19/03/21 12:34 pm, Aravindan Vijayan wrote: +1 for the merge. Thanks for working on this! On Thu, Mar 18, 2021 at 11:20 PM Prashant Pogde wrote: I have created 1.1.0-RC0 branch and we can promote this branch to 1.1.0 later

Secrets committed as part of Ozone Commits

2021-03-24 Thread Mukul Kumar Singh
Hi, Recently, through one of the jiras(HDDS-4864), aws_secret_access_key was committed into Ozone's source code. Secrets, gpg passphrases, passwords, ssh private files should not be committed into Ozone source code as they leak credentials into the source code. This issue will be solved via

Re: Secrets committed as part of Ozone Commits

2021-03-24 Thread Mukul Kumar Singh
, 2021 at 10:33 AM Mukul Kumar Singh wrote: Hi, Recently, through one of the jiras(HDDS-4864), aws_secret_access_key was committed into Ozone's source code. Secrets, gpg passphrases, passwords, ssh private files should not be committed into Ozone source code as they leak credentials int

Re: Secrets committed as part of Ozone Commits

2021-03-24 Thread Mukul Kumar Singh
Thanks everyone. I have pushed the changes to the master branch. Please resume any merges to Apache master. Thanks, Mukul On 25/03/21 10:30 am, Mukul Kumar Singh wrote: Thanks Arpit and Sammi for the responses. Note: Please block any merges to Apache master while this commit is being

Re: Secrets committed as part of Ozone Commits

2021-03-25 Thread Mukul Kumar Singh
Thanks for the replies everyone. Sorry that I force-pushed in haste. I did not see all the problems with the force-push earlier, I have now pushed the original master before this force push was done. Sorry for all the confusion because of this. Thanks, Mukul On 25/03/21 2:16 pm, Attila D

Re: [DISCUSS] - Merge FileSystem Optimizations branch HDDS-2939 to master

2021-04-05 Thread Mukul Kumar Singh
+1, This feature will be a great addition to Ozone. - Mukul On 05/04/21 8:03 pm, Lin, Yiqun wrote: +1 for merging to master after resolved current few block subtasks. Currently, I see listKey implementation and key deletion lifecycle in FSO hasn't been completed yet. On 2021/4/5, 5:49 PM, "

Re: [PROPOSAL] Go client for ozone

2021-04-09 Thread Mukul Kumar Singh
I see that the code in https://github.com/apache/ozone-go repository was committed without any code reviews and design. The code was merged without any Apache jira, design or reviews. The Apache way of code contribution was not followed in this case. We should revert the repository to no com

Re: [PROPOSAL] Go client for ozone

2021-04-09 Thread Mukul Kumar Singh
etter. Marton [1]: As #2 PR turned on the branch protection I couldn't remove the github workflow yaml and 3 empty build.sh files. Hope they don't cause any confusion. On 4/9/21 5:25 PM, Mukul Kumar Singh wrote: I see that the code in https://github.com/apache/ozone-go repository

Re: [VOTE] - Merge FSO branch HDDS-2939 to master

2021-05-31 Thread Mukul Kumar Singh
+1 for the merge. Thanks for starting the discussion Rakesh. Thanks, Mukul On 31/05/21 1:24 pm, Rakesh Radhakrishnan wrote: Hi All, Based on the positive feedback from the merge DISCUSS thread

Re: [VOTE] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-06-21 Thread Mukul Kumar Singh
+1 Thanks, Mukul On 21/06/21 8:10 pm, Aravindan Vijayan wrote: Hello All, Circling back to the upgrade branch VOTE thread after fixing issues mentioned from last vote, and incorporating changes from HDDS-2939. Please refer to the original VOTE mail for the details of the design and implement

Re: [VOTE] Merge Ozone Erasure Coding branch (HDDS-3816-ec) into master

2022-04-06 Thread Mukul Kumar Singh
+1 for the merge. Thanks Lokesh On 07/04/22 11:29 am, Lokesh Jain wrote: +1 for merge Thanks Lokesh On 07-Apr-2022, at 11:06 AM, Tsz Wo Sze wrote: +1 We should merge it so that more people can try it. We can work on the remaining tasks in the master branch. Thanks a lot! Tsz-Wo On Thu

Re: How about launching a monthly sharing meeting

2022-04-07 Thread Mukul Kumar Singh
+1, I think we will need one for each time zone. On 07/04/22 1:23 pm, Jyotinder Singh wrote: I would definitely be on board with this idea, sounds like a good way to grow the community. Regards Jyotinder Singh On Thu, 7 Apr 2022 at 1:10 PM, Hui Fei wrote: + dev@ozone.apache.org Hui Fei 于2

Re: [VOTE] Merge Ozone Erasure Coding branch (HDDS-3816-ec) into master

2022-04-13 Thread Mukul Kumar Singh
+1 Thanks for all the work on this feature. Thanks, Mukul On 13/04/22 9:01 am, Sammi Chen wrote: +1 for the merge. Thanks a lot to Uma and all contributors working on EC. Great work! It's so great that we have EC in Ozone now. Bests, Sammi On Wed, 6 Apr 2022 at 13:59, Uma gangumalla wrot

Re: [DISCUSS] HDDS-6634 datanode doesn't check cluster identity in runtime

2022-04-25 Thread Mukul Kumar Singh
Thanks for reporting the issue. The Datanodes can only contact the SCM with the same cluster ID. while moving the SCM, the metadata directories were also copied as well? Thanks, Mukul On 25/04/22 3:19 pm, Maxim Myskov wrote: Hi all, I would like to discuss https://issues.apache.org/jira/bro

Re: [DISCUSS] Proposal to merge Ozone datanode side RocksDB merge feature branch (HDDS-3630) into master

2022-05-24 Thread Mukul Kumar Singh
+1 for this feature. On 24/05/22 2:46 pm, jackson yao wrote: +1 for the merge. Thanks Sammi and Mark for working on this. guimark 于2022年5月24日周二 16:58写道: +1 for merge. Thanks Sammi for driving this! And for the second question from Arpit, we are running this feature for months and it look