Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Wei-Chiu Chuang
hi Ethan, The OM layout version change was for rejecting hsync requests to OM until the upgrade completes. The "HSYC" layout version was shipped in Ozone 1.4.0. IIRC I did touch upon this in the release vote thread, that because there's a feature flag ozone.fs.hsync.enabled which disables the feat

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Ethan Rose
Hi Wei-Chiu, I'm still unclear on the compatibility requirements of this feature. Feature flags are not a substitute for layout versions. Layout versions are monotonic: they make sure once something is enabled it cannot be disabled via a downgrade (the downgraded cluster will fail to start). Featu

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Wei-Chiu Chuang
I had an offline discussion with Ethan regarding a couple of potential issues: 1. *New Client with ozone.fs.hsync.enabled*: If a new client with ozone.fs.hsync.enabled sends an hsync request to an old OM, the request is sent as a KeyCommit request with additional fields for hsync. The

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Ethan Rose
Thanks Wei-Chiu, I'm ok with handling these in follow up tasks. Please share the Jira links when you have them. This was my main concern, so the merge is +1 from me now. Ethan On Tue, Jul 30, 2024 at 5:34 PM Wei-Chiu Chuang wrote: > I had an offline discussion with Ethan regarding a couple of p

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Siyao Meng
+1 on the merge. Disclaimer: I have contributed to branch HDDS-7593. -Siyao On Jul 30, 2024 at 3:39:25 PM, Ethan Rose wrote: > Thanks Wei-Chiu, I'm ok with handling these in follow up tasks. Please > share the Jira links when you have them. This was my main concern, so the > merge is +1 from m

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Ashish kumar
Thanks WeiChiu, Ethan, Siyao for the vote. Anyone else like to vote? On Wed, Jul 31, 2024 at 5:37 AM Siyao Meng wrote: > +1 on the merge. > > Disclaimer: I have contributed to branch HDDS-7593. > > -Siyao > > On Jul 30, 2024 at 3:39:25 PM, Ethan Rose wrote: > > > Thanks Wei-Chiu, I'm ok with ha

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Tsz Wo Sze
+1 for merging the hsync branch. Tsz-Wo On Tue, Jul 30, 2024 at 8:14 PM Ashish kumar wrote: > Thanks WeiChiu, Ethan, Siyao for the vote. > Anyone else like to vote? > > On Wed, Jul 31, 2024 at 5:37 AM Siyao Meng > wrote: > > > +1 on the merge. > > > > Disclaimer: I have contributed to branch H

Re: [VOTE] Merge HDDS-7593 (HSync and lease recovery) into master

2024-07-30 Thread Attila Doroszlai
> > Both issues can be addressed with new layout versions. I will open JIRA > > tickets to include these fixes in the next release, version 1.5.0. > > Thanks Wei-Chiu, I'm ok with handling these in follow up tasks. Please > share the Jira links when you have them. This was my main concern, so the >