Re: Ozone Jira and PR guidelines

2023-09-28 Thread Uma Maheswara Rao Gangumalla
Thanks Ayush for your insightful thoughts. I agree most of us fall into that "No Description JIRA" category :-). That trend is more in branch developments especially. >Though I am not very much in favour of closing tickets right away based on discussions in Community sync. The contributor might be

Re: Ozone Jira and PR guidelines

2023-09-28 Thread Hemant Kumar
Thanks everyone for the valuable inputs. As I can see, all of us agree that we need some sort of guidelines. As Sid suggested, I created PR: https://github.com/apache/ozone/pull/5372 updating contribution and pull request template. Please take a look and provide feedback. @ayushtkn, as you said,

Re: Ozone Jira and PR guidelines

2023-09-21 Thread Wei-Chiu Chuang
Might be irrelevant but I just want to point out that other open source projects have more stringent requirements when it comes to filing a jira. Infact, Kafka has KIP (Kafka Improvement Proposal) Yunikorn has YIP (Yunikorn Improvement Proposal) and the proposers need to have sufficient support (w

Re: Ozone Jira and PR guidelines

2023-09-21 Thread Ayush Saxena
Makes sense to have policies around Jiras & PR, Having proper descriptions & linking the related tickets and stuff like that. Though I am not very much in favour of closing tickets right away based on discussions in Community sync. The contributor might be a newbie, he might be genuinely not aware

Re: Ozone Jira and PR guidelines

2023-09-21 Thread Uma Maheswara Rao Gangumalla
Thank you Hemant for starting the discussion on JIRA and PR descriptions. Also reviewers should step up to check the JIRA/PR descriptions as well without biased understanding of the JIRA. We are doing JIRA scrub in community syncs and if we notice JIRAs without descriptions we can close them right

Re: Ozone Jira and PR guidelines

2023-09-21 Thread Siddharth Wagle
Thanks, Hemant for kicking off this thread! Jira and pull-requests hygiene are extremely important for posterity and overall significantly improve collaboration with developers especially cross timezones. This should be added to the contributing guide: https://github.com/apache/ozone/blob/master/C

Ozone Jira and PR guidelines

2023-09-21 Thread Hemant Kumar
Hi Ozone Community, As we discussed in the last ozone community meeting about Ozone jiras and PRs not having enough information/details. Which makes it harder to understand when people outside the project look at them. Hence to make it better, I'm proposing the following guideline. Please take a lo