Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

Thanks for the votes everyone. Based on the results (9 +1s, no -1s, no 0s) the reconciliation feature branch has been merged into master. To address minor items that were suggested to fix after the merge: - HDDS-13304 has been filed to check

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

Hi Ethan, Thanks for addressing my comments! > ... Datanode code consistently identified container IDs as long values. We can shift to using ContainerID in the datanode as well, but that would be a 1. change outside of reconciliation. We have an umbrella JIRA HDDS-12769

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

Thanks for reviewing the code Nicholas. For the “healthy” term, I agree it is not specific enough. In this PR we are updating it to checksumMatches in the merkle tree proto. We can update the term in the ScanResult in a follow-up since it is not touching the proto. Cases where the block is missing

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

One more thing: how about we call all the completed work Phase 1 and the work after merge Phase 2? Then, we should update HDDS-10239 to describe what was done in Phase 1 and move the unresolved JIRAs to a new umbrella Phase 2 JIRA. Tsz-Wo On Tue, Jun 17, 2025 at 12:17 PM Tsz-Wo Nicholas Sze w

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 Thanks for the great work! The feature is going to be very useful. Some questions/comments/suggestions below. "Healthy" related: - What does ChunkMerkleTree.isHealthy == false means? Checksum mismatched? Missing? - Rename ScanResult.isHealthy() to hasErrors() since all the (non-test) calls

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 for the merge. -Sadanand On Tue, Jun 17, 2025 at 1:32 AM Ayush Saxena wrote: > +1 > > > -Ayush > > On Tue, 17 Jun 2025 at 00:21, soumitra sulav > wrote: > > > > +1 for the merge of this feature. > > > > - Soumitra > > > > On Mon, Jun 16, 2025 at 11:43 PM Siyao Meng wrote: > > > > > +1 > >

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 -Ayush On Tue, 17 Jun 2025 at 00:21, soumitra sulav wrote: > > +1 for the merge of this feature. > > - Soumitra > > On Mon, Jun 16, 2025 at 11:43 PM Siyao Meng wrote: > > > +1 > > Thanks for all the work that has been put into this. > > > > -Siyao > > > > On Mon, Jun 16, 2025 at 10:39 AM Si

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 for the merge of this feature. - Soumitra On Mon, Jun 16, 2025 at 11:43 PM Siyao Meng wrote: > +1 > Thanks for all the work that has been put into this. > > -Siyao > > On Mon, Jun 16, 2025 at 10:39 AM Siddharth Wagle > wrote: > > > +1 for the merge of this feature. Thank you to all who cont

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 Thanks for all the work that has been put into this. -Siyao On Mon, Jun 16, 2025 at 10:39 AM Siddharth Wagle wrote: > +1 for the merge of this feature. Thank you to all who contributed to this > feature that enhances the robustness and manageability of Apache Ozone. > > - Sid > > On Mon, Jun

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 for the merge of this feature. Thank you to all who contributed to this feature that enhances the robustness and manageability of Apache Ozone. - Sid On Mon, Jun 16, 2025 at 10:35 AM Ritesh Shukla wrote: > +1 > Disclaimer: I am a sponsor and contributor for this work > > On Tue, Jun 10, 2025

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 Disclaimer: I am a sponsor and contributor for this work On Tue, Jun 10, 2025 at 5:40 PM Ethan Rose wrote: > Based on discussion in the community sync this week I want to add some more > information. > Code > > For those interested in checking out the code, these are some of the major > class

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

Thank you guys for the nice work. +1 for the merge. Regards, Uma On Tue, Jun 10, 2025 at 5:44 PM Ethan Rose wrote: > Based on discussion in the community sync this week I want to add some more > information. > Code > > For those interested in checking out the code, these are some of the major >

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

+1 for the merge On Tue, Jun 10, 2025 at 8:44 PM Ethan Rose wrote: > Based on discussion in the community sync this week I want to add some more > information. > Code > > For those interested in checking out the code, these are some of the major > classes to start with: > >- ReconcileContain

Re: [VOTE] Merge branch HDDS-10239-container-reconciliation into master

Based on discussion in the community sync this week I want to add some more information. Code For those interested in checking out the code, these are some of the major classes to start with: - ReconcileContainerTask: This is the command on the datanode that is received from SCM to reconcil

[VOTE] Merge branch HDDS-10239-container-reconciliation into master

Hi Ozone devs, We would like to propose merging the HDDS-10239-container-reconciliation branch into master. This feature adds a data checksum for all non-open containers, and enables manual reconciliation of Ratis container replicas that have diverged with different data checksums due to failures