Well makes sense in a way but everytime the PR size isn't the right
metric, if you have 100 lines of code & if it bothers some core and
complex part & if there is a possibility to split, it is good to do
so, because it lets the reviewer to focus on that core & complex part
one at a time.
Sometimes
+1 on adding a section under CONTRIBUTING.md, everyone looks at it before
starting contributing to the project.
In the template reminder, we can point devs to CONTRIBUTING.md for more
info.
Thanks,
Christos
On Thu, Jul 27, 2023 at 2:48 AM Ethan Rose
wrote:
> That sounds good to me. We could ad
That sounds good to me. We could add a brief reminder there and more
details in the contributing guide if we want.
On Wed, Jul 26, 2023 at 4:31 PM Wei-Chiu Chuang wrote:
> Actually I'd prefer adding a reminder in the PR template here
>
> https://github.com/apache/ozone/blob/master/.github/pull_r
Actually I'd prefer adding a reminder in the PR template here
https://github.com/apache/ozone/blob/master/.github/pull_request_template.md
Seems like a good way to soft-enforce the rule.
On Wed, Jul 26, 2023 at 3:53 PM Ethan Rose
wrote:
> I've definitely been on both sides: posting a large PR my
I've definitely been on both sides: posting a large PR myself, and as a
reviewer asking for PRs to be separated into smaller pieces. If we want
something persisted beyond an email thread I think we could update
CONTRIBUTING.md with a new section about how to post larger changes. Tips
for breaking d
Hi Ozoners,
In one of the coffee break chats with a colleague of mine, we realized many
of the PRs in the Ozone project are quite lengthy.
I'm guilty of this myself too. Keeping PR short and sweet is good hygiene.
It allows reviewers to spot potential problems in the code easier, and your
PR is m
