Re: Protobuf Enum Migration: Compatibility and Compilation Issues

Hi Tsz-Wo Thanks for your reply, > BucketInfo#StorageTypeProto can be replaced with . I think compatibility is fine, but if we change an existing protobuf field, `proto-backwards-compatibility` will report an error unless `-DallowBreakingChanges=true` is added during compilation. But how s

Re: [VOTE] Apache Ozone 1.4.1 RC1

I also filed https://issues.apache.org/jira/browse/RATIS-2141 to track the memory leak issue. Thanks, Duong On Tue, Aug 20, 2024 at 6:17 PM Duong Nguyen wrote: > Hi all, > > I just started a thread to discuss releasing Ratis 3.1.1 with the fixes of > the mentioned issues. > > Duong > > On Tue,

Re: [VOTE] Apache Ozone 1.4.1 RC1

Hi all, I just started a thread to discuss releasing Ratis 3.1.1 with the fixes of the mentioned issues. Duong On Tue, Aug 20, 2024 at 5:30 PM Uma Maheswara Rao Gangumalla < umaganguma...@gmail.com> wrote: > Hi Wei-Chiu, > > Thank you and Duong for the important update on RC1. > > @Duong would

Re: [VOTE] Apache Ozone 1.4.1 RC1

Hi Wei-Chiu, Thank you and Duong for the important update on RC1. @Duong would you be notifying this to Ratis community if they can make a quick release with just above 2 fixes? Regards, Uma On Tue, Aug 20, 2024 at 4:51 PM Wei-Chiu Chuang wrote: > Hi thanks for the effort, > We are testing t

Re: [VOTE] Apache Ozone 1.4.1 RC1

Hi thanks for the effort, We are testing the latest Ozone master and Ratis 3.1.0 internally, and found a few critical issues. (1) RATIS-2132 which has about 10% performance regression penalty. (2) Key put fails for large files (> 20GB) due to a me

Re: [VOTE] Apache Ozone 1.4.1 RC1

+1 (binding) - Verified signatures - Verified checksums - Checked ./bin/ozone version output from binary tarball - Checked ./bin/ozone checknative output from binary tarball - rocks_tools_native lib check is missing, filed HDDS-11347

Re: Protobuf Enum Migration: Compatibility and Compilation Issues

> ... because the proto message `BucketInfo#StorageTypeProto` is marked as `required`. ... BucketInfo#StorageTypeProto can be replaced with the new enum since "enum is compatible with int32, uint32, int64, and uint64 in terms of wire format". The new StorageTypeProto in hdds.proto will be compat

Re: Protobuf Enum Migration: Compatibility and Compilation Issues

Hi Tsz-Wo, Abhishek Pal Indeed, proto2 does not support adding `[deprecated = true]` to enums. Therefore, I intend to use the `restrict-imports-enforcer-rule` plugin to limit the usage of these enums that are effectively deprecated, by prohibiting their import. However, this approach cannot en