Re: Protobuf Enum Migration: Compatibility and Compilation Issues

2024-08-19 Thread Abhishek Pal
> According to https://protobuf.dev/programming-guides/proto2/#enum , we should add [deprecated=true] to each field instead of removing the old protos. Please try. It seems in the current proto2 version we are using deprecated fields are not being supported in enums. Also the reserved keyword tha

Re: Protobuf Enum Migration: Compatibility and Compilation Issues

2024-08-19 Thread Tsz Wo Sze
> Will there be any compatibility issues after moving enum `StorageTypeProto` from `ScmServerDatanodeHeartbeatProtocol.proto` to `hdds.proto` and standardize, and change all the places where `StorageTypeProto` is used in the existing protobuf to `hdds.proto#StorageTypeProto`? There are different l

Re: [VOTE] Apache Ozone 1.4.1 RC1

2024-08-19 Thread Ayush Saxena
+1 (Binding), some minor stuff which we should fix in next release * Built from source * Verified Checksums * Verified Signatures * All source files have apache header * No code diff b/w the git tag & the contents of src tar (dependency-reduced-pom only in src tar, maybe that ain't required there)

Protobuf Enum Migration: Compatibility and Compilation Issues

2024-08-19 Thread mrchenx
Dear Ozone Devs, I am currently developing some features related to StoragePolicy and have encountered an issue for which I am seeking a solution. ## What I want to do - Move the enum `StorageTypeProto` from `ScmServerDatanodeHeartbeatProtocol.proto` to `hdds.proto`. - Most of the pr