Re: [DISCUSS] Please limit PR size

2023-07-26 Thread Ethan Rose
That sounds good to me. We could add a brief reminder there and more details in the contributing guide if we want. On Wed, Jul 26, 2023 at 4:31 PM Wei-Chiu Chuang wrote: > Actually I'd prefer adding a reminder in the PR template here > > https://github.com/apache/ozone/blob/master/.github/pull_r

Re: [DISCUSS] Please limit PR size

2023-07-26 Thread Wei-Chiu Chuang
Actually I'd prefer adding a reminder in the PR template here https://github.com/apache/ozone/blob/master/.github/pull_request_template.md Seems like a good way to soft-enforce the rule. On Wed, Jul 26, 2023 at 3:53 PM Ethan Rose wrote: > I've definitely been on both sides: posting a large PR my

Re: [DISCUSS] Please limit PR size

2023-07-26 Thread Ethan Rose
I've definitely been on both sides: posting a large PR myself, and as a reviewer asking for PRs to be separated into smaller pieces. If we want something persisted beyond an email thread I think we could update CONTRIBUTING.md with a new section about how to post larger changes. Tips for breaking d

Re: [DISCUSS] Drop Hadoop 3.1 3.2 runtime support

2023-07-26 Thread Michel Sumbul
Hello, I think it make sense to not support anymore 2.x. For 3.x I think it really depend of the ecosystem. We need to have a balance between what allow ozone to quickly iterate and innovative but in the same time ensure that other open source projects will still work with newer version of ozone.

[DISCUSS] Please limit PR size

2023-07-26 Thread Wei-Chiu Chuang
Hi Ozoners, In one of the coffee break chats with a colleague of mine, we realized many of the PRs in the Ozone project are quite lengthy. I'm guilty of this myself too. Keeping PR short and sweet is good hygiene. It allows reviewers to spot potential problems in the code easier, and your PR is m

Re: [DISCUSS] Drop Hadoop 3.1 3.2 runtime support

2023-07-26 Thread Arpit Agarwal
Thanks for starting the discussion Wei-Chiu. It will be good to hear the community views on this. Should we also cross-post this topic to GitHub discussions and the slack channel for more awareness because this will be an impactful change if we go ahead? On Jul 26, 2023 at 10:38:19 AM, Wei-Chiu

[DISCUSS] Drop Hadoop 3.1 3.2 runtime support

2023-07-26 Thread Wei-Chiu Chuang
Hi Ozoner community, it's me again. I'd like to get your feedback on dropping Hadoop 3.1 3.2 runtime support. Currently, Ozone is built with Hadoop 3.3.6 dependency. Our test matrix certifies Ozone execution with Hadoop 2.7, 3.1, 3.2 and 3.3.6. I am not familiar with the history of this, but give

Re: [DISCUSS] Next Ozone major release 1.4.0

2023-07-26 Thread Janus Chow
Hello, Dev, This is a addendum for last topic summary. Tag Count URL Snapshot 127 https://issues.apache.org/jira/browse/HDDS-6517 https://issues.apache.org/jira/browse/HDDS-7984 RM 74 https://issues.apache.org/jira/browse/HDDS-7759 EC 65 https

Re: [DISCUSS] Next Ozone major release 1.4.0

2023-07-26 Thread Janus Chow
Hello, Dev, I have made a rough summary on the PRs since 1.3.0, there are over 900+ PRs since Jan 2023. Thank you all for the great contribution. Among the PRs, I have picked out some main topics as follows: Tag Count URL Snapshot 127 https://issues.apache.org/jira/browse/HDDS-6517 https