Re:[VOTE] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-23 Thread guimark
I started to contribute to this feature these days, in my opinion, the framework of the feature itself is stable and will not do harm to any other parts. And it is a really big step towards the future 'rolling upgrade'. As elek pointed, there are some issues needs to be fixed, and I'd be

Re: [VOTE] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-23 Thread Attila Doroszlai
Thanks Marton for sharing your thoughts. > which commit is the merge candidate? I think this is an important question. The merge vote should be about a specific commit, similar to releases. It's a moving target either way (one's evaluation might be obsolete by the next commit), but at least it

Re: [VOTE] - Merge Non rolling upgrade branch - 'HDDS-3698-nonrolling-upgrade'

2021-04-23 Thread Elek, Marton
-0 While I really appreciate the great work, and I would like to have this branch merged, I didn't feel that I got the answer to my previous question (which commit is the merge candidate?, is HDDS-5118 a release blocker issue?) It turns out that I have different opinion about "let's finish i