Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Sammi Chen
Thanks Shashi for starting the discussion. Good to see that SCM HA is close to ready :) +1 for the merging proposal. also +1 for Xiaoyu and Attila's suggestion. Besides, it would be great if we can have documents about 1. SCM performance comparison before and after merge 2. Backward compatibility

[GitHub] [ozone-docker-testkrb5] adoroszlai commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests

2021-03-09 Thread GitBox
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590537066 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

[GitHub] [ozone-docker-testkrb5] elek commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests

2021-03-09 Thread GitBox
elek commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590533575 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [ozone-docker-testkrb5] adoroszlai commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests

2021-03-09 Thread GitBox
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590497494 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Elek, Marton
Sorry, one more mail, but I couldn't resist to celebrate this: I just checked Sonar results (it seems to have up-to-date HDDS-2823 data) While there are few more issues compared the master, the code coverage seems to be 73.7 % on the SCM-HA branch compared to the 71.5 % master (master has 5

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Arpit Agarwal
Were these guidelines voted and agreed upon by the community? On Tue, Mar 9, 2021, 4:20 AM Elek, Marton mailto:e...@apache.org>> wrote: Thanks to start the discussion Shashikant, Good to see that SCM HA is close to the merge. I like Attila's suggestion: +1 to check stability based on the check

[GitHub] [ozone-docker-testkrb5] elek commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests

2021-03-09 Thread GitBox
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-793989075 Tested on a [forked branch](https://github.com/elek/ozone/tree/docker-secure), and finally [it's passed](https://github.com/elek/ozone/runs/2056855876) (= only an intermit

[GitHub] [ozone-docker-testkrb5] elek opened a new pull request #1: Provide testkrb5 image for faster ozonesecure tests

2021-03-09 Thread GitBox
elek opened a new pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1 Today ozonesecure compose clusters (and ozonesecure-ha and ozonesecure-mr) use an adhoc keytab issuer. The issuer is download during the [image creation](https://github.com/apache/ozone/blob/mast

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Lin, Yiqun
> It would be great if we could get a clear status of the SCM HA branch... Also +1 for Attila's suggestion. On 2021/3/9, 8:20 PM, "Elek, Marton" wrote: External Email Thanks to start the discussion Shashikant, Good to see that SCM HA is close to the merge. I like Attila's su

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread runzhiwang
+1 and thanks Shashikant for the discussion. Thanks, runzhiwang Elek, Marton 于2021年3月9日周二 下午9:15写道: > One more idea: > > It would be great to do a presentation on the community meeting(s) > and/or record it to explain the high-level details of the final > implementation. > > After the merge eve

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Elek, Marton
One more idea: It would be great to do a presentation on the community meeting(s) and/or record it to explain the high-level details of the final implementation. After the merge every developer should have enough knowledge to debug SCM HA related problems (if exists ;-) ) (Some example que

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Elek, Marton
Thanks to start the discussion Shashikant, Good to see that SCM HA is close to the merge. I like Attila's suggestion: +1 to check stability based on the checklist and create a wiki page. And +1 the merge after we have passed all the items (as we will have enough information to believe that ma

Re:Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread GlenGeng
+1. Thanks Shashi for the proposal. SCM HA has been under development for quite a long time. Merging back to master is a milestone for this feature. Having full HA functionality is the prerequisite of making Apache Ozone production ready, and SCM HA make us closer to this target ! BR Glen G

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread mingchao zhao
Thanks Shashikant for this proposal. +1, SCM HA is required for production. The absence of HA before has limited the promotion of Ozone within us. 1. Both OM and SCM HA can give users more confidence to use Ozone. 2. Merge to master allows us to test and improve early Regards, Mingchao Attila Do

Re: [DISCUSS] - Merge SCM-HA Branch - HDDS-2823

2021-03-09 Thread Attila Doroszlai
Thanks Shashikant for starting the discussion. Marton has recently proposed a solid checklist to go through before branch merge: https://cwiki.apache.org/confluence/display/OZONE/Merging+branches One of the items is basic documentation as suggested by Xiaoyu. It would be great if we could get a c