---
datapath-windows/ovsext/Actions.c | 82 +++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 154 --
datapath-windows/ovsext/Flow.h | 6 +
datapath-windows/ovsext/Geneve.c
patch soon.
Thanks again,
Yin
From: Jesse Gross
Sent: Tuesday, May 17, 2016 6:06 PM
To: Yin Lin
Cc: ovs dev
Subject: Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.
On Tue, May 17, 2016 at 5:02 PM, Yin Lin wrote:
> diff --git a/datapath-w
---
datapath-windows/ovsext/Actions.c | 82 +++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 171 +++--
datapath-windows/ovsext/Flow.h | 7 +
datapath-windows/ovsext/Genev
---
datapath-windows/ovsext/Actions.c | 82 +++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 171 ++--
datapath-windows/ovsext/Flow.h | 7 +
datapath-windows/ovsext/Geneve
From: Flavio Fernandes
Make test calls to ovs-ofctl in test use the protocol parameter
'-O OpenFlow13', so it is consistent with the existing dump-flows
invocations.
Signed-off-by: Flavio Fernandes
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 10 +-
1 file changed, 5 insertions(+), 5 d
UDP checksum computation is shared by both vxlan and geneve on Windows.
Move the function so that the code can be shared.
---
datapath-windows/ovsext/Offload.c | 45 +++
datapath-windows/ovsext/Offload.h | 6 -
datapath-windows/ovsext/Vxlan.c | 49 ---
fewer parameter but also returns
a single port. Does that mean this function should be removed?
Best regards,
Yin Lin
From: Nithin Raju
Sent: Thursday, May 19, 2016 5:05 PM
To: Yin Lin; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 3/3] [PATCH v3] Add G
Hi Jesse,
Thanks so much for the review! Somehow I didn't get your "previous" email about
checksum. Can you send it again? I'll address format the commit message
according to your suggestions. Thanks again!
Best regards,
Yin Lin
Fro
16 5:01 PM
To: Yin Lin; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 2/3] [PATCH v1] Move UDP checksum computation to
Offload.c
Thanks for the patch.
>@@ -414,7 +372,7 @@ OvsDecapVxlan(POVS_SWITCH_CONTEXT switchContext,
> IPHdr *ipHdr;
> UDPHdr *udpHdr;
> VXLANHdr *
UDP checksum computation is shared by both vxlan and geneve on Windows.
Move the function so that the code can be shared.
Signed-off-by: Yin Lin
---
Do not copy the inner ethernet header as it's not used.
---
datapath-windows/ovsext/Offload.c | 45
dat
Signed-off-by: Yin Lin
---
Fixed the Geneve option parsing algorithm.
---
datapath-windows/ovsext/Actions.c | 82 +++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 172
Signed-off-by: Yin Lin
---
Fixed checksum flag issue brought up by Jesse and automake.mk issue by Nithin.
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 82 +++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext
UDP checksum computation is shared by both vxlan and geneve on Windows.
Move the function so that the code can be shared.
Signed-off-by: Yin Lin
---
No change.
---
datapath-windows/ovsext/Offload.c | 45
datapath-windows/ovsext/Offload.h | 6 -
datapath
Thanks Nithin for working on this! The fix overall looks pretty good.
Can we get rid of OvsFindTunnelVportByPortType since it doesn't make much
sense and is dangerous to call if user doesn't understand what it actually
does?
Also, there is some misalignment in the following code. Did you use tab?
Signed-off-by: Yin Lin
---
datapath-windows/ovsext/Flow.c | 2 +-
datapath-windows/ovsext/Vport.c | 3 ++-
datapath-windows/ovsext/Vport.h | 5 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index bc0bb37
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> OVS_EVENT_ENTRY currently handles only Vport related events. Updating the
> name of the struct to OVS_VPORT_EVENT_ENTRY. This will assist in
> introducing other structs to manage other events.
&
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER
> protocols for netlink communication. Define these two protocols in the
> datapath.
>
> Signed-off-by: Sairam Venugopal
> ---
&
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> Update the datapath to refer to events as vportEvents. This will aid in
> the introduction of other events.
>
> Signed-off-by: Sairam Venugopal
> ---
> datapath-windows/ovsext/Datapath.c | 3 ++-
&
Thanks Sai for fixing the bugs. A few questions:
1. There is also an unrelease lock in line 359, function OvsWaitEventIoctl.
2. Do we need the lock before OvsGetOpenInstance? If so, please release the
lock inside "if (instance == NULL)"; if not, you should do the same thing
on line 359.
On Wed
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating
> netlink messages from other files. Also define the function in Conntrack.h
> to make it accessible.
>
> Signed-off-by: S
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> Define new Conntrack events (new and delete) and add support for
> subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it
> as part of OVS_EVENT_SUBSCRIBE structure.
>
> Signed
AM, Alin Serdean <
aserd...@cloudbasesolutions.com> wrote:
>
>
> > -Mesaj original-
> > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
> > Trimis: Thursday, July 21, 2016 4:30 PM
> > Către: Yin Lin ; dev@openvswitch.org
> &g
Venugopal
wrote:
> Hi Yin,
>
> Thanks for reviewing this. (1) has been addressed in a different patch.
> (2) We don¹t need the lock for OvsGetOpenInstance().
>
> Thanks,
> Sairam
>
> On 7/18/16, 11:07 AM, "Yin Lin" wrote:
>
> >Thanks Sai for fixi
ch is not the case.
Best regards,
Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> Define new Conntrack events (new and delete) and add support for
> subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it
> as part of OVS_EVENT_SUBSCRIBE structure.
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> OVS_EVENT_ENTRY currently handles only Vport related events. Updating the
> name of the struct to OVS_VPORT_EVENT_ENTRY. Remove OVS_EVENT_STATUS since
> it's currently not in use. Update the datapa
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER
> protocols for netlink communication. Define these two protocols in the
> datapath.
>
> Define new Conntrack events (new and delete)
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> When userspace tries to resubscribe to an existing queue, return
> STATUS_INVALID_PARAMETER since it's not supported. The current bug
> overwrites status to STATUS_SUCCESS.
>
> The second bug fix
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating
> netlink messages from other files. Also define the function in Conntrack.h
> to make it accessible.
>
> v2: Added Acked-By
&g
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> Update Event.c to have multiple event queues and mechanism to retrieve the
> associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry
> similar to OvsPostVportEvent and OvsRemoveVportEventEntr
Acked-By: Yin Lin
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> Post Conntrack delete and create events when entries are deleted or
> created.
>
> v2: Added Acked-By
>
> Signed-off-by: Sairam Venugopal
> Acked-by: Paul Boca
> Acked-by: Alin Gabriel Se
Cannot find patch 6. Can you send it out again?
On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal
wrote:
> Add support for sending out Conntrack events on Windows (if subscribed).
> This meant adding support for handling multiple event queues.
>
> v2: Address review comments and squashed the 9 s
Acked-by: Yin Lin
On Tue, Jun 7, 2016 at 11:20 AM, Sairam Venugopal
wrote:
> Acked-by: Sairam Venugopal
>
>
> On 6/3/16, 9:34 AM, "Nithin Raju" wrote:
>
> >In Actions.c, based on the IP Protocol type and L4 port of
> >the outer packet, we lookup the t
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 74 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 173
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 74 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 173
So, I¹d
> request you to declare them at the top of the scope.
>
> Also, pls. remove the Gre.c code. Alin is addressing the same piece of
> code in a different patch that is out for review.
>
> Welcome to the club!
>
> Thanks,
> -- Nithin
>
> -Original Mess
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 72 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 179
Acked-by: Yin Lin
On Tue, Jun 21, 2016 at 11:09 AM, Sairam Venugopal
wrote:
> Clean up unused headers in Datapath.c. Found by inspection.
>
> Signed-off-by: Sairam Venugopal
> ---
> datapath-windows/ovsext/Datapath.c | 7 ---
> 1 file changed, 7 deletions(-)
>
&g
Signed-off-by: Yin Lin
---
datapath-windows/ovsext/Stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index 0bac5f2..5aaf6fe 100644
--- a/datapath-windows/ovsext/Stt.c
+++ b/datapath-windows/ovsext/Stt.c
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 72 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 179
Signed-off-by: Yin Lin
---
datapath-windows/ovsext/Stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index 0bac5f2..5aaf6fe 100644
--- a/datapath-windows/ovsext/Stt.c
+++ b/datapath-windows/ovsext/Stt.c
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 72 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 179
Signed-off-by: Yin Lin
---
datapath-windows/ovsext/Stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index 0bac5f2..5aaf6fe 100644
--- a/datapath-windows/ovsext/Stt.c
+++ b/datapath-windows/ovsext/Stt.c
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 72 ++-
datapath-windows/ovsext/Debug.h| 1 +
datapath-windows/ovsext/DpInternal.h | 29 ++-
datapath-windows/ovsext/Flow.c | 179
Nope. Nithin, can you approve the second patch. It’s a minor whitespace
alignment patch.
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, June 24, 2016 2:48 PM
To: Yin Lin
Cc: ovs dev
Subject: Re: [ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows: Add Geneve
support
On 24 June 2016 at
Hi Nithin,
Instead of removing the assertion, can you change it to:
ASSERT(!key->tunKey.dst || offset == OvsGetFlowL2Offset(&key->tunKey));
I fixed it for OvsLookupFlow but somehow overlooked OvsHashFlow in my
Geneve patch.
Best regards,
Yin Lin
On Wed, Aug 31, 2016 at 3:33 AM, N
Some lately added targets such as ovsext_make, manpage-check and
thread-safety-check are not files but was not marked as .PHONY. This causes
them to be unnecessarily rebuilt during "make check" and "make install" process.
___
dev mailing list
dev@openvs
Thanks Ben for the prompt reply! I enclosed the patch in the original email.
Attaching it again.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Wednesday, December 23, 2015 1:25 PM
To: Yin Lin
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non
You are right. Enclosed a new patch.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Wednesday, December 23, 2015 1:30 PM
To: Yin Lin
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets as .PHONY
manpage-check shouldn't be
nstall" process.
Signed-off-by: Yin Lin
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Wednesday, December 23, 2015 1:51 PM
To: Yin Lin
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets as .PHONY
Thanks, can you provide a
49 matches
Mail list logo
