t know any
>> other general solution. I tested the workaround only on Linux.
>>
>> CC: YAMAMOTO Takashi
>> Signed-off-by: Ben Pfaff
>
> I'd appreciate a review of this.
sorry for being irresponsive. the patch you pushed seems good to me.
YAMAMOTO Takash
datapath.o
> /home/jesse/openvswitch/datapath/linux/datapath.c: In function
> ‘ovs_flow_cmd_set’:
can you avoid non-ascii chars in commit messages? thank you.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
These warnings were introduced by
commit 7d031d7e511aeea8dd45348922fe8e3bbdd2956e
("ofproto-dpif-xlate: Work around Linux netdev_max_backlog limit.")
and found by --enable-Werror build on NetBSD.
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-xlate.c | 4 +++-
1 file
Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 .
("Misc cleanup with "util.h" header files")
Signed-off-by: YAMAMOTO Takashi
---
lib/util.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.h b/lib/util.h
index a908267..f631bdf 100644
--- a/
As ovsdb-server creates pid file before unixctl socket, waiting
for pid file creation is not enough. Fix the race by retrying
with "version" command before assuming the server is up.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovsdb-server.at | 4
1 file changed, 4 insertions(+)
ic warning.
But currently it doesn't make much sense as dp_unregister_provider
is only used for --enabled-dummy.
Signed-off-by: YAMAMOTO Takashi
---
lib/dpif.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/dpif.c b/lib/dpif.c
index 5037ac6..2abd1e2 100644
--- a/lib/dpif.c
+++ b/
NetBSD's "sort -d" preserves the order of lines which doesn't have
alphanumeric and blanks. eg. empty lines and [].
It means it sometimes preserve unstable order of the list output.
Also, simply remove -d option where the expected output doesn't
include [].
Signed
)
Workaround the issue by using env command for shebangs for
these scripts.
Noticed with the recent tunnel-push-pop.at tests using ovs-pcap command.
Signed-off-by: YAMAMOTO Takashi
---
utilities/ovs-check-dead-ifs.in | 2 +-
utilities/ovs-dpctl-top.in | 2 +-
utilities/ovs-l3ping.in
netinet/ip6.h is not a standalone header there.
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-native-tnl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index 2e181f2..123f3b2 100644
--- a/lib/netdev-native-tnl.c
+++ b/lib/netdev-native
Fix the following error on NetBSD 7.0.
../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask':
../lib/ovs-numa.c:555:9: error: array subscript has type 'char'
[-Werror=char-subscripts]
Signed-off-by: YAMAMOTO Takashi
---
lib/ovs-numa.c | 2 +-
1 file change
== is a GNU extension which might not be available.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index feb68d3..3436417 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -839,7 +839,7 @@ for is
Clear actset_output so that it can be compared via flow_equal.
Note: trace->key has actset_output == 0.
Found by OVS flow tests under development for Neutron. [1]
[1]
https://review.openstack.org/#/c/235155/10/neutron/tests/functional/agent/test_ovs_flows.py@399
Signed-off-by: YAMAMOTO Taka
Signed-off-by: YAMAMOTO Takashi
---
INSTALL.NetBSD.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/INSTALL.NetBSD.md b/INSTALL.NetBSD.md
index 1c571cf..5a1f703 100644
--- a/INSTALL.NetBSD.md
+++ b/INSTALL.NetBSD.md
@@ -8,6 +8,7 @@ In that case, you need at least the
. The matching process
tries each alternative in turn, from left to right, and the
first one that succeeds is used. It is a GNU extension.
Signed-off-by: YAMAMOTO Takashi
---
tests/vlog.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vlog.at b/
So that testsuite can compare log messages including the string.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 20
tests/ofproto-macros.at | 1 -
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib/util.c b/lib/util.c
index f06dee5..36abeed
It seems like a non-portable bash extension.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index caf9f98..da0291f 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -3618,8 +3618,8 @@ test_dhcp
The list of supported iface types hardcoded in the test
is wrong on NetBSD. (or any userland-only ports I guess)
Instead of adding another case for NetBSD following WIN32,
just get the list from ovsdb.
Signed-off-by: YAMAMOTO Takashi
---
tests/ovn-controller.at | 8 +---
1 file changed, 1
Fix recently introduced parent_pid macro on NetBSD 7.0.
On NetBSD, procfs status file looks like the following.
n7% cat /proc/$$/status
zsh 18509 12970 18509 18509 5,8 ctty,sldr 1476344459,639266 0,15575 0,15575
pause 1000 100,100,0
n7%
Signed-off-by: YAMAMOTO Takashi
---
tests
> ovsdb-server on windows crashes without it.
>
> Signed-off-by: Gurucharan Shetty
why is it necessary on windows?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
applied, thanks.
> Acked-by: Jarno Rajahalme
>
> On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi wrote:
>
>> Catched by "learning action - self-modifying flow with hard_timeout"
>> test case.
>>
>> The bug introduced by commit b256dc52.
>>
> Thanks for catching this. It is also used later on to set xin.may_learn,
> does that matter too?
yes, it matters too.
YAMAMOTO Takashi
>
>
> On 19 April 2014 03:22, Jarno Rajahalme wrote:
>
>> Acked-by: Jarno Rajahalme
>>
>> On Apr 17, 2014, at
> +hash = mhash_finish(hash, 13); /* No need to match byte length here.
> */
is it worth being special?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
do these inlining yield measurable improvements?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
>
> On Apr 20, 2014, at 7:49 PM, YAMAMOTO Takashi wrote:
>
>>> +hash = mhash_finish(hash, 13); /* No need to match byte length
>>> here. */
>>
>> is it worth being special?
>>
>
> I知 not exactly sure what you ask here, but in gene
Improve random distribution for an hmap with a small number of nodes
with the expense of the increased cpu cost.
It would be a fair trade-off because the situation is rather common
for bond, which is currently the only consumer of this API in tree.
Signed-off-by: YAMAMOTO Takashi
---
lib/hmap.c
> On Tue, Apr 22, 2014 at 01:47:32PM +0900, YAMAMOTO Takashi wrote:
>> Improve random distribution for an hmap with a small number of nodes
>> with the expense of the increased cpu cost.
>> It would be a fair trade-off because the situation is rather common
>> for bond,
wise, how about just rejecting such combinations?
it doesn't seem to worth the code complexity to me.
(sorry if it has been already discussed. it's the first time for me
to seriously read this long-lived patch.)
YAMAMOTO Takashi
___
d
> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
>> hi,
>>
>> > + * Due to the sample action there may be multiple possible eth types.
>> > + * In order to correctly validate actions all possible types are tracked
>> > + * and ver
> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
> wrote:
>>> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
>>>> hi,
>>>>
>>>> > + * Due to the sample action there may be multiple possible eth types.
>>>> &
the commands that check for
> creation/termination of threads to wait until they see the messages
> instead.
>
> Signed-off-by: Joe Stringer
Reviewed-by: YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
r.py match checks
>> to pass.
>
> I'm not sure that atomic_uint64 is portable to all platforms (notably I
> think some 32-bit platforms don't have atomic 64-bit ints). I'd feel
> more comfortable using atomic_ulong.
this is not the first use of them. cf. udpif::n_flo
.3 enables OpenFlow 1.0, 1.1, 1.2, and 1.3 by default
> + in ovs-vswitchd. In Open vSwitch 1.10 through 2.2, OpenFlow 1.1,
> + 1.2, and 1.3 must be enabled manually. The following command
> + enables OpenFlow 1.0, 1.1, 1.2, and 1.3 on bridge br0:
>
>
The problem mentioned by Simon Horman in the following mail.
http://openvswitch.org/pipermail/dev/2014-April/039492.html
Cc: Simon Horman
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-xlate.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto
> On Wed, Apr 30, 2014 at 10:24:46AM +0900, YAMAMOTO Takashi wrote:
>> The problem mentioned by Simon Horman in the following mail.
>> http://openvswitch.org/pipermail/dev/2014-April/039492.html
>>
>> Cc: Simon Horman
>> Signed-off-by: YAMAMOTO Takashi
>
>
as (ofproto, ofp port) and thus can be
used even when odp port is not available?
if a translation detects the condition (ie. recirculation is necessary
but in_port does not have the corresponding odp port), it can use
the userspace variant with SLOW_ACTION instead of normal RECIRC.
YAMAMOTO Takas
> It is my observation that when sending 91 packets to a mode=balance
> bond interface with three underlying ports in some cases not all ports
> receive at least 7 packets. This causes the test to fail.
was it with or without commit e58f91a1?
YAMAMOTO Takashi
>
> It may
> On Wed, Apr 30, 2014 at 11:59 PM, YAMAMOTO Takashi
> wrote:
>>>> Something like this (I have not tested either scenario):
>>>>
>>>> I think this will fail to match but that may not be obvious to users:
>>>> packet_out: in_port=CONTROL
> netdev_rxq_open() open-codes much of netdev_ref(), so re-use that
> function instead.
>
> Signed-off-by: Joe Stringer
Reviewed-by: YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> netdev_open() would previously increment a netdev's refcount without
> holding a lock for it. This commit shifts the locking to protect it.
>
> Found by inspection.
>
> Signed-off-by: Joe Stringer
Reviewed-by: YAMAMOTO Takashi
_
> On Thu, May 01, 2014 at 03:54:22PM +0900, YAMAMOTO Takashi wrote:
>> > On Wed, Apr 30, 2014 at 10:24:46AM +0900, YAMAMOTO Takashi wrote:
>> >> The problem mentioned by Simon Horman in the following mail.
>> >> http://openvswitch.org/pipermail/dev/2014-Apri
Introduced by commit 12eb035b.
("bridge: Allow users to configure statistics update to OVSDB.")
Cc: Alex Wang
Signed-off-by: YAMAMOTO Takashi
---
tests/ovs-vswitchd.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitch
Signed-off-by: YAMAMOTO Takashi
---
tests/ovs-vswitchd.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at
index a90477d..9f9721b 100644
--- a/tests/ovs-vswitchd.at
+++ b/tests/ovs-vswitchd.at
@@ -39,7 +39,7 @@ AT_SETUP([ovs
Introduced by commit 12eb035b.
("bridge: Allow users to configure statistics update to OVSDB.")
Cc: Alex Wang
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/bridge.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
ind
e *const THIS_MODULE = &VLM_##MODULE
Signed-off-by: YAMAMOTO Takashi
---
lib/route-table-bsd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c
index d02c76f..f14fea0 100644
--- a/lib/route-table-bsd.c
+++ b/lib/route-table-bsd.c
@@
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index ef1e649..8291182 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -548,7 +548,7 @@ struct pcap_arg {
static void
Signed-off-by: YAMAMOTO Takashi
---
lib/route-table-bsd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c
index 4cdf2ac..d02c76f 100644
--- a/lib/route-table-bsd.c
+++ b/lib/route-table-bsd.c
@@ -29,6 +29,7 @@
#include
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 6 ++
1 file changed, 6 insertions(+)
diff --git a/FAQ b/FAQ
index 86b48a2..519060a 100644
--- a/FAQ
+++ b/FAQ
@@ -431,6 +431,12 @@ A: First, why do you want to do this? Two connected
bridges are not
ports will not work with the userspace
xmalloc_cacheline API is relatively new. It's better
not to inherit the kludge from xmalloc. This kind of
kludge rather hurts these days.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.c b/lib/util.c
index 1ebe22a..464d730 1
Signed-off-by: YAMAMOTO Takashi
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 9672cb0..16bc6a6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -91,6 +91,7 @@ OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(8)
OVS_CHECK_POSIX_AIO
A malloc library is expected to provide a better implementation
using the knowledge of its internal details.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/util.c b/lib/util.c
index 464d730..37d2ba0 100644
--- a/lib
This file was obtained from:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_func_posix_memalign.m4
Signed-off-by: YAMAMOTO Takashi
---
m4/ax_func_posix_memalign.m4 | 50
1 file changed, 50 insertions(+)
create mode
> On Sat, May 03, 2014 at 09:01:01AM +0900, YAMAMOTO Takashi wrote:
>> xmalloc_cacheline API is relatively new. It's better
>> not to inherit the kludge from xmalloc. This kind of
>> kludge rather hurts these days.
>>
>> Signed-off-by: YAMAMOTO Takashi
&
A malloc library is expected to provide a better implementation
using the knowledge of its internal details.
ax_func_posix_memalign.m4 was obtained from:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_func_posix_memalign.m4
Signed-off-by: YAMAMOTO Takashi
changes from the previous:
- drop the controversial part (size=0 case behaviour)
- squash patches
YAMAMOTO Takashi (1):
util: Use posix_memalign for xmalloc_cacheline if available
configure.ac | 1 +
lib/util.c | 16 ++
m4
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 13 +
1 file changed, 13 insertions(+)
diff --git a/FAQ b/FAQ
index fc21af4..716c1de 100644
--- a/FAQ
+++ b/FAQ
@@ -676,6 +676,19 @@ A: On Linux kernels before 3.11, the OVS GRE module and
Linux GRE module
can then reload the OVS module
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/FAQ b/FAQ
index 519060a..fc21af4 100644
--- a/FAQ
+++ b/FAQ
@@ -275,8 +275,8 @@ A: The following commands configure br0 with eth0 and tap0
as trunk
applied to master and 2.2, thanks.
YAMAMOTO Takashi
> Thanks a lot for the fix, YAMAMOTO,
>
> @@
>
> Just reminder, this also requires backport to branch-2.2.
>
>
> On Fri, May 2, 2014 at 4:49 PM, Ben Pfaff wrote:
>
>> On Sat, May 03, 2014 at 08:10:0
> On Sat, May 03, 2014 at 08:13:20AM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
applied, thanks.
YAMAMOTO Takashi
> ___
> dev mailing list
> dev@openvswitch.org
> htt
> On Sat, May 03, 2014 at 08:12:01AM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
applied, thanks.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> netdev_open() would previously increment a netdev's refcount without
> holding a lock for it. This commit shifts the locking to protect it.
>
> Found by inspection.
>
> Signed-off-by: Joe Stringer
Acked-by: YAMAMOTO Takashi
> ---
> lib/netdev.c |
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/automake.mk | 2 +-
vtep/automake.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk
index c45d01d..c445302 100644
--- a/vswitchd/automake.mk
+++ b/vswitchd/automake.mk
@@ -30,7
> On Mon, May 05, 2014 at 09:39:02AM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> I'm surprised it makes any difference.
i occasionally see the failure with make -j32.
YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
_
> On Mon, May 05, 2014 at 08:32:34AM +0900, YAMAMOTO Takashi wrote:
>> > On Sat, May 03, 2014 at 09:01:01AM +0900, YAMAMOTO Takashi wrote:
>> >> xmalloc_cacheline API is relatively new. It's better
>> >> not to inherit the kludge from xmalloc. This kin
> On Mon, May 05, 2014 at 09:13:53AM +0900, YAMAMOTO Takashi wrote:
>> +Q: Open vSwitch does not seem to obey my packet filter rules.
>> +
>> +A: It's by design. Open vSwitch interacts with packets at a lower layer
>> + than typical packet-filter implementations
> On Tue, May 06, 2014 at 09:02:06AM +0900, YAMAMOTO Takashi wrote:
>> > On Mon, May 05, 2014 at 09:13:53AM +0900, YAMAMOTO Takashi wrote:
>> >> +Q: Open vSwitch does not seem to obey my packet filter rules.
>> >> +
>> >> +A: It's by design.
> On Wed, May 07, 2014 at 08:09:08AM +0900, YAMAMOTO Takashi wrote:
>> > On Tue, May 06, 2014 at 09:02:06AM +0900, YAMAMOTO Takashi wrote:
>> >> > On Mon, May 05, 2014 at 09:13:53AM +0900, YAMAMOTO Takashi wrote:
>> >> >> +Q: Open vSwitch
thanks for explanation.
> Will you push this, then?
i will push it later, with your co-authored-by.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
g the"
>
>> you want to use ebtables rules.) On NetBSD, you might want to
>> consider to use bridge(4) with BRIDGE_IPF option.
>
> Same with this "to use". (The one right above it is fine.)
>
> --Justin
thank you. i'll incorporate.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
>> On Mon, May 05, 2014 at 09:39:02AM +0900, YAMAMOTO Takashi wrote:
>>> Signed-off-by: YAMAMOTO Takashi
>>
>> I'm surprised it makes any difference.
>
> i occasionally see the failure with make -j32.
>
> YAMAMOTO Takashi
>
>>
>> A
> On Mon, May 05, 2014 at 08:33:37AM +0900, YAMAMOTO Takashi wrote:
>> A malloc library is expected to provide a better implementation
>> using the knowledge of its internal details.
>>
>> ax_func_posix_memalign.m4 was obtained from:
>> http://git.savannah.gnu.org
Co-authored-by: Ben Pfaff
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 30 ++
1 file changed, 30 insertions(+)
diff --git a/FAQ b/FAQ
index fc21af4..d3632f9 100644
--- a/FAQ
+++ b/FAQ
@@ -676,6 +676,36 @@ A: On Linux kernels before 3.11, the OVS GRE module and
Linux
> This patch enables the client dpdk rings within the netdev-dpdk. It adds
> a new dpdk device called dpdkr (other naming suggestions?).
how about dpdkring?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
> The bug fixed by the last patch exposes this one.
>
> Signed-off-by: Andy Zhou
Reviewed-by: YAMAMOTO Takashi
> ---
> ofproto/bond.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ofproto/bond.c b/ofproto/bond.c
> index c522ea3..803
> Bug #1229225
>
> Signed-off-by: Andy Zhou
Reviewed-by: YAMAMOTO Takashi
> ---
> ofproto/bond.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ofproto/bond.c b/ofproto/bond.c
> index c1a8448..c522ea3 100644
> --- a/ofproto/bond.c
>
> Yamamoto san, would you please take a look?
i'll take a look later.
YAMAMOTO Takashi
>
> On Wed, May 7, 2014 at 11:10 AM, Ben Pfaff wrote:
>> On Tue, May 06, 2014 at 10:46:45PM -0700, Andy Zhou wrote:
>>> Raise the minimal per interface packet distribution f
> Acked-by: Pritesh Kothari
thanks. applied.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
the
> whole number of 24.
the patch itself looks ok (thus acked-by) but i have a question on
the commit message.
why can the average number be larger than the expected number?
the total number of packets for a run is expected to be exactly 256,
isn't it?
Acked-by: YAMAMOTO Takashi
Te
n that case, packet distribution would be 1:1:2.
your value is safe enough for the distribution.
YAMAMOTO Takashi
>
> On Wed, May 7, 2014 at 6:18 PM, YAMAMOTO Takashi
> wrote:
>>> Raise the minimal per interface packet distribution from 7 to 24.
>>>
>>> With 25
> On Wed, May 7, 2014 at 7:01 PM, YAMAMOTO Takashi
> wrote:
>>> Sorry I was not clear in the commit message. It is the average of the
>>> first interface. I will make it clear before pushing.
>>
>> thanks for clarification.
>> i think the average is n
On NetBSD, perl is usually installed as /usr/pkg/bin/perl.
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/automake.mk | 2 +-
vtep/automake.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk
index b75322f..fd291ef 100644
--- a
It turned out to be non-problem.
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/automake.mk | 2 +-
vtep/automake.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk
index c445302..c45d01d 100644
--- a/vswitchd/automake.mk
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/automake.mk | 3 ++-
vtep/automake.mk | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/vswitchd/automake.mk b/vswitchd/automake.mk
index c45d01d..b75322f 100644
--- a/vswitchd/automake.mk
+++ b/vswitchd/automake.mk
@@ -31,7
hould we simply do "random_uin32() % #slaves", instead of
> hmap_random_node(), so that we can avoid your 2nd case?
it sounds like an improvement, yes.
(if there's a handy array of slaves.)
YAMAMOTO Takashi
>
> On Wed, May 7, 2014 at 8:07 PM, YAMAMOTO Takashi
> wrote:
sorry, i didn't know builddir can be different from srcdir.
> CC: YAMAMOTO Takashi
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/automake.mk | 2 +-
> vtep/automake.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vswitchd/autom
> CC: YAMAMOTO Takashi
> Signed-off-by: Ben Pfaff
thanks!
Reviewed-by: YAMAMOTO Takashi
> ---
> v1->v2: Add missing slash.
>
> vswitchd/automake.mk | 2 +-
> vtep/automake.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> On Fri, May 09, 2014 at 01:26:03PM +0900, YAMAMOTO Takashi wrote:
>> sorry, i didn't know builddir can be different from srcdir.
>
> I guess not everyone builds that way but I like to have multiple
> builddirs so that I can easily do both Clang and GCC builds off a single
Signed-off-by: YAMAMOTO Takashi
---
acinclude.m4 | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index e8a8a2e..104d4e4 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -35,8 +35,8 @@ AC_DEFUN
Signed-off-by: YAMAMOTO Takashi
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 104d4e4..230c033 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -163,7 +163,7 @@ dnl Configure DPDK source tree
AC_DEFUN([OVS_CHECK_DPDK
> Looks good. Thanks!
>
> Acked-by: Andy Zhou
Acked-by: YAMAMOTO Takashi
btw, --enable-Werror CC=clang doesn't work.
(clang complains about -g for linking)
is it only for me? a workaround is LDFLAGS=-Qunused-argument.
YAMAMOTO Takashi
>
>
>
> On Fri, May 9,
> On Fri, May 09, 2014 at 07:51:05PM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
thank you. applied both.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswi
Leftover of commit 0c473314.
("ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary")
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.a
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index e50b4fe..926f3d6 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -1241,13 +1241,13
this is a repost of trivial patches which failed to get reviewed
in a few weeks but still are valid.
what's the recommended procedure for unreviewed patches?
- drop
- push (i suspect this is the right thing to do for trivial ones like these)
- repost (this is what i'm doing)
YAMAMO
Signed-off-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofproto-dpif.h
index d4ad624..679a41e 100644
--- a/ofproto/ofproto-dpif.h
+++ b/ofproto/ofproto-dpif.h
@@ -81,8 +81,8 @@ extern
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 14293a5..84453d8 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -3677,15 +3677,17
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 84453d8..4dcaf63 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -3817,6 +3817,7 @@ done
AT_CHECK([ovs-appctl time
Simplify code and update comments after commit 61e7deb1.
("dpif-netdev: Use RCU to protect data.")
Signed-off-by: YAMAMOTO Takashi
---
lib/dpif-netdev.c | 37 -
1 file changed, 8 insertions(+), 29 deletions(-)
diff --git a/lib/dpif-netdev.c
These races were exposed on my environment by commit c2a77f33.
("tests/ofproto-dpif: Use vlog to test dpif behaviour.")
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.
> On Mon, May 12, 2014 at 11:49:03PM +0900, YAMAMOTO Takashi wrote:
>> These races were exposed on my environment by commit c2a77f33.
>> ("tests/ofproto-dpif: Use vlog to test dpif behaviour.")
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Be
ctl" call that can (somehow) wait until the
> processing of previously received packets has completed.
it would be great if it can be done without affecting non-test cases.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
1 - 100 of 588 matches
Mail list logo
