] ovs_flow_extract
4.06% kpktgend_0 [kernel.kallsyms] [k] _raw_spin_lock
3.90% kpktgend_0 [kernel.kallsyms] [k] jhash2
[...]
0.67% kpktgend_0 [kernel.kallsyms] [k] netlink_lookup
Signed-off-by: Thomas Graf
---
net/netlink/af_netlink.c | 285
then makes use of the new data type to implement lockless
netlink_lookup().
Against net-next since the initial user of the new hash table is in net/
Thomas Graf (2):
lib: Resizable, Scalable, Concurrent Hash Table
netlink: Convert netlink_lookup() to use RCU protected hash table
include
point to a single entry which would lead in obscure
reverse chaining behaviour.
Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
[0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
Signed-off-by: Thomas Graf
---
include/linux/rhashtable.h | 208
On 07/29/14 at 05:58pm, Tobias Klauser wrote:
> On 2014-07-29 at 13:41:33 +0200, Thomas Graf wrote:
> > Heavy Netlink users such as Open vSwitch spend a considerable amount of
> > time in netlink_lookup() due to the read-lock on nl_table_lock. Use of
> > RCU relieve
On 07/29/14 at 08:30am, Josh Triplett wrote:
> On Tue, Jul 29, 2014 at 01:41:32PM +0200, Thomas Graf wrote:
> > Generic implementation of a resizable, scalable, concurrent hash table
> > based on [0]. The implementation supports both, fixed size keys specified
> > via an
No need for the unlikely(), WARN_ON() and BUG_ON() internally use
unlikely() on the condition.
Signed-off-by: Thomas Graf
---
net/core/dev.c | 2 +-
net/openvswitch/datapath.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
wrong name of rht_shrink_below_30()
- exported symbols rht_grow_above_75() and rht_shrink_below_30()
- allow table freeing with RCU callback
Thomas Graf (3):
lib: Resizable, Scalable, Concurrent Hash Table
netlink: Convert netlink_lookup() to use RCU protected hash table
nftables: Convert
point to a single entry which would lead in obscure
reverse chaining behaviour.
Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
[0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
Signed-off-by: Thomas Graf
---
include/linux/rhashtable.h | 213
] ovs_flow_extract
4.06% kpktgend_0 [kernel.kallsyms] [k] _raw_spin_lock
3.90% kpktgend_0 [kernel.kallsyms] [k] jhash2
[...]
0.67% kpktgend_0 [kernel.kallsyms] [k] netlink_lookup
Signed-off-by: Thomas Graf
---
net/netlink/af_netlink.c | 285
On 07/31/14 at 10:46pm, David Miller wrote:
> From: David Miller
> Date: Thu, 31 Jul 2014 22:39:46 -0700 (PDT)
>
> > Looks great, series applied, thanks!
>
> Actually, this needs more work, reverted:
>
> net/netfilter/nft_hash.c: In function ‘nft_hash_destroy’:
> net/netfilter/nft_hash.c:183:3:
rhashtable_insert() return void
- nl_sk_hash_lock must be a mutex
- fixed wrong name of rht_shrink_below_30()
- exported symbols rht_grow_above_75() and rht_shrink_below_30()
- allow table freeing with RCU callback
Thomas Graf (3):
lib: Resizable, Scalable, Concurrent Hash Table
netlink
] ovs_flow_extract
4.06% kpktgend_0 [kernel.kallsyms] [k] _raw_spin_lock
3.90% kpktgend_0 [kernel.kallsyms] [k] jhash2
[...]
0.67% kpktgend_0 [kernel.kallsyms] [k] netlink_lookup
Signed-off-by: Thomas Graf
---
net/netlink/af_netlink.c | 285
point to a single entry which would lead in obscure
reverse chaining behaviour.
Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
[0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
Signed-off-by: Thomas Graf
---
include/linux/rhashtable.h | 213
On 08/01/14 at 12:26pm, Patrick McHardy wrote:
> On Fri, Aug 01, 2014 at 10:51:58AM +0200, Thomas Graf wrote:
> > --- /dev/null
> > +++ b/include/linux/rhashtable.h
> > @@ -0,0 +1,213 @@
> > +/*
> > + * Resizable, Scalable, Concurrent Hash Table
> > + *
On 08/01/14 at 12:01pm, Nikolay Aleksandrov wrote:
> I see that ht->shift is being set but then ht is being zeroed, wouldn't this
> allow for the table to double ilog2(tbl->size) times more ?
Absolutely, thanks for catching this!
___
dev mailing list
dev
On 08/01/14 at 11:17am, Patrick McHardy wrote:
> On 1. August 2014 09:52:00 GMT+01:00, Thomas Graf wrote:
> >If the set size is known in advance, the table is sized accordingly,
> >otherwise the table size will default to 64. This is a slight change
> >in behaviour as previou
point to a single entry which would lead in obscure
reverse chaining behaviour.
Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
[0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
Signed-off-by: Thomas Graf
---
include/linux/rhashtable.h | 213
] ovs_flow_extract
4.06% kpktgend_0 [kernel.kallsyms] [k] _raw_spin_lock
3.90% kpktgend_0 [kernel.kallsyms] [k] jhash2
[...]
0.67% kpktgend_0 [kernel.kallsyms] [k] netlink_lookup
Signed-off-by: Thomas Graf
---
net/netlink/af_netlink.c | 285
() return void
- nl_sk_hash_lock must be a mutex
- fixed wrong name of rht_shrink_below_30()
- exported symbols rht_grow_above_75() and rht_shrink_below_30()
- allow table freeing with RCU callback
Thomas Graf (3):
lib: Resizable, Scalable, Concurrent Hash Table
netlink: Convert netlink_lookup
On 08/01/14 at 02:21pm, Nikolay Aleksandrov wrote:
> Sorry for the late response but I just got around to check the 3rd patch now,
> so my question about this fragment is: before nft_hash_remove() would free the
> element after removal, but after this change I don't see where and when the
> removed
On 08/01/14 at 03:12pm, Patrick McHardy wrote:
> On 1. August 2014 14:49:01 GMT+01:00, Thomas Graf wrote:
> >On 08/01/14 at 02:21pm, Nikolay Aleksandrov wrote:
> >> Sorry for the late response but I just got around to check the 3rd
> >patch now,
> >> so my questi
On 08/01/14 at 04:51pm, Nikolay Aleksandrov wrote:
> Hmm, in both the rhashtable_insert() and rhashtable_remove() calls in the
> netlink code you're using GFP_ATOMIC flags but if rhashtable_expand/shring
> gets
> called even though the allocation will be with GFP_ATOMIC, they still call
> synchron
rht_grow_above_75() and rht_shrink_below_30()
- allow table freeing with RCU callback
Thomas Graf (3):
lib: Resizable, Scalable, Concurrent Hash Table
netlink: Convert netlink_lookup() to use RCU protected hash table
nftables: Convert nft_hash to use generic rhashtable
include/linux/rhashtable.h
% kpktgend_0 [kernel.kallsyms] [k] netlink_lookup
Signed-off-by: Thomas Graf
---
net/netlink/af_netlink.c | 285 ++-
net/netlink/af_netlink.h | 18 +--
net/netlink/diag.c | 11 +-
3 files changed, 119 insertions(+), 195 deletions(-)
diff
point to a single entry which would lead in obscure
reverse chaining behaviour.
Code includes a boot selftest if CONFIG_TEST_RHASHTABLE is defined.
[0] https://www.usenix.org/legacy/event/atc11/tech/final_files/Triplett.pdf
Signed-off-by: Thomas Graf
---
include/linux/rhashtable.h | 213
This makes the following work:
add-group br0 group_id=1234,type=all, \
bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
bucket=output:11
add-flow br0 ip actions=load:0x->NXM_NX_REG1[],group:1234
Signed-off-by: Thomas Graf
---
l
On 08/13/14 at 09:56am, Ben Pfaff wrote:
> On Wed, Aug 13, 2014 at 03:34:27PM +0200, Thomas Graf wrote:
> > This makes the following work:
> > add-group br0 group_id=1234,type=all, \
> > bucket=output:10,move:NXM_NX_REG1[]->NXM_OF_IP_SRC[], \
> >
On 08/14/14 at 10:40am, Thomas Graf wrote:
> On 08/13/14 at 09:56am, Ben Pfaff wrote:
> > On Wed, Aug 13, 2014 at 03:34:27PM +0200, Thomas Graf wrote:
> > > This makes the following work:
> > > add-group br0 group_id=1234,type=all, \
> > >
On 08/14/14 at 09:22am, Ben Pfaff wrote:
> The real issue here is that you'd like to allow OFPACT_REG_MOVE to be
> part of an action set. That's fine. I have no objection. The only
> task is to decide where reg_move actions go in the ordering. Where do
> you want it? I get the impression that
NXM_OF_IP_SRC[], \
bucket=output:11
add-flow br0 ip actions=load:0x->NXM_NX_REG1[],group:1234
Signed-off-by: Thomas Graf
---
lib/ofp-actions.c | 2 +-
tests/ofproto-dpif.at | 13 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/lib/ofp
On 08/14/14 at 12:43pm, Ben Pfaff wrote:
> On Thu, Aug 14, 2014 at 09:42:13PM +0200, Thomas Graf wrote:
> > On 08/14/14 at 09:22am, Ben Pfaff wrote:
> > > The real issue here is that you'd like to allow OFPACT_REG_MOVE to be
> > > part of an action set. That&#x
NXM_OF_IP_SRC[], \
bucket=output:11
add-flow br0 ip actions=load:0x->NXM_NX_REG1[],group:1234
Signed-off-by: Thomas Graf
---
v1->v2:
* Renamed ofpact_is_set_action to opfact_is_set_or_move_action() and
updated comment.
* Updated ovs-ofctl(8) to reflect ne
On 08/21/14 at 06:19pm, Jiri Pirko wrote:
> This patch introduces the first driver to benefit from the switchdev
> infrastructure and to implement newly introduced switch ndos. This is a
> driver for emulated switch chip implemented in qemu:
> https://github.com/sfeldma/qemu-rocker/
The design loo
On 08/23/14 at 11:24am, Jiri Pirko wrote:
> Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wrote:
> >
> >On Aug 22, 2014, at 12:39 PM, John Fastabend
> >wrote:
> >> - this requires OVS to be loaded to work. If all I want is
> >> direct access to the hardware flow tables requi
On 08/23/14 at 09:53pm, Jamal Hadi Salim wrote:
> On 08/22/14 18:53, Scott Feldman wrote:
>
> Ok, Scott - now i have looked at the patches on the plane and i am
> still not convinced ;->
>
> >The intent is to use openvswitch.ko’s struct sw_flow to program hardware via
> >the
> >ndo_swdev_flow_*
On 08/23/14 at 10:09am, John Fastabend wrote:
> Right. I think this is basically what Jiri and I discussed when he
> originally posted the series. For my use cases this is one of the
> more interesting pieces. If no one else is looking at it I can try
> it on some of the already existing open sourc
On 08/21/14 at 06:18pm, Jiri Pirko wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 39294b9..8b5d14c 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -49,6 +49,8 @@
>
> #include
> #include
> +#include
> +
> #include
>
> s
level.
Build failures are reported to the author and commiter by email,
through the travis-ci web UI, and in the github pull request.
A full build report example can be found here [1]
[0] http://travis-ci.org/
[1] https://travis-ci.org/tgraf/ovs/builds/33485228
Signed-off-by: Thomas Graf
On 08/25/14 at 02:51pm, Thomas Graf wrote:
> This enables the use of travis-ci via github. Linking any ovs
> github repo to travis-ci [0] will automatically lead to a build
> and testsuite run being triggered for each new commit or pull
> requests against the repo.
Given the a
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
> On 08/24/14 22:42, John Fastabend wrote:
>
> >In the L2 case we already have the fdb_add and fdb_del semantics that
> >are being used today by NICs with embedded switches. And we have a DSA
> >patch we could dig out of patchwork for those drivers.
On 08/24/14 at 11:15am, Jamal Hadi Salim wrote:
> The focus of the patches is on offloading flows (uses the
> ovs or shall i say the broadcom OF-DPA API, which is one
> vendor's view of the world).
Let's keep vendors out of this discussion. I have no affiliation
with this vendor. In fact I'm perso
On 08/25/14 at 08:50am, Ben Pfaff wrote:
> This sounds great. Applied.
Thanks
> Is there a way to get emailed build success/failure reports?
Yes:
1. You can connect the main ovs git repo to travis-ci. This will
result in a email to both the author and commiter if a new
commit to any bran
On 08/25/14 at 09:01am, Ben Pfaff wrote:
> On Mon, Aug 25, 2014 at 05:58:09PM +0200, Thomas Graf wrote:
> > On 08/25/14 at 08:50am, Ben Pfaff wrote:
> > > Is there a way to get emailed build success/failure reports?
> >
> > Yes:
> >
> > 1. You can connec
First of all, thanks for the animated discussion, wouldn't
want to miss our arguments ;-)
On 08/25/14 at 12:48pm, Jamal Hadi Salim wrote:
> On 08/25/14 10:54, Thomas Graf wrote:
> >On 08/24/14 at 11:15am, Jamal Hadi Salim wrote:
>
> >Let's keep vendors out of this
On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
> On 08/25/14 10:17, Thomas Graf wrote:
> >On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
>
> >fdb_add() *is* flow based. At least in my understanding, the whole
> >point here is to extend the idea of fdb_add() and make it
tun_key_to_attr() accesses tp_src and tp_dst which are currently
uinitialized.
Signed-off-by: Thomas Graf
---
lib/odp-util.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index ffc3673..19d0627 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1784,6
The branch is unused as size < sizeof dst->inline_values must
always be true for inlined values. Hitting the branch would lead
to corruption as inline_values is accessed out of bounds.
Remove branch and add assertion.
Cc: Jarno Rajahalme
Signed-off-by: Thomas Graf
---
lib/flow
On 08/25/14 at 08:10pm, Jesse Gross wrote:
> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
> wrote:
> > instead of:
> >
> > set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
> >
> > we could have:
> >
> > set(ipv4(proto=6))
>
> Yes, that's wh
The branch is unused as size < sizeof dst->inline_values must
always be true for inlined values. Hitting the branch would lead
to corruption as inline_values is accessed out of bounds.
Remove branch and add assertion.
Cc: Jarno Rajahalme
Signed-off-by: Thomas Graf
---
v2: fixed assertion
nodes is allocated through shash_sort() but never freed.
Signed-off-by: Thomas Graf
---
lib/json.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/json.c b/lib/json.c
index 167c40c..9c819d7 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -461,6 +461,7 @@ json_hash_object(const struct shash
Causes the build script to fail if any command inside the
script returns nonzero.
Signed-off-by: Thomas Graf
---
.travis/build.sh | 43 ---
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/.travis/build.sh b/.travis/build.sh
index e9bb9e2
On 08/25/14 at 06:13pm, Thomas Graf wrote:
> I'll work out the travis.yml details, looks like extending it
> with something like below should do:
>
> notifications:
> email:
> recipients:
> - $BUILD_CI_LIST
>
> Can you setup a mailing list for the repo
On 08/26/14 at 10:00am, Jamal Hadi Salim wrote:
> >I would argue that swflow is a superset of a Netlink route. It
> >may infact be very useful to extend the API with something that
> >understands the Netlink representation of a route and have the
> >API translate that to a classifier that can be of
On 08/26/14 at 11:54am, Andy Gospodarek wrote:
> It is easy to *say* it could be added later, but connecting to software
> forwarding in the kernel outside of OVS (which is important to some)
> would take significant effort since this set only connects switch
> hardware to OVS.
Can you explain why
On 08/26/14 at 09:15am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> > Causes the build script to fail if any command inside the
> > script returns nonzero.
> >
> > Signed-off-by: Thomas Graf
>
> We don't seem to have th
Current unconditional call may result in NULL being passed to
nl_msg_put_u32().
Cc: Andy Zhou
Signed-off-by: Thomas Graf
---
lib/odp-util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 19d0627..8a96068 100644
--- a/lib/odp-util.c
Signed-off-by: Thomas Graf
---
lib/dpif-netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 7401293..c7a1242 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -669,6 +669,8 @@ do_add_port(struct dp_netdev *dp, const char *devname
On 08/26/14 at 01:13pm, Alexei Starovoitov wrote:
> I think it's important distinction. In-kernel OVS is not OF.
> It's a networking function that has hard-coded packet parser,
> N-tuple match and programmable actions.
> There were times when HW vendors were using OF check-box
> to sell more chips,
On 08/26/14 at 11:28am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> > Signed-off-by: Thomas Graf
> > ---
> > lib/dpif-netdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/dpif-netdev.c b/lib/d
On 08/26/14 at 12:02pm, Jarno Rajahalme wrote:
> Miniflows can also be dynamically allocated to have more inline space than
> the default amount. classifier.c makes use of that, but it never calls
> miniflow_move (even indirectly) so you are not getting an assert fail. The
> motivation for right
Although the check is present already, a missing !error branch
in the next condition prevents the error from being reported back.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 6314757..2be131d
27;map' resides.
>
> Suggested-by: Ben Pfaff
> Signed-off-by: Jarno Rajahalme
This explains it perfectly, thanks so much!
Reviewed-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
An error returned from ovsdb_row_from_json() currently results in
leaking of row.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 7a1db0c..6314757 100644
--- a/ovsdb/execution.c
+++ b/ovsdb
On 08/26/14 at 06:00pm, Madhu Challa wrote:
> call odp_execute_actions__ only if there are any subactions to prevent null
> pointer dereference in nl_attr_get().
>
> Signed-off-by: Madhu Challa
> ---
> lib/odp-execute.c |3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/odp-exec
On 08/26/14 at 03:23pm, Junguk Cho wrote:
> What I thought is to generally use metadata as matching rule in datapath.
> It is not just between tables.
You may be looking for the 'mark' field of the flow. It is known in
the datapath and used across different Linux kernel subsystems.
___
On 08/27/14 at 07:48am, Ben Pfaff wrote:
> Are you sure? I think that the only real bug here is that if the
> timeout is negative *and* the "until" string is invalid, then there's a
> memory leak of the error message for the negative timeout. We should
> still fix that, and the same code change d
Although the check for negative timeout is present, the error string
is overwritten if an invalid "until" is found right after. This leaks
an error string and results in not reporting the negative timeout back
to the user even though it is encountered first.
Signed-off-by: Thomas Gr
Describe the steps required to setup use of travis-ci for any
GitHub ovs repository.
Signed-off-by: Thomas Graf
---
INSTALL | 43 +++
1 file changed, 43 insertions(+)
diff --git a/INSTALL b/INSTALL
index 7e0097b..15e93c5 100644
--- a/INSTALL
+++ b
tc_fill_rate() takes a 64bit int, casting kbits_rate from int
to uint64_t avoids a possible overflow when translating from
kbits to bytes.
Signed-off-by: Thomas Graf
---
lib/netdev-linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev
Without the explicit wide type, the shift operation may be performed
on a int which will result in implementation defined behaviour on a
system with more than 32 CPUs.
Signed-off-by: Thomas Graf
---
lib/ovs-thread.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ovs
On 08/29/14 at 10:39am, Ben Pfaff wrote:
> CC: Thomas Graf
> Signed-off-by: Ben Pfaff
> ---
> INSTALL |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/INSTALL b/INSTALL
> index 15e93c5..7f670dd 100644
> --- a/INSTALL
> +++ b/INSTALL
>
Enable build notifications to bu...@openvswitch.org
Co-authored-by: Ben Pfaff
Signed-off-by: Thomas Graf
---
v2: Add secure token as email recipient
Ben: I can't really test this change without commit access to the main
repo. If you want to test this before committing, push this com
On 08/29/14 at 01:53pm, Ben Pfaff wrote:
> On Fri, Aug 29, 2014 at 01:27:49PM -0700, Ben Pfaff wrote:
> > On Fri, Aug 29, 2014 at 07:56:26PM +0200, Thomas Graf wrote:
> > > Enable build notifications to bu...@openvswitch.org
> > >
> > > Co-authored-by: Ben Pfa
make distcheck runs a superset of make check and will additionally
catch failures in adding new files to the Makefile. It will also test
installation and uninstallation of the package.
Signed-off-by: Thomas Graf
---
.travis/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 09/01/14 at 11:38am, loy wolfe wrote:
> Hi,
>
> I see in the doc[1] that there is pkt_mark field, but I didn't find any
> description in the ofctl manual. So, can I match against this field, and
> set it in the action?
pkt_mark seems covered in ovs-ofctl(8):
pkt_mark=value[/mask]
On 09/01/14 at 05:10pm, Simon Horman wrote:
> We are left with two questions for you:
>
> 1. Would you look at a proposal (I have some rough code that even works)
>for a select group action in the datapath prior to the finalisation
>of the question of offloads infrastructure in the kernel?
Signed-off-by: Thomas Graf
---
CONTRIBUTING | 6 ++
NEWS | 3 +++
2 files changed, 9 insertions(+)
diff --git a/CONTRIBUTING b/CONTRIBUTING
index f4d2c97..dfbb171 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -41,6 +41,12 @@ Testing is also important:
- A patch that
Signed-off-by: Thomas Graf
---
utilities/ovs-vsctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 37d8b3c..2cd389b 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -3529,11 +3529,11 @@ cmd_remove(struct
Signed-off-by: Thomas Graf
---
tests/test-stp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-stp.c b/tests/test-stp.c
index 9ca9c6c..c4e5933 100644
--- a/tests/test-stp.c
+++ b/tests/test-stp.c
@@ -666,6 +666,7 @@ test_stp_main(int argc, char *argv[])
free(bridge
Signed-off-by: Thomas Graf
---
tests/test-bitmap.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
index b1274e3..3644419 100644
--- a/tests/test-bitmap.c
+++ b/tests/test-bitmap.c
@@ -56,6 +56,9 @@ test_bitmap_equal(void)
assert
On 09/02/14 at 08:35am, Ben Pfaff wrote:
> Reported-by: Thomas Graf
> Signed-off-by: Ben Pfaff
Good catch
Acked-by: Thomas Graf
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 09/03/14 at 11:24am, Jiri Pirko wrote:
> This patchset can be divided into 3 main sections:
> - introduce switchdev api for implementing switch drivers
> - add hardware acceleration bits into openvswitch datapath, This uses
> previously mentioned switchdev api
> - introduce rocker switch drive
On 09/09/14 at 03:17pm, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> I didn't test the fix. If it works "netdev-dpdk.o" should appear in the travis
> output (on master it doesn't)
>
> Thanks,
>
> Daniele
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1
On 09/09/14 at 10:45pm, Daniele Di Proietto wrote:
> I¹ll try to figure out what¹s wrong an post another patch.
Daniele,
I have a patchset to properly enable the DPDK build, fix CFLAGS
and disable some errors to make -Werror work. The only thing left
is resolving this linker error:
/bin/bash ./l
ild/lib lib/.libs/libopenvswitch.a -lssl -lcrypto -lintel_dpdk
-lpthread -lrt -lm
./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlopen'
./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlerror'
Thomas Graf (2):
build: Respect CFLAGS and LDFLAGS pas
: Thomas Graf
---
Makefile.am | 2 ++
acinclude.m4 | 8 +++-
configure.ac | 2 ++
m4/openvswitch.m4 | 4 ++--
4 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 161936d..4c48e73 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -11,6 +11,7
have to disable
bad-function-cast warnings as being treated as errors for now.
Signed-off-by: Thomas Graf
Co-authored-by: Daniele Di Proietto
---
.travis.yml | 2 +-
.travis/build.sh | 15 +++
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/.travis.yml b/.t
On 09/10/14 at 04:22pm, Daniele Di Proietto wrote:
> That’s great,
>
> I see that -Wl,--whole-archive -Wl,-ldl -Wl,--no-whole-archive is used
> when building ovs_client. That should not happen on master
> (-Wl,--whole-archive is used only when we need to link all the pmd
> drivers, i.e. when linki
On 09/10/14 at 10:33pm, Thomas Graf wrote:
> ./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlopen'
> ./dpdk-1.7.0/build/lib/libintel_dpdk.so: undefined reference to `dlerror'
Corresponding failing build:
https://travis-ci.org/tgraf/o
On 09/11/14 at 05:57pm, Daniele Di Proietto wrote:
> In case my main client screws up the code, you can find the commit here
>
> https://github.com/ddiproietto/ovs/commit/6e3523f3bcc74b2af9df221073b45026f
> 9757b15
>
> The corresponding travis build is:
>
> https://travis-ci.org/ddiproietto/ovs/
s://travis-ci.org/tgraf/ovs/builds/35048990
Thomas Graf (2):
build: Respect CFLAGS and LDFLAGS passed to make
travis: Fix DPDK build and treat bad-function-cast warning as
non-error
.travis.yml | 2 +-
.travis/build.sh | 14 ++
Makefile.am | 2 ++
acinclude.m4
://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html
Signed-off-by: Thomas Graf
---
Makefile.am | 2 ++
acinclude.m4 | 8 +++-
configure.ac | 2 ++
m4/openvswitch.m4 | 4 ++--
4 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b
only slows down the build.
Due to incorrect casts in the DPDK headers, we have to disable
bad-function-cast and cast-align warnings as being treated as errors
for now.
Signed-off-by: Thomas Graf
Co-authored-by: Daniele Di Proietto
---
.travis.yml | 2 +-
.travis/build.sh | 14
On 09/09/14 at 02:09pm, Alexei Starovoitov wrote:
> On Mon, Sep 08, 2014 at 02:54:13PM +0100, Thomas Graf wrote:
> > [0]
> > https://docs.google.com/document/d/195waUliu7G5YYVuXHmLmHgJ38DFSte321WPq0oaFhyU/edit?usp=sharing
> > (Publicly accessible and open for comments)
>
Port datapath to work with kernrels up to 3.17 and use 3.16.2 as
the new kernel for CI testing.
Tested with 3.14, 3.16.2, and net-next (3.17).
Signed-off-by: Thomas Graf
Co-authored-by: Madhu Challa
---
.travis.yml | 2 +-
.travis/build.sh
nd
it and allow specification of conntrack helpers and setting up of
conntrack expectations.
Justin Pettit (1):
RFC: Add support for connection tracking.
Thomas Graf (1):
datapath: Add conntrack zone support
datapath/actions.c| 53 ++
data
From: Justin Pettit
An RFC to get back early feedback on exposing Linux's kernel connection
tracker to OVS. The code has a few rough spots that will be addressed
in the next version:
- Need better interface than setting individual flags for the state.
- Need support for IP frags.
-
Work-in-Progress
Attach conntrack template to packet if a non standard zone setting has
been provided. Conntrack template is stored in action.
---
datapath/actions.c| 12 ++-
datapath/datapath.c | 18 +++--
datapath/flow.h
pace patch series includes test cases (in
> > tests/system-traffic.at) that also serve as example uses.
> >
> > This work extends on a branch by Thomas Graf at
> > https://github.com/tgraf/ovs/tree/nat.
>
> Thomas, I guess there was not signoff in these patches so Jarno doe
utput
ipv6: rt6_info output redirect to tunnel output
mpls: export mpls functions for use by mpls iptunnels
mpls: ip tunnel support
Thomas Graf (12):
ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic
dst: Metadata destinations
arp: Inherit metadata dst when creating ARP req
1 - 100 of 1023 matches
Mail list logo
