Support encoding of EXT-187: flow entry notification extension
(ONF flow monitor) requests.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c| 29 -
ofproto/ofproto.c | 21 +
2 files changed, 41 insertions(+), 9 deletions
Support decoding of EXT-187: flow entry notification extension
(ONF flow monitor) requests.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c | 58 ++
1 file changed, 58 insertions(+)
diff --git a/lib/ofp-util.c b/lib
Test printing of EXT-187: flow entry notification extension
(ONF flow monitor) cancel, paused and resumed messages.
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofp-print.at | 28
1 file changed, 28 insertions(+)
diff --git a/tests/ofp-print.at b
Support encoding of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
This re-uses existing Nicira extension code as other than the header
the wire format is the same.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c | 6 --
1 file changed, 4
EXT-187: flow entry notification extension (ONF flow monitor) is
now supported for OpenFlow1.3.
OpenFlow1.4 flow monitor is also now supported.
Signed-off-by: Simon Horman
---
v2
* First post
---
OPENFLOW-1.1+ | 5 -
1 file changed, 5 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofproto.at | 346 +++
1 file changed, 346 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 4240b98..892ab93 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
.
Signed-off-by: Simon Horman
---
v6
* Rename may_xlate_l3_actions as was_mpls.
The use-cases for this flag have grown over time and
the old name had become misleading.
* Also move was_mpls into struct xlate_ctx.
This allows this state to be accessed when translating the action set.
And
With recirculation in place this should be safe.
Signed-off-by: Simon Horman
---
v2 - v5
* No change
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index cc1f9a0..119677e 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp
-recirculation-v6
Simon Horman (6):
ofproto-dpif: Move RECIRC_RULE_PRIORITY to common header
ofproto-dpif: Add recirc_id field to struct rule_dpif
ofproto-dpif: Add idle_timeout parameter to
ofproto_dpif_add_internal_flow()
ofproto-dpif: MPLS recirculation
ofp-actions: Allow pop_mpls on
recirculation.
Signed-off-by: Simon Horman
--
v6
* Rebase
v5
* No change
v4
* Rebase
v3
* Rebase
* Break back out into separate patch
v2
* Erroneously squashed into "odp-util: Add odp_put_recirc_action() helper"
---
ofproto/bond.c | 2 +-
ofproto/ofproto-d
This is in preparation for using this value
in ofproto-dpif-xlate.c when composing recirculation
actions added as a result of processing (MPLS) actions.
Signed-off-by: Simon Horman
---
v3 - v5
* No change
v2
* First post
---
ofproto/bond.c | 1 -
ofproto/ofproto-dpif.h | 3 +++
2
to be translated.
Signed-off-by: Simon Horman
---
v5
* Rebase
v4
* No change
v3
* Rebase
* Add rule_set_recirc_id()
v2
* No change
---
ofproto/ofproto-dpif.c | 47 +++
ofproto/ofproto-dpif.h | 2 ++
2 files changed, 49 insertions(+)
diff --git a
Add helpers for allowing requests and use them in handle_openflow__().
This is a in preparation for supporting multipart requests
on a per message type basis.
Signed-off-by: Simon Horman
---
lib/ofp-msgs.c| 34 ++
lib/ofp-msgs.h| 2 ++
ofproto/ofproto.c
s://github.com/horms/openvswitch.git devel/multipart-request-v2
Simon Horman (4):
ofp-msg: Add helpers for allowing multipart requests
connmgr: Buffer multipart requests
ofproto: Support multipart flow monitor requests
openflow: Multipart requests are now supported
OPENFLOW-1.1+ | 4 -
Signed-off-by: Simon Horman
---
lib/ofp-msgs.c| 3 +-
ofproto/ofproto.c | 63 +++-
tests/ofproto.at | 122 ++
3 files changed, 167 insertions(+), 21 deletions(-)
diff --git a/lib/ofp-msgs.c b/lib/ofp-msgs.c
request
support to individual message types.
Signed-off-by: Simon Horman
---
v2
* Use ofpmsg_may_buffer_mp_request() to only buffer messages for
which buffering is enabled. Currently there are none.
* Annotate mp_reqs field of struct ofconn with OVS_GUARDED_BY(ofproto_mutex)
* Add locking
Signed-off-by: Simon Horman
---
OPENFLOW-1.1+ | 4
1 file changed, 4 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 4f6ec92..89a6b0d 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -82,10 +82,6 @@ following additional work. (This is based on the change log
at the
end of
: Simon Horman
---
v2.60
* Add missing break statement in do_execute_actions().
Previously there was a fall-through from OVS_ACTION_ATTR_HASH
to OVS_ACTION_ATTR_PUSH_MPLS which is incorrect.
(Thanks to a private tip-off.)
v2.59
* Increase coverage of compatibility code from v3.11 to v3.16
On Wed, Jun 11, 2014 at 10:50:51AM -0700, Ben Pfaff wrote:
> On Fri, May 30, 2014 at 05:14:14PM +0900, Simon Horman wrote:
> > Use OFPRR_GROUP_DELETE as the reason for deleting flows due
> > to the removal of a group that they use.
> >
> > This implementation adds
On Wed, Jun 11, 2014 at 10:53:43AM -0700, Ben Pfaff wrote:
> On Fri, May 30, 2014 at 05:14:47PM +0900, Simon Horman wrote:
> > OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
> > in OF1.3.
> >
> > Regardless of the OF version when flows ar
controllers connected
using OF1.3 map OFPRR_METER_DELETE to OFPRR_DELETE which exists in that
version.
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Handle reason translation in ofputil_encode_flow_removed rather than
connmgr_send_flow_removed
---
lib/ofp-util.c | 11
On Thu, Jun 12, 2014 at 11:38:35AM -0700, Ben Pfaff wrote:
> On Wed, Jun 11, 2014 at 09:28:02AM +0900, Simon Horman wrote:
> > The motivation of this series is to allow some sequences of actions
> > that include MPLS actions to be performed using recirculation.
> > Sequences
On Thu, Jun 12, 2014 at 01:17:21PM -0700, Ben Pfaff wrote:
> On Wed, Jun 11, 2014 at 09:28:06AM +0900, Simon Horman wrote:
> > In some cases an pop MPLS action changes a packet to be a non-mpls packet.
> > In this case subsequent any L3+ actions require access to portions
> >
t
of the change introduced by dd51dae29bccca3 ("ofproto: Move logic for
collecting read-only rules into rule_criteria."). I am assuming that the
implication is that it is no longer necessary.
As a result of this assumption this patch simply initialises the
return value to 0.
Signed-off
On Fri, Jun 13, 2014 at 09:31:47AM +0900, Simon Horman wrote:
> On Thu, Jun 12, 2014 at 01:17:21PM -0700, Ben Pfaff wrote:
> > On Wed, Jun 11, 2014 at 09:28:06AM +0900, Simon Horman wrote:
> > > In some cases an pop MPLS action changes a packet to be a non-mpls packet.
On Thu, Jun 12, 2014 at 02:10:21PM -0700, Ben Pfaff wrote:
> On Fri, Jun 06, 2014 at 07:54:17PM +0900, Simon Horman wrote:
> > The flow monitoring tests includes a perl script to sort
> > multiline messages. Break it out into a separate file
> > so it can be used by ot
On Thu, Jun 12, 2014 at 02:11:18PM -0700, Ben Pfaff wrote:
> On Fri, Jun 06, 2014 at 07:54:18PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> I think that this is inverted too. "!own" turns off the NXFMF_OWN
> bit, which "ovs-ofctl monitor wat
The flow monitoring tests includes a perl script to sort multiline
messages. This commit breaks it out of an individual test so that it can
be used elsewhere.
Signed-off-by: Simon Horman
[b...@nicira.com changed approach from a separate file to a shell function]
Signed-off-by: Ben Pfaff
--
v2
!own
I noticed this while working on support for OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman
v2
* As pointed out by Ben Phaff
- I had the sense of the NXFMF_OWN bit inverted
* Include updates to test
- Needed as bit sense is inverted
* Include !own test
- Previously in a separate
Correct what appears to be erroneous behaviour of flow monitors
by sending full rather than abbreviate updates to the controller
that caused an update if the NXFMF_OWN flag is set.
Simon Horman (2):
ofproto: Break out perl code for sorting multiline messages
ofproto: Honour NXFMF_OWN flag of
a regression introduced by
b20f4073eecd4761 ("ofproto: Do straightforward removal of asynchronous flow
operations.")
Signed-off-by: Simon Horman
---
ofproto/connmgr.c | 8 ++-
ofproto/connmgr.h | 4 +++-
ofproto/ofproto-provider.h | 2 ++
ofproto/ofproto.c
On Fri, Jun 13, 2014 at 11:19:39AM -0700, Ben Pfaff wrote:
> On Tue, Jun 10, 2014 at 07:27:09PM +0900, Simon Horman wrote:
> > This is analogous to ofoperation_has_out_port,
> > operating on a group rather than a port.
> >
> > This is in preparation for adding out_gro
On Fri, Jun 13, 2014 at 10:46:07AM -0700, Ben Pfaff wrote:
> On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote:
> > dd51dae29bccca3 ("ofproto: Move logic for collecting read-only rules into
> > rule_criteria.") modifies modify_flows__ such that the variable er
.
Co-authored-by: Ben Pfaff
Signed-off-by: Ben Pfaff
Signed-off-by: Simon Horman
---
v7
* New approach to determining if recirculation should occur.
- Add ofpact_needs_recirculation_after_mpls() rather than
sprinkling logic throughout do_xlate_actions().
[Ben Pfaff]
* Correct goto_actions
ports
* More tests
To aid review this series and its dependencies are available in git
https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v7
Simon Horman (3):
ofproto-dpif: MPLS recirculation
ofp-actions: Allow pop_mpls on MPLS packets
ofproto-dpif: Add MPLS tests
With recirculation in place this should be safe.
Signed-off-by: Simon Horman
---
v2 - v5
* No change
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index dc74e8a..9849771 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp
et and its dependencies are available in git at
https://github.com/horms/openvswitch.git devel/flow_monitor-v3
Simon Horman (41):
ofproto: Use ofp14_flow_monitor_flags internally
connmgr: Support OFPFMF14_ONLY_OWN
ofp-util: Add command and out_group to struct
ofputil_flow_monitor_req
This is in preparation for supporting OpenFlow1.4 flow monitors
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-parse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index fbbe896..5ad1d62 100644
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should
skip sending updates to other controllers.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman
---
v3
* Rebase
v2
* No change
---
ofproto/connmgr.c | 1 +
1 file changed, 1
Use a list rather than an array to track monitor requests
in handle_flow_monitor_request().
This is in preparation for supporting OpenFlow1.4 flow monitor requests
with delete and modify commands.
Signed-off-by: Simon Horman
---
v2
* No change
---
ofproto/connmgr.c | 2 ++
ofproto/connmgr.h
Break out monitor deletion code into a new function
flow_monitor_delete which is paramatised over the id of
the monitor to delete.
This is in preparation for supporting OpenFlow1.4 flow monitor requests
with delete and modify commands.
Signed-off-by: Simon Horman
---
v2
* No change
Filter updates based on the out_group of a flow monitor.
This is analogous to the existing treatment of out_port.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman
---
v3
* Rework for removal of asynchronous operations
v2
* No change
---
ofproto
This is in preparation for adding out_group support to flow monitors
which is in turn in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman
---
v2
* No change
---
ofproto/connmgr.c | 1 +
ofproto/connmgr.h | 1 +
2 files changed, 2 insertions(+)
diff --git a
Handle modify and delete commands in OpenFlow1.4 flow monitor requests.
These commands are not yet allowed by the decoder which
will be updated by a subsequent patch.
Signed-off-by: Simon Horman
---
v2
* No change
---
ofproto/ofproto.c | 19 +++
1 file changed, 15 insertions
: Simon Horman
---
v3
* Rebase
v2
* No change
---
lib/ofp-parse.c| 16
lib/ofp-print.c| 4 +++-
lib/ofp-util.c | 37 ++---
lib/ofp-util.h | 6 --
ofproto/connmgr.c | 14
e the flow monitor request decoder.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman
---
v3
* Rebase
v2
* No change
---
ofproto/ofproto.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
This is in preparation for supporting OpenFlow flow monitor request
commands other than OFPFMC_ADD.
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-util.c | 2 ++
lib/ofp-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 94ece8f
Signed-off-by: Simon Horman
---
v2
* Use OFPRAW_OFPST14_FLOW_MONITOR_REPLY rather than
OFPRAW_NXST_FLOW_MONITOR_REPLY as a key to differentiate NX and OF
messages. This is consistent with the approach taken for Flow Monitor
Requests and allows the code to be used for EXT-186 flow monitor
This has the effect of exposing an out_group argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-parse.c | 7 +++
1 file changed, 7 inser
This is in preparation for supporting OpenFlow1.4 flow monitor replies.
Signed-off-by: Simon Horman
---
v2
* No change
---
ofproto/connmgr.c | 16 +---
ofproto/connmgr.h | 5 +
ofproto/ofproto.c | 25 +
3 files changed, 35 insertions(+), 11 deletions
At this time the encoding function is always called
with OFP10_VERSION. A subsequent patch will call it
with the prevailing version.
Signed-off-by: Simon Horman
---
v2
* Re-arrange case statement to group unsupported versions with default
---
lib/ofp-util.c| 108
Signed-off-by: Simon Horman
---
v2
* Do not use OF1.4 paused and resumed messages for OF1.1 - OF1.3
---
ofproto/connmgr.c | 12 +++
ofproto/connmgr.h | 8 +---
ofproto/ofproto.c | 60 ++-
3 files changed, 55 insertions(+), 25
Provide and use helper to parse group id.
This in preparation for adding group_out support to the parser
for flow monitor requests. This also requires parsing of a group id.
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-parse.c | 48
This is consists of extending and renaming
existing code for NX flow monitor requests.
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-print.c| 68 +++---
tests/ofp-print.at | 12 ++
2 files changed, 72 insertions(+), 8
checking.
This is in preparation for supporting OpenFlow 1.4 flow monitor replies.
Signed-off-by: Simon Horman
---
v3
* Rebase
v2
* No change
---
lib/ofp-print.c | 14 +--
lib/ofp-util.c| 107 +++---
lib/ofp-util.h| 2 +-
ofproto
Signed-off-by: Simon Horman
---
v2
* Re-arrange case statement to group unsupported versions with default
---
lib/ofp-util.c| 48 ++--
lib/ofp-util.h| 3 ++-
utilities/ovs-ofctl.c | 6 +++---
3 files changed, 51 insertions(+), 6
This is now supported for OpenFlow1.4+.
Signed-off-by: Simon Horman
---
v2
* No change
---
utilities/ovs-ofctl.8.in | 5 +
1 file changed, 5 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index cc811ff..7019fc0 100644
--- a/utilities/ovs-ofctl.8.in
+++ b
This is in preparation for supporting OpenFlow1.4
flow monitor replies.
Signed-off-by: Simon Horman
---
v2
* No change
---
include/openflow/openflow-1.4.h | 77 +
1 file changed, 77 insertions(+)
diff --git a/include/openflow/openflow-1.4.h b/include
This has the effect of exposing an new "!other" argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-parse.c | 3 +++
1 file change
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-util.c | 103 +++--
1 file changed, 92 insertions(+), 11 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 5c05c70..dd0c1ef 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp
Signed-off-by: Simon Horman
---
v2
* No change
---
lib/ofp-util.c | 174 -
1 file changed, 147 insertions(+), 27 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index c2767fb..63f65c9 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp
Update documentation of ofputil_flow_monitor_request to note
that it abstracts onf13_flow_monitor_request as well
as {nx,ofp14}_flow_monitor_request.
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First post
---
include/openflow/openflow-1.3.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/openflow/openflow-1.3.h b
Signed-off-by: Simon Horman
---
v3
* Rebased
v2
* Rebased
* Remove spurious use of diff-flows
* Consistently use a space in "OpenFlow 1.4"
---
tests/ofproto.at | 461 +++
1 file changed, 461 insertions(+)
diff --git a/tests/of
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-msgs.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-msgs.c b/lib/ofp-msgs.c
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-msgs.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/lib/ofp-msgs.c b/lib/ofp-msgs.c
This is now supported for OpenFlow1.4+.
Signed-off-by: Simon Horman
---
v2
* No change
---
utilities/ovs-ofctl.8.in | 7 +++
1 file changed, 7 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 7019fc0..ea31fb9 100644
--- a/utilities/ovs-ofctl.8.in
+++ b
Add raw types for EXT-187: flow entry notification extension
(ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-msgs.h | 53 +
1 file changed, 37 insertions(+), 16 deletions(-)
diff --git a/lib/ofp-msgs.h b/lib
Test printing of EXT-187: flow entry notification extension
(ONF flow monitor) cancel, paused and resumed messages.
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofp-print.at | 28
1 file changed, 28 insertions(+)
diff --git a/tests/ofp-print.at b
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman
---
v2
* First post
---
include/openflow/openflow-1.3.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/openflow/openflow-1.3.h b
Test printing of EXT-187: flow entry notification
(ONF flow monitors) requests.
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofp-print.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index 2fc1e12..f8bc0a5 100644
--- a
Support decoding of EXT-187: flow entry notification extension
(ONF flow monitor) requests.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c | 58 ++
1 file changed, 58 insertions(+)
diff --git a/lib/ofp-util.c b/lib
Support decoding of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
This re-uses existing Nicira extension code as other than the header
the wire format is the same.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c | 3 ++-
1 file changed, 2 insertions
Support encoding of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
This re-uses existing Nicira extension code as other than the header
the wire format is the same.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c | 6 --
1 file changed, 4
Signed-off-by: Simon Horman
---
lib/ofp-msgs.c| 3 +-
ofproto/ofproto.c | 63 +++-
tests/ofproto.at | 122 ++
3 files changed, 167 insertions(+), 21 deletions(-)
diff --git a/lib/ofp-msgs.c b/lib/ofp-msgs.c
EXT-187: flow entry notification extension (ONF flow monitor) is
now supported for OpenFlow1.3.
OpenFlow1.4 flow monitor is also now supported.
Signed-off-by: Simon Horman
---
v3
* Rebase
v2
* First post
---
OPENFLOW-1.1+ | 6 --
1 file changed, 6 deletions(-)
diff --git a/OPENFLOW-1.1
Signed-off-by: Simon Horman
---
OPENFLOW-1.1+ | 4
1 file changed, 4 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 552f83d..51155c2 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -82,10 +82,6 @@ following additional work. (This is based on the change log
at the
end of
Add helpers for allowing requests and use them in handle_openflow__().
This is a in preparation for supporting multipart requests
on a per message type basis.
Signed-off-by: Simon Horman
---
lib/ofp-msgs.c| 34 ++
lib/ofp-msgs.h| 2 ++
ofproto/ofproto.c
Support encoding of EXT-187: flow entry notification extension
(ONF flow monitor) requests.
Signed-off-by: Simon Horman
---
v2
* First post
---
lib/ofp-util.c| 29 -
ofproto/ofproto.c | 21 +
2 files changed, 41 insertions(+), 9 deletions
tions
To aid review this patch-set and its dependencies are available in git at
https://github.com/horms/openvswitch.git devel/multipart-request-v3
Simon Horman (4):
ofp-msg: Add helpers for allowing multipart requests
connmgr: Buffer multipart requests
ofproto: Support multipart flow mo
Test printing of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofp-print.at | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index f8bc0a5..69d52e2
request
support to individual message types.
Signed-off-by: Simon Horman
---
v3
* Rebase
* Correct type of hash parameter to ofmp_req_find,
it should be uint32_t rather than ovs_be32 as the value
is in host byte order.
v2
* Use ofpmsg_may_buffer_mp_request() to only buffer messages for
Signed-off-by: Simon Horman
---
v2
* First post
---
tests/ofproto.at | 345 +++
1 file changed, 345 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index e175e7b..af48809 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
his and
> the EXT-187 series will suffer some delay in review.
> On Jun 15, 2014 7:33 PM, "Simon Horman" wrote:
>
> > This purpose of this patchset is to provide support for multipart requests
> > with more than one part. It does so in three phases:
> >
Hi Jesse,
I think this is getting pretty close.
Is there anything I can do to help edge it over the line?
On Fri, Jun 06, 2014 at 07:28:51PM +0900, Simon Horman wrote:
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set lab
On Tue, Jun 17, 2014 at 11:02:21PM -0700, Jesse Gross wrote:
> I'm currently seeing this compiler error:
>
> CC [M] /home/jesse/openvswitch/datapath/linux/gso.o
> /home/jesse/openvswitch/datapath/linux/gso.c: In function
> ‘tnl_skb_gso_segment’:
> /home/jesse/openvswitch/datapath/linux/gso.c:1
: Simon Horman
---
v2.61
* Rebase
- Update key_attr_size accordingly
* Clean up fallout from increasing coverage of compatibility code
from v3.11 to v3.16
v2.60
* Add missing break statement in do_execute_actions().
Previously there was a fall-through from OVS_ACTION_ATTR_HASH
to
On Mon, Jun 23, 2014 at 02:38:50PM -0700, Ben Pfaff wrote:
> On Sat, Jun 14, 2014 at 08:33:13AM +0900, Simon Horman wrote:
> > Previously the out_port of a flow monitor was
> > checked in ofmonitor_report() using ofoperation_has_out_port().
> >
> > When ofoperation_ha
On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote:
> > In some cases an pop MPLS action changes a packet to be a non-mpls packet.
> > In this case subsequent any L3+ actions require access to portions
> >
it for recirculation for bonding
Key changes between v1 and v2
* Support for: packet_out and patch ports
* More tests
To aid review this series and its dependencies are available in git
https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v8
Simon Horman (3):
ofproto-dpif: M
With recirculation in place this should be safe.
Signed-off-by: Simon Horman
Acked-by: Ben Pfaff
---
v8
* Add Ack from Ben Pfaff
v2 - v7
* No change
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index dc74e8a..9849771
.
Co-authored-by: Ben Pfaff
Signed-off-by: Ben Pfaff
Signed-off-by: Simon Horman
---
v8
* As suggested in Ben Pfaff
- Unconditionally set ctx->exit in compose_recirculate_action()
v7
* New approach to determining if recirculation should occur.
- Add ofpact_needs_recirculation_after_m
On Mon, Jun 23, 2014 at 03:58:28PM -0700, Ben Pfaff wrote:
> On Mon, Jun 23, 2014 at 3:55 PM, Simon Horman wrote:
> > On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote:
> >> On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote:
> >> > In some case
On Mon, Jun 23, 2014 at 03:11:57PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 11:29:21AM +0900, Simon Horman wrote:
> > Use enum ofp14_flow_monitor_flags in place of enum nx_flow_monitor_flags in
> > struct ofputil_flow_monitor_request and struct rule, translating betw
On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
> > Use a list rather than an array to track monitor requests
> > in handle_flow_monitor_request().
> >
> > This is in preparation for supporti
: Simon Horman
---
v2.62
* Rebase
v2.61
* Rebase
- Update key_attr_size accordingly
* Clean up fallout from increasing coverage of compatibility code
from v3.11 to v3.16
v2.60
* Add missing break statement in do_execute_actions().
Previously there was a fall-through from OVS_ACTION_ATTR_HASH
On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote:
> On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman wrote:
> > Allow datapath to recognize and extract MPLS labels into flow keys
> > and execute actions which push, pop, and set labels on packets.
> >
> > B
On Tue, Jun 24, 2014 at 07:50:24AM -0700, Ben Pfaff wrote:
> On Tue, Jun 24, 2014 at 05:22:08PM +0900, Simon Horman wrote:
> > On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
> > > On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
> > > > Use
On Mon, Jun 23, 2014 at 03:16:59PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 11:29:22AM +0900, Simon Horman wrote:
> > If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should
> > skip sending updates to other controllers.
> >
> > This is in
On Mon, Jun 23, 2014 at 05:14:52PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 11:29:30AM +0900, Simon Horman wrote:
> > Handle modify and delete commands in OpenFlow1.4 flow monitor requests.
> > These commands are not yet allowed by the decoder which
> > will be up
401 - 500 of 3227 matches
Mail list logo
