Acked-by: Sairam Venugopal
On 8/31/16, 1:33 PM, "Anand Kumar" wrote:
>Singed-off-by : Anand Kumar
>---
> INSTALL.Windows.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
>index 6b0f5d8..59f3936 1
=4,0x1680100}),flags(df|csum|key))),5,4
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/datapath-windows/ovsext/Actions.c
index 722a2a8..f46309a 100644
--- a/datapath
Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to
include the properties mentioned in MSDN - 'Extension driver MSI packaging
requirements' section -
https://msdn.microsoft.com/windows/hardware/drivers/network/extension-driver-msi-packaging-requirements
Signed-off-
>LGTM. One quick question:
>
>> +
>Is this because we are using NDIS 6.30? Otherwise, we should keep it
>closer to the OVS version.
>
>
>Acked-by: Nithin Raju
>
>-- Nithin
>
>
>
>-----Original Message-
>From: dev on behalf of Sairam Venugopal
&
Fix an issue with the OvsReadEventCmdHandler when handling conntrack
events. Reverting the previous review comment since the inputBuffer in
this case will be NULL.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
Acked-by: Sairam Venugopal
On 9/11/16, 10:56 PM, "Nithin Raju" wrote:
>Signed-off-by: Nithin Raju
>---
> datapath-windows/CodingStyle | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/datapath-windows/CodingStyle b/datapath-windows/CodingStyle
>index
Fix an issue with the OvsReadEventCmdHandler when handling conntrack
events. Driver initiated messages should have zero seq number.
Reverting the previous review comment since the inputBuffer in
this case will be NULL.
Signed-off-by: Sairam Venugopal
Acked-by: Nithin Raju
---
datapath-windows
Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to
include the properties mentioned in MSDN - 'Extension driver MSI packaging
requirements' section -
https://msdn.microsoft.com/windows/hardware/drivers/network/extension-driver-msi-packaging-requirements
Signed-off-
Acked-by: Sairam Venugopal
On 9/15/16, 5:46 PM, "Shashank Ram" wrote:
>Adds a define for the last defined module number.
>
>Signed-off-by: Shashank Ram
>---
> datapath-windows/ovsext/Debug.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>di
Hi Shashank,
Looks like the patch is missing ancestor history. Can you resend this
patch after fixing this?
Thanks,
Sairam
On 9/19/16, 3:24 PM, "Shashank Ram" wrote:
>Adds a define for the last defined module number.
>
>Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c
>Signed-off-by: Shash
Thanks for fixing this.
Acked-by: Sairam Venugopal
On 9/19/16, 4:16 PM, "Shashank Ram" wrote:
>Adds a define for the last defined module number.
>
>Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c
>Signed-off-by: Shashank Ram
>---
> datapath-windows/ovs
Thanks for the patch. Usually we append Œdatapath-windows: Brief
description¹ for Windows datapath commmits.
Had a comment which is inlined.
Thanks,
Sairam
On 10/5/16, 2:33 PM, "Shashank Ram" wrote:
>@Switch.c: Modifies OvsActivateSwitch() function
>to mark the switch as activated only if the
Acked-by: Sairam Venugopal
On 10/10/16, 3:15 PM, "Shashank Ram" wrote:
>@Switch.c: Modifies OvsActivateSwitch() function
>to mark the switch as activated only if the
>the status is success. The callers itself
>only call this method when the isActivated
>flag i
Sorry for the delay in the review.
Acked-by: Sairam Venugopal
On 8/12/16, 6:06 PM, "Alin Serdean"
wrote:
>This patch updates the following commands in the vswitch:
>ovs-vsctl add-br br-test
>ovs-vsctl del-br br-test
>
>ovs-vsctl add-br br-test:
>This command
Acked-by: Sairam Venugopal
On 10/19/16, 1:50 PM, "Daniele Di Proietto" wrote:
>OVS_ALIGNED_VAR(...) should be at the beginning of a definition, as
>the example in include/openvswitch/compiler.h shows.
>
>Fixes: 38ee0814978c ("dpif-netdev: Cache align netdev_flo
Acked-by: Sairam Venugopal
On 10/27/16, 12:20 PM, "Alin Serdean"
wrote:
>Use bitwise comparison when checking flags set by the kernel for the
>device.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> lib/netdev-windows.c | 4 ++--
> 1 file changed, 2 insertions(+),
Acked-by: Sairam Venugopal
On 10/27/16, 11:57 AM, "Alin Serdean"
wrote:
>'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type
>bool.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Conntrack.c | 14 +++
I thought we had set warnings to be treated as error. Appveyor didn¹t
catch this one either. Thanks for fixing this.
Acked-by: Sairam Venugopal
On 10/27/16, 12:20 PM, "Alin Serdean"
wrote:
>ofpbuf_const_initializer takes only two parameters see:
>
>https://urldefense.proo
Add support for tracking ICMP code and Type in the Hyper-V Conntrack
module. This code is similar to the userspace connection tracker.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack-icmp.c | 80 +++
datapath-windows/ovsext/Conntrack-other.c
Guru,
Any reason why the acked-by doesn’t show up on Patchwork -
https://patchwork.ozlabs.org/patch/687913/
Thanks,
Sairam
On 10/27/16, 1:49 PM, "Sairam Venugopal" wrote:
>I thought we had set warnings to be treated as error. Appveyor didn¹t
>catch this one either. Thanks
Acked-by: Sairam Venugopal
On 10/27/16, 11:57 AM, "Alin Serdean"
wrote:
>The purpose of this patch is to make the code more readable and
>fix a static analyzer warning.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Geneve.c | 6 +++---
&g
Acked-by: Sairam Venugopal
On 10/27/16, 11:55 AM, "Alin Serdean"
wrote:
>The purpose of this patch is to make the code more readable and
>fix a static analyzer warning.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Stt.c | 6 +++---
> 1 f
Acked-by: Sairam Venugopal
On 10/27/16, 11:55 AM, "Alin Serdean"
wrote:
>The purpose of this patch is to make the code more readable and
>fix a static analyzer warning.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Gre.c | 6 +++---
> 1 f
Acked-by: Sairam Venugopal
On 10/27/16, 11:53 AM, "Alin Serdean"
wrote:
>The purpose of this patch is to make the code more readable and
>fix a static analyzer warning.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Vxlan.c | 6 +++---
&g
Hi Alin,
We had discussed this over IRC, will you be adding some more example to
the documentation? Mainly around internal devices?
Thanks,
Sairam
On 9/13/16, 11:13 AM, "Alin Serdean"
wrote:
>This patch updates the documentation on how to set up OVS with multiple
>NICs.
>
>Also update the docu
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c| 10 +++---
datapath-windows/ovsext/Flow.c| 17 -
datapath-windows/ovsext/Netlink/Netlink.c | 18 ++
datapath-windows/ovsext/Netlink/Netlink.h | 6 --
datapath
Acked-by: Sairam Venugopal
On 9/3/15, 7:01 AM, "Nithin Raju" wrote:
>OVS_VPORT_ATTR_OPTIONS being an optional attribute should be
>preceded by a check for valid value before access.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Vport.c | 10 ++
Enable support for Checksum offloads in STT if it's enabled in the Windows
VM.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c | 190 ++
1 file changed, 176 insertions(+), 14 deletions(-)
diff --git a/datapath-windows/ovsext/St
Thanks for fixing this. I held off on ACK¹ing it until the original GRE
patch was applied.
Acked-by: Sairam Venugopal
On 12/11/15, 2:24 PM, "Alin Serdean"
wrote:
>Allow GRE encapsulation to take place in the case we have a TCP payload
>without LSO.
>
>Signed-off-by
Thanks for the patch. Just to clarify, I think we still don¹t support IPv6
in OvsTcpSegmentNBL.
Acked-by: Sairam Venugopal
On 12/11/15, 2:29 PM, "Alin Serdean"
wrote:
>This patch adds LSO version 2 support for the windows datapath.
>(https://urldefense.proofpoint.co
Acked-by: Sairam Venugopal
On 1/4/16, 3:04 PM, "Alin Serdean" wrote:
>The warning message was inverted on the performed operation.
>
>Also use the error returned by nl_sock_subscribe_packet__.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> lib/netlink-socket.c |
Acked-by: Sairam Venugopal
On 1/4/16, 3:04 PM, "Alin Serdean" wrote:
>The policy of the subscribe packets is defined by the following:
>const NL_POLICY policy[] = {
>[OVS_NL_ATTR_PACKET_PID] = {.type = NL_A_U32 },
>[OVS_NL_ATTR_PACKET_SUBSCRI
Acked-by: Sairam Venugopal
On 2/10/16, 4:14 PM, "Alin Serdean"
wrote:
>The keylen is not properly updated in the case of MPLS, directly causing
>the
>hash to be calculated improperly.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/DpInte
Acked-by: Sairam Venugopal
On 2/10/16, 6:30 PM, "Alin Serdean"
wrote:
>Visual Studio defines by default the maximum number of concurrent jobs.
>
>This patch allows the parallel built of the solution.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-wi
Minor - can use /m instead.
Acked-by: Sairam Venugopal
On 2/10/16, 7:09 PM, "Alin Serdean"
wrote:
>This patch enables parallel build from the command line.
>
>If vstudio_config is defined change from:
>make ovsext_make to make ovsext and also update the dependecy for
Hey Alin,
The comments are inline.
From: dev on behalf of Alin Serdean
Sent: Friday, September 11, 2015 1:48 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN
inner packets
Windows does not supp
Sorry about the bad indents on my comments. I will re-send the review.
-Sairam
From: dev on behalf of Sairam Venugopal
Sent: Friday, September 11, 2015 4:56 PM
To: Alin Serdean; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows
Hey Alin,
Am taking another stab at this code review. I will prefix my comments with
a ³Sai:² just to be safe.
I had few concerns over checksum calculations when LSO is enabled.
Thanks,
Sairam Venugopal
On 9/11/15, 1:48 AM, "Alin Serdean"
wrote:
>Windows does not support V
Acked-by: Sairam Venugopal
On 9/11/15, 4:09 AM, "Sorin Vinturis"
wrote:
>The internal/external vports will have the actual OS-based names, which
>represent the NIC interface alias that is displayed by running
>'Get-NetAdapter' Hyper-V PS command.
>
-fromentityheader: Hosted
x-originating-ip: [10.113.160.246]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <96312149fa4a1241a02be13f0e693...@pa-exch1.vmware.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
I have added my comment inline.
- Sairam Venugopal
On
Acked-by: Sairam Venugopal
On 9/10/15, 3:09 PM, "Alin Serdean"
wrote:
>If we have a flow rule of the following form:
> actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17
>are
> VXLAN OF ports with different tunnelling information)
>
>Current
Enable support for Checksum offloads in STT if it's enabled in the Windows
VM.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c | 141 +++---
1 file changed, 134 insertions(+), 7 deletions(-)
diff --git a/datapath-windows/ovsext/St
Thanks for clarifying that.
Acked-by: Sairam Venugopal
On 9/14/15, 1:53 PM, "Alin Serdean"
wrote:
>The idea is there are two type of errors:
>- those returned by the system: i.e. the result code that you pointed
>below which gets interpreted by
>(https://urldefense.p
I have added my response underneath.
Thanks,
Sairam Venugopal
On 9/14/15, 2:14 PM, "Alin Serdean"
wrote:
>Thanks for the review Sairam.
>
>I trimmed the message a bit.
>
>See my answers inlined.
>
>> status = OvsAllocateNBLContext(context, newNbl); diff
Hey Sorin,
What happens when the user changes the name manually? Do we plan on
handling that event?
Thanks,
Sairam
On 9/14/15, 7:51 PM, "Alin Serdean"
wrote:
>Please modify also the documentation INSTALL.Windows.md to be inline with
>the modified port names.
>
>
>
>Small nit: you should delete
Enable support for Checksum offloads in STT if it's enabled in the Windows
VM. Set the Checksum Partial and Checksum Verified flags as mentioned in
the STT Draft - https://tools.ietf.org/html/draft-davie-stt-06
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c
Acked-by: Sairam Venugopal
On 9/15/15, 11:52 AM, "Nithin Raju" wrote:
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/User.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
>diff --git a/datapath-windows/ovsext/User.c
>b
Acked-by: Sairam Venugopal
On 9/15/15, 11:52 AM, "Nithin Raju" wrote:
>The kernel datapath returns a NL error message upon any errors
>during read operations, and returns STATUS_SUCCESS as the return
>code. We reply on the input NL request to get the family ID, and the
>
Acked-by: Sairam Venugopal
On 9/15/15, 11:52 AM, "Nithin Raju" wrote:
>Simple code motion.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Datapath.c | 118
>++---
> datapath-
Acked-by: Sairam Venugopal
On 9/15/15, 11:52 AM, "Nithin Raju" wrote:
>Currently, we do busy-polling for packets on Windows. In this patch
>we nuke that code and schedule an event.
>
>The code has been tested for packet reads, and CPU utilization of
>ovs-vswit
Enable support for Checksum offloads in STT if it's enabled in the Windows
VM. Set the Checksum Partial and Checksum Verified flags as mentioned in
the STT Draft - https://tools.ietf.org/html/draft-davie-stt-06
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c
Hey Nithin,
Thanks for reviewing the patch.
Regards,
Sairam
On 9/21/15, 3:02 PM, "Nithin Raju" wrote:
>> On Sep 21, 2015, at 1:32 PM, Sairam Venugopal
>>wrote:
>>
>> Enable support for Checksum offloads in STT if it's enabled in the
>>Windows
Hey Sorin,
Can you update the Install.Windows.md to reflect these changes?
Thanks,
Sairam
On 9/22/15, 8:31 AM, "Sorin Vinturis"
wrote:
>The internal/external vports will have the actual OS-based names, which
>represent the NIC interface alias that is displayed by running
>'Get-NetAdapter' Hyp
Hey Alin,
Thanks for the patch. I just had few minor suggestions. Looks good
otherwise.
Acked-by: Sairam Venugopal
- Sairam
On 9/22/15, 3:09 PM, "Alin Serdean"
wrote:
>Windows does not support VXLAN hardware offloading.
>
>Currently we do not compute IP/TCP/UDP chec
Acked-by: Sairam Venugopal
On 9/22/15, 3:18 PM, "Alin Serdean"
wrote:
>This patch adds the file DpInternal.h to the ovsetx.sln.
>
>Signed-off-by: Alin Gabriel Serdean
>---
>This patch is meant for branch-2.4 as well
>---
> datapath-windows/ovsext/ovsext.vc
Hey Alin,
Thanks for clarifying that.
Sairam
On 9/25/15, 3:07 PM, "Alin Serdean"
wrote:
>Thanks for the review.
>
>Comments inline.
>
>Alin.
>
>> -Mesaj original-
>> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
>> Trimis: Saturd
Acked-by: Sairam Venugopal
On 9/23/15, 5:40 AM, "Sorin Vinturis"
wrote:
>Signed-off-by: Sorin Vinturis
>---
>This patch is for both master and 2.4 branch.
>---
> datapath-windows/ovsext/Actions.c | 20 ++--
> datapath-windows/ovsext/PacketIO.c |
Acked-by: Sairam Venugopal
On 9/23/15, 11:52 AM, "Sorin Vinturis"
wrote:
>Acked-by: Sorin Vinturis
>
>
>
>-Original Message-
>
>From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
>
>Sent: Wednesday, 23 September, 2015 03:46
Acked-by: Sairam Venugopal
On 10/19/15, 3:15 PM, "Nithin Raju" wrote:
>End result is that "mac_in_use" column gets populated in
>OVSDB for internal and external NICs.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Vport.c | 2 +-
> 1
packet
and forward to NDIS.
Sairam Venugopal (3):
datapath-windows: Move OvsAllocateNBLFromBuffer to BufferMgmt
datapath-windows: STT - Add support for TCP Segmentation Offload
datapath-windows: STT - Enable support for TCP Segmentation offloads
datapath-windows/ovsext/Actions.c| 40
Create and initialize the background thread and buffer that
assists in defragmenting and completing a TSO packet.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c| 128 ++-
datapath-windows/ovsext/Stt.h| 33 +-
datapath
Move the functionality around creating an NBL from Buffer to
Buffermanagement. This function will be used for converting the buffer
from user-space to NBL and also by STT - reassembly logic.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/BufferMgmt.c | 46
Add support to STT - Encap and Decap functions to reassemble the packet
fragments. Also add support to offload the packet to NDIS.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 40 ++--
datapath-windows/ovsext/Stt.c | 407 ++
2
Add support to STT - Encap and Decap functions to reassemble the packet
fragments. Also add support to offload the packet to NDIS.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 40 ++--
datapath-windows/ovsext/Stt.c | 398 +-
2
Create and initialize the background thread and buffer that
assists in defragmenting and completing a TSO packet.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c| 128 ++-
datapath-windows/ovsext/Stt.h| 33 +-
datapath
packet
and forward to NDIS.
Sairam Venugopal (3):
datapath-windows: Move OvsAllocateNBLFromBuffer to BufferMgmt
datapath-windows: STT - Add support for TCP Segmentation Offload
datapath-windows: STT - Enable support for TCP Segmentation offloads
datapath-windows/ovsext/Actions.c| 40
Move the functionality around creating an NBL from Buffer to
Buffermanagement. This function will be used for converting the buffer
from user-space to NBL and also by STT - reassembly logic.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/BufferMgmt.c | 46
Acked-by: Sairam Venugopal
On 10/27/15, 12:50 PM, "Alin Serdean"
wrote:
>This reverts commit a26b2023ce33fed1ef962012dc2c03765d2e92cb.
>
>This patch punishes performance without the implementation of
>megaflows on Windows.
>
>Once megaflows is implemented in the f
Offload the inner checksum computation to NDIS in OvsDecapStt function.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Stt.c | 133 ++
1 file changed, 58 insertions(+), 75 deletions(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath
Alin,
Thanks for the patch.
Acked-by: Sairam Venugopal
On 10/28/15, 11:15 PM, "Alin Serdean"
wrote:
>Report invalid parameter to the userspace if the user tries to add a vport
>tunnel type which is not supported by the kernel extension.
>
>Signed-off-by
This patch fixes an issue with updating the propeties of an external
adapter in Windows. The issue causes flow lookups to fail until the
kernel is reinstalled.
Associated bug - https://github.com/openvswitch/ovs-issues/issues/102
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext
ld probably use the appropriate type.
>
>Looks good otherwise. Thanks for doing this.
>
>Acked-by: Nithin Raju
>
>
>-Original Message-
>From: Sairam Venugopal
>Date: Monday, November 2, 2015 at 5:05 PM
>To: "dev@openvswitch.org"
>Subject: [ov
This patch fixes an issue with updating the propeties of an external
adapter in Windows. The issue causes flow lookups to fail until the
kernel is reinstalled.
Associated bug - https://github.com/openvswitch/ovs-issues/issues/102
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext
Ben,
Thanks for applying this one.
Sairam
On 11/3/15, 12:38 PM, "Ben Pfaff" wrote:
>On Tue, Oct 27, 2015 at 02:36:03PM -0700, Sairam Venugopal wrote:
>> Offload the inner checksum computation to NDIS in OvsDecapStt function.
>>
>> Signed-off-by: Sairam Venugo
Thanks for the patch. This looks much cleaner than before.
Acked-by: Sairam Venugopal
On 11/18/15, 8:13 AM, "Nithin Raju" wrote:
>We already have functions HvCreatePort() and HvCreateNic() to
>do the work. Might as well use that during port enumeration.
>More refactori
Acked-by: Sairam Venugopal
On 11/18/15, 8:13 AM, "Nithin Raju" wrote:
>The workflow being implemented is that, we need to assign a special
>name to the internal and external NICs, and it it not necessary to do
>that from InitHvVportCommon(). The purpose of InitHvVportCom
Acked-by: Sairam Venugopal
On 11/18/15, 8:13 AM, "Nithin Raju" wrote:
>Turns out that we don't need to generate an event is practically
>useful only in case of a port disconnect to let userspace know.
>Hence, this event is being posted from HvDisconnectNic().
Acked-by: Sairam Venugopal
On 11/18/15, 8:13 AM, "Nithin Raju" wrote:
>Port # doesn't make much sense since it has not been computed yet.
>
>Also, get rid of OVS_DEFAULT_PORT_NO and use OVS_DPPORT_NUMBER_INVALID
>instead.
>
>Signed-off-by: Nithin Raju
>---
Acked-by: Sairam Venugopal mailto:vsai...@vmware.com>>
From: "Nithin Raju" mailto:nit...@vmware.com>>
Date: Wed, Nov 18, 2015 at 8:13 AM -0800
Subject: [PATCH 5/6 v2] datapath-windows: cleanup AssignNicNameSpecial()
To: "dev@openvswitch.org<mailto:dev@openvswitch.org
Acked-by: Sairam Venugopal
On 11/18/15, 8:13 AM, "Nithin Raju" wrote:
>If the name of an internal or external NIC changes, we need to
>disconnect the NIC from OVS since the name is the key. In this
>change, we generate a link down event. It is as though we got a
>call to
Thanks for the patch.
Acked-by: Sairam Venugopal
On 11/11/15, 12:11 PM, "Sorin Vinturis"
wrote:
>This patch adds OVS_KEY_ATTR_SCTP to the OVS flow mechanism.
>
>Signed-off-by: Sorin Vinturis
>---
> datapath-windows/ovsext/Flow.c | 6 +-
> da
Hey Sorin,
Were you able to test out the changes? Can you clarify how we can
reproduce it? It will be nice to have documentation around testing this
since it¹s a new feature. I remember you having difficulties with testing
this earlier, hopefully that is now resolved.
I took a look at your change
Thanks for the patch.
Acked-by: Sairam Venugopal
On 11/25/15, 12:32 PM, "Nithin Raju" wrote:
>On Hyper-V, we currently don't validate a flow to see if datapath can
>indeed execute all the actions specified or not. While support for it
>gets implemented, an ASSE
Acked-by: Sairam Venugopal
On 12/2/15, 9:50 AM, "Alin Serdean"
wrote:
>Remove double include for Flow.h and sort the includes alphabetically.
>Also remove tabs.
>
>Found by inspection.
>
>Signed-off-by: Alin Gabriel Serdean
>---
>
Acked-by: Sairam Venugopal
On 12/2/15, 9:50 AM, "Alin Serdean"
wrote:
>This patch adds the sequence tunneling information which will be needed
>for
>GRE tunneling.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Flow.h | 1 +
> 1 fi
Thanks for the patch Alin. I had very minor comments that I have added
inline. Looks good otherwise.
Sairam
On 12/2/15, 9:50 AM, "Alin Serdean"
wrote:
>This patch introduces the support for GRE TEB (trasparent ethernet
>bridging)
>for the windows datapath.
>
>The GRE support is based on
>https:
Acked-by: Sairam Venugopal
On 12/7/15, 3:13 PM, "Nithin Raju" wrote:
>Fixing a little buglet from commit: efee3309.
>
>Signed-by: Nithin Raju
>---
> datapath-windows/ovsext/NetProto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/dat
The previous patch was missing a ;
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/datapath-windows/ovsext/Actions.c
index 7d34458..f6c029b 100644
--- a/datapath
applying this. Are you encountering
something similar?
Thanks,
Sairam Venugopal
On 12/3/15, 1:14 AM, "Sorin Vinturis"
wrote:
>Recirculation support for the OVS extension.
>
>Signed-off-by: Sorin Vinturis
>Reported-by: Sorin Vinturis
>Reported-at:
>https://urldefense.p
-by: Alin Gabriel Serdean
>>
>>> -Mesaj original-
>>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
>>> Trimis: Thursday, December 10, 2015 3:35 AM
>>> Către: Sairam Venugopal ; dev@openvswitch.org
>>> Subiect: Re:
Acked-by: Sairam Venugopal
On 12/11/15, 9:32 AM, "Alin Serdean"
wrote:
>This patch removes unused variables defined in stt and vxlan ports.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Stt.h | 5 -
> datapath-windows/ovsext/Vxlan.h |
201 - 291 of 291 matches
Mail list logo
