Re: [ovs-dev] [PATCH 1/1] Option to toggle "Require successful LACP negotiation when configured"

2013-07-16 Thread Rob Hoes
Hi Ethan, > I really don't want to go down the rabbit hole of retaining optional > backwards compatibility for every little feature we remove just because > there might possibly me some badly configured user who is affected on > upgrade. I'd prefer not to accept this patch until there's a more sp

Re: [ovs-dev] [PATCH 1/1] xenserver: Reduce number of xapi DB calls in plugin

2011-12-06 Thread Rob Hoes
Hi Ben, The get_all_records_where functions are indeed not very well documented, probably because the way to use them is a little awkward. I think we should at some point introduce new APIs to selectively query the database and discourage the use of get_all (because it does not scale). Currentl

[ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Rob Hoes
From: Dominic Curran Fix bug in commit 3249bb907a1dab9b0 Incorrectly assume that get_all_records_where() returned a list. It infact returns a disctionary and the list iteratory needs to change to account for this. Thanks to Nicira for pointing this out. NIC-454. Signed-off-by: Rob Hoes