[ovs-dev] [PATCH] datapath: Fix ovs_vport_cmd_del return value on success

2013-02-08 Thread Rich Lane
If the pointer does not represent an error then the PTR_ERR macro may still return a nonzero value. The fix is the same as in ovs_vport_cmd_set. Signed-off-by: Rich Lane --- datapath/datapath.c |1 + 1 file changed, 1 insertion(+) diff --git a/datapath/datapath.c b/datapath/datapath.c

[ovs-dev] [PATCH] datapath: Fix ovs_vport_cmd_new return value on success

2013-02-08 Thread Rich Lane
This bug was introduced in 1fc7083d (datapath: Remove vport MAC address configuration.) Signed-off-by: Rich Lane --- datapath/datapath.c |1 + 1 file changed, 1 insertion(+) diff --git a/datapath/datapath.c b/datapath/datapath.c index f78c232..87c96ae 100644 --- a/datapath/datapath.c +++ b

[ovs-dev] [PATCH 1/2] datapath: Call genlmsg_end in queue_userspace_packet

2013-02-08 Thread Rich Lane
Without genlmsg_end the upcall message ends (according to nlmsg_len) after the struct ovs_header. Signed-off-by: Rich Lane --- datapath/datapath.c |1 + 1 file changed, 1 insertion(+) diff --git a/datapath/datapath.c b/datapath/datapath.c index 87c96ae..5d18def 100644 --- a/datapath

[ovs-dev] [PATCH 2/2] datapath: Fix parsing invalid LLC/SNAP ethertypes

2013-02-08 Thread Rich Lane
. This patch allows OVS to pass the OFTest pktact.DirectBadLlcPackets. Signed-off-by: Rich Lane --- datapath/flow.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/flow.c b/datapath/flow.c index fad9e19..b14229f 100644 --- a/datapath/flow.c +++ b/datapath

[ovs-dev] [PATCH] flow: Fix parsing invalid LLC/SNAP ethertypes

2013-02-17 Thread Rich Lane
Valid ethertypes start at 1536. Signed-off-by: Rich Lane --- This is the userspace equivalent of "datapath: Fix parsing invalid LLC/SNAP ethertypes". lib/flow.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/flow.c b/lib/flow.c index 5e7d1d4..397b

Re: [ovs-dev] [openflow-dev] [code] OFTest for OVS

2012-10-26 Thread Rich Lane
Hi Ben, Would it be ok if I added dummy.py (as platforms/ovs-dummy.py) to the OFTest repository? In the future I want to support maintaining platform modules separately from OFTest, but the DataPlanePort interface is going to change quite a bit before then. If ovs-dummy.py is versioned with the re

[ovs-dev] [PATCH] support NXAST_SET_TUNNEL_DST action

2012-12-10 Thread Rich Lane
. Signed-off-by: Rich Lane --- I would have liked to put this in under the BSN vendor ID but there isn't any existing support for actions from other vendors. Let me know if you'd like me to add that. I wasn't sure how to populate the tun_flags, ipv4_tos, and ipv4_ttl field

Re: [ovs-dev] [PATCH] Add experimental support for TUNNEL SRC/DST.

2012-12-11 Thread Rich Lane
Tue, Dec 11, 2012 at 10:22 AM, Jesse Gross wrote: > On Tue, Dec 11, 2012 at 10:14 AM, Ben Pfaff wrote: > > On Tue, Dec 11, 2012 at 02:35:37PM +0200, Jarno Rajahalme wrote: > >> Add NXM definitions for tun_src and tun_dst, allowing them to be used in > >> matching and setting them via SetField a

Re: [ovs-dev] [PATCH] support NXAST_SET_TUNNEL_DST action

2012-12-12 Thread Rich Lane
On Mon, Dec 10, 2012 at 6:42 PM, Jesse Gross wrote: > On Mon, Dec 10, 2012 at 5:16 PM, Rich Lane > wrote: > > This action allows the controller to change the destination IP of the > > encapsulating packet. It just exposes the existing Linux datapath > > function