s.
I've tested port addition/deletion, ping via STT tunnel with these
patches.
Nithin Raju (5):
datapath-windows: refactor port enumeration code
datapath-windows: cleanup InitHvVportCommon()
datapath-windows: cleanup events code
datapath-windows: nuke port # argument in IP helper
datap
portCommon() to UpdateSwitchCtxWithVport().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Oid.c | 2 +-
datapath-windows/ovsext/Vport.c | 185 ++--
datapath-windows/ovsext/Vport.h | 3 +-
3 files changed, 104 insertions(+), 86 deletions(-)
di
e GUI and didn't see any callback. Other changes are tested.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 65 ++---
1 file changed, 35 insertions(+), 30 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovse
Port # doesn't make much sense since it has not been computed yet.
Also, get rid of OVS_DEFAULT_PORT_NO and use OVS_DPPORT_NUMBER_INVALID
instead.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c| 2 +-
datapath-windows/ovsext/BufferMgmt.c | 12 +++-
dat
is to trigger userspace to re-add the port
by deleting the port in OVSDB and re-adding it.
With this patch, I have verified that if a VIF gets disconnected on the
Hyper-V switch, it disappears from the OVS kernel DP as well.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c
() has been cleaned up to remove the code to look
for existing vport. We won't have a vport now since we'd have deleted
the vport in HvDeleteNic().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 83 +
1 file changed, 42 inserti
portCommon() to UpdateSwitchCtxWithVport().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Oid.c | 2 +-
datapath-windows/ovsext/Vport.c | 185 ++--
datapath-windows/ovsext/Vport.h | 3 +-
3 files changed, 104 insertions(+), 86 deletions(-)
di
e GUI and didn't see any callback. Other changes are tested.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 62 ++---
1 file changed, 33 insertions(+), 29 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovse
() has been cleaned up to remove the code to look
for existing vport. We won't have a vport now since we'd have deleted
the vport in HvDeleteNic().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 100
datapath-windows/ovsext/Vpo
is to trigger userspace to re-add the port
by deleting the port in OVSDB and re-adding it.
With this patch, I have verified that if a VIF gets disconnected on the
Hyper-V switch, it disappears from the OVS kernel DP as well.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c
We already have functions HvCreatePort() and HvCreateNic() to
do the work. Might as well use that during port enumeration.
More refactoring in later patches.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Switch.c | 6 ++-
datapath-windows/ovsext/Vport.c | 89
Port # doesn't make much sense since it has not been computed yet.
Also, get rid of OVS_DEFAULT_PORT_NO and use OVS_DPPORT_NUMBER_INVALID
instead.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c| 2 +-
datapath-windows/ovsext/BufferMgmt.c | 12 +++-
dat
s.
I've tested port addition/deletion, ping via STT tunnel with these
patches.
Nithin Raju (6):
datapath-windows: refactor port enumeration code
datapath-windows: cleanup InitHvVportCommon()
datapath-windows: cleanup events code
datapath-windows: nuke port # argument in IP helper
datap
is to trigger userspace to re-add the port
by deleting the port in OVSDB and re-adding it.
With this patch, I have verified that if a VIF gets disconnected on the
Hyper-V switch, it disappears from the OVS kernel DP as well.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Ga
s.
I've tested port addition/deletion, ping via STT tunnel with these
patches.
Nithin Raju (6):
datapath-windows: refactor port enumeration code
datapath-windows: cleanup InitHvVportCommon()
datapath-windows: cleanup events code
datapath-windows: nuke port # argument in IP helper
datap
We already have functions HvCreatePort() and HvCreateNic() to
do the work. Might as well use that during port enumeration.
More refactoring in later patches.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Switch.c | 6
() has been cleaned up to remove the code to look
for existing vport. We won't have a vport now since we'd have deleted
the vport in HvDeleteNic().
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vpo
Port # doesn't make much sense since it has not been computed yet.
Also, get rid of OVS_DEFAULT_PORT_NO and use OVS_DPPORT_NUMBER_INVALID
instead.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c| 2 +-
dat
portCommon() to UpdateSwitchCtxWithVport().
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Oid.c | 2 +-
datapath-windows/ovsext/Vport.c | 185 ++--
datapath-windows/ovsext/Vport.h | 3 +
e GUI and didn't see any callback. Other changes are tested.
Signed-off-by: Nithin Raju
Acked-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c | 62 ++---
1 file changed, 33 insertions(+), 29 deletions(-)
di
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h
index 0bbc52b..e5ba72b 100644
--- a/datapath-windows/ovsext/Util.h
+++ b/datapath-windows/ovsext
0;
}
Signed-off-by: Nithin Raju
Acked-by: Russell Bryant
---
datapath-windows/ovsext/Util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h
index 0bbc52b..e5ba72b 100644
--- a/datapath-windows/ovsext/Util.h
+++ b/da
-Original Message-
From: Russell Bryant
Date: Wednesday, November 25, 2015 at 12:07 PM
To: Nithin Raju , "dev@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH] datapath-windows: fix MIN() macro
>On 11/25/2015 03:02 PM, Nithin Raju wrote:
>> Signed-off-by: Nithin Raju
help
debugging.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/datapath-windows/ovsext/Actions.c
index e902983..7d34458 100644
--- a/datapath-windows/ovsext/
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Alin Serdean
Date: Wednesday, December 2, 2015 at 9:50 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c
>Remove double include for Flow.h and sort the includes a
Fixing a little buglet from commit: efee3309.
Signed-by: Nithin Raju
---
datapath-windows/ovsext/NetProto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/NetProto.h
b/datapath-windows/ovsext/NetProto.h
index a364869..c60081a 100644
--- a/datapath
Hi Sorin,
I found some bugs in OvsActionMplsPush(). Can you pls. clarify if my
comments are valid? If they are genuine bugs, did your testing not catch
them? Apologies, if I missed anything.
I¹ll review the rest of the patch after the claritification.
Thanks,
-- Nithin
-Original Message-
Thanks for putting this together. Like we discussed offline, a lot of the
hyper-v values are subject to change in the near future, but the matrix
represents that state of the Hyper-V datapath as of today.
Acked-by: Nithin Raju
-Original Message-
From: Daniele Di Proietto
Date: Monday
That was my patch that broke it. I had fixed it in my local tree but
forgot to send out the updated patch.
Thanks for fixing this.
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Sairam Venugopal
Date: Wednesday, December 9, 2015 at 5:31 PM
To: "dev@openvswitc
Alin,
Thanks for adding GRE support. The patch looks good for the most part.
RFC 2890 calls for a much more elaborate handling of key and sequence
numbers in the GRE header. Eg. Buffering by handling out of order sequence
packets. In your patch, none of that is being done. Also, there¹s no way
to
I suggested we get rid of ŒOVS_TNL_F_SEQ¹ in the 3/3 patch, since there¹s
no way of using it.
-- Nithin
-Original Message-
From: dev on behalf of Alin Serdean
Date: Wednesday, December 2, 2015 at 9:50 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH 1/3] datapath-windows: Add seq
Hi Alin,
I’ve replied to comments where you had a question. Will wait for the v3.
-Original Message-
From: Alin Serdean
Date: Thursday, December 10, 2015 at 9:10 AM
To: Nithin Raju , "dev@openvswitch.org"
Subject: RE: [ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB
s
We needed this ASSERT earlier to catch unexpected cases. This code seems
to be fairly stable, and we can remove the ASSERT.
It is annoying to be hitting this ASSERT while changing the internal
adapter properties.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 1 -
1 file
: Nithin Raju
-Original Message-
From: dev on behalf of Alin Serdean
Date: Friday, December 11, 2015 at 9:16 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH v3] datapath-windows: Add GRE TEB support for
windows datapath
>This patch introduces the support for GRE TE
NHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=qgATPB2
>>q5tLWPAnrCwV4S7eHnzGJ1Tag4LKQBww9p58&s=AeWECN8AUGak_cPmZerCQxWCexqqOjDOcD
>>_pVXsvnTU&e= )
>> > (ICMP, TCP, UDP) with various packet lengths
>> > IPERF3
>> >
>>(htt
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Alin Serdean
Date: Friday, December 11, 2015 at 12:54 PM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH] datapath-windows: Fix small bug in STT
>Allow STT encapsulation to take place in the case
901 - 936 of 936 matches
Mail list logo
