Ben,
Signed off says:
>> Signed-off-by: Lucian Petrut
I don't know what:
>> From: Alin Gabriel Serdean
implies then.
-- Nithin
On Oct 8, 2014, at 10:43 AM, Ben Pfaff
wrote:
> I'm confused. The "From:" at the top of the email indicates you're
> the author. You can't sensibly ack your own
On Oct 8, 2014, at 6:18 AM, Sorin Vinturis
wrote:
> Acked-by: Sorin Vinturis
Sorin,
Thanks for the review.
I sent out a v2 of the patch. Can you pls. review that?
The idea is very similar to the v1 patch, but in addition, I am looking at the
reply to set the transaction->error.
http://patc
On Oct 8, 2014, at 8:43 AM, Ben Pfaff
> I was going to apply this based on Sorin's ack but it gets patch
> rejects:
>
> Applying patch datapath-windows/ovsext/Datapath.c with 2 rejects...
> Rejected hunk #1.
> Patch failed at 0001 datapath-windows: add support for OVS_DP_CMD_NEW netlink
> comman
On Oct 8, 2014, at 8:27 AM, Ben Pfaff
wrote:
> You should specify a return type, e.g. "int".
>
> Thanks,
>
> Ben.
Thanks for the review. Respin (v3) will be up in a bit.
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.
The init function is not allowed to call into the kernel datapath
while running unit tests since the kernel datapath is not loaded.
Instead of making the function dummy, it is better to not have it
at all.
Signed-off-by: Nithin Raju
Reported-by: Gurucharan Shetty
---
lib/netdev-windows.c
which makes the
following sequence of calls:
open_dpif_backer() -> dpif_create_and_open() -> dpif_create()
We also rename HandleDpTransaction() to HandleDpTransactionCommon().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 69 +---
> * --
> * Command Handler for 'OVS_WIN_NETDEV_CMD_GET'.
> @@ -1397,10 +1019,8 @@ OvsGetNetdevCmdHandler(POVS_USER_PARAMS_CONTEXT
> usrParamsCtx,
> NTSTATUS status = STATUS_SUCCESS;
> POVS_MESSAGE msgIn = (POVS_MES
On Oct 8, 2014, at 6:42 PM, Alin Serdean
wrote:
> Hi Nithin,
>
> Yes I will reintroduce it.
>
> I checked there are no compilation issues at the moment.
If the call to OvsGetExtInfoIoctl() has been removed, there's no compilation
issue :)
Will you send a respin of this particular patch, so
On Oct 8, 2014, at 7:03 PM, Alin Serdean
wrote:
> The old IOCTL vport functions (using the non-netlink device) are no
> longer needed. They should be removed.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Alin,
I'll revi
ns are helper functions.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Thanks for addressing the review comments.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ng them, and return STATUS_SUCCESS as the OID result.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
declaration is
> moved from Vport.c to Vport.h, and becomes public.
>
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
make
> a clearer connection between these and the vport field "ovsName" to
> which they revolve around.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
gt; the port numbers to MAXUINT16.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
the hash array of port names.
>
> Signed-off-by: Samuel Ghinet
> Co-authored-by: Alin Gabriel Serdean
Signed-off-by: Nithin Raju
Tested-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> +/* OvsFindVportByHvName: "name" is assumed to be null-terminated */
> +POVS_VPORT_ENTRY
> +OvsFindVportByHvName(POVS_SWITCH_CONTEXT switchContext,
> + PSTR name)
> +{
> +POVS_VPORT_ENTRY vport = NULL;
> +PLIST_ENTRY head, link;
> +SIZE_T length = sizeof(name);
> +
>>> +
>>> +PWSTR wsName = OvsAllocateMemory(wstrSize);
>>> +if (!wsName) {
>>> +vport = NULL;
>>> +goto Cleanup;
>>
>> If we jump to 'Cleanup', and call OvsFreeMemory(wsName) while wsName ==
>> NULL, we'll hit an ASSERT in OvsFreeMemory() that checks for a valid pointer.
>
ot be optional.
s/TODO/XXX
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 9, 2014, at 11:02 PM, Ankur Sharma
wrote:
> In this patch we added the code to handle transactional errors
> in flow commands.
>
> Signed-off-by: Ankur Sharma
Ankur,
Thanks for the fixes.
One general comment is that, you seem to be returning a transactional error
even for ioctl error
On Oct 9, 2014, at 11:02 PM, Ankur Sharma
wrote:
> Added changes to send a reply for FLOW_FUSH case. This is needed
> as with nithin's transaction reply changes we'll need reply for each
> command.
>
> Signed-off-by: Ankur Sharma
Generally, I have not seen the practice of quoting a developer
On Oct 11, 2014, at 12:11 PM, Nithin Raju
wrote:
> On Oct 9, 2014, at 11:02 PM, Ankur Sharma
> wrote:
>
>> Added changes to send a reply for FLOW_FUSH case. This is needed
>> as with nithin's transaction reply changes we'll need reply for each
>> comman
orgot
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 9, 2014, at 11:02 PM, Ankur Sharma
wrote:
> Assert(rc) would always hit for a valid case, hence
> replaced it with error code based check.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Tested-by: Nithin Raju
___
dev
On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote:
> NlBufAt should be called with valid boundary limits (within head and tail).
> Incorrect argument to NlBufAt was leading to assert hit, fixed the same.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Tested-by:
> NL_ERROR_TXTBSY = ((ULONG)-139),
> /*the operation would block */
> NL_ERROR_WOULDBLOCK = ((ULONG)-140),
> +/* parsing failed */
> +NL_ERROR_PARSEFAIL = ((ULONG)-141)
One more thing is, I don't know the basis of the netlink transactional error
numbers that got defined in a p
On Oct 11, 2014, at 3:07 PM, Ankur Sharma
wrote:
> In this patch we added the code to handle transactional errors
> in flow commands.
>
> Signed-off-by: Ankur Sharma
Thanks for incorporating the review comments.
Acked-by: Nithin Raju http://openvswitch.org/mailman/listinfo/dev
In this patch, we fix a bug in the vport delete code. When a vport is
deleted using a netlink command, we need to remove it from the
'ovsNamHashArray' and the 'portNoHashArray' as well. Addition of a vport
adds the port to the lists.
Signed-off-by: Nithin Raju
---
dat
leted - the field hvDeleted was
added to OVS_VPORT_ENTRY to specify if the hyper-v switch port side
was deleted; if the ovs (datapath) port number is invalid, then it
means that the ovs (datapath) side of the port is deleted (or, not
created).
Signed-off-by: Samuel Ghinet
Acked-by: Nithin Raju
Ack
In 'OvsAcquireDatapathRead()' and 'OvsAcquireDatapathWrite()', we seem
to be passing a BOLEAN instead of NDIS_RWL_AT_DISPATCH_LEVEL.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Switch.h |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --gi
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 61fa71d..9dfbf51 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath
vport add commands, but was nevertheless required
to stabilize the code.
Nithin Raju (6):
datapath-windows: Add netlink command: vport new
datapath-windows: Add netlink command vport delete
datapath-windows: remove vport from lists upon deletion
datpath-windows: pass NDIS_RWL_AT_DISPATCH_
Validation:
- With these fixes, we no longer see the freeze during module
uninstallation or when we try to add a new port.
- We are able to add a port called "internal of type internal using:
ovs-dpctl.exe add-if ovs-system internal,type=internal
Signed-off-by: Nithin Raju
---
datapath-wi
port type is vxlan, then the vport pointer is also saved
to switchContext->vxlanVport.
j. Now that the ovs (datapath) port number and the ovs name were set,
the vport can be added to the hash array of vports, hashed on ovs name
and to the hash array of vports hashed by ovs (datapath) port number
On Oct 7, 2014, at 8:01 PM, Eitan Eliahu
wrote:
>
> Hi Nithin,
> Thanks for addressing the transactional error issue.
> Are we sure we want to make another copy for the Reply just for getting the
> transactional error on a different buffer? Can we use the stack buffer only
> if the caller doe
adding don't operate on an nlattr.
> +static __inline NlAttrTotalSize(UINT32 payload)
Can we call this: NlAttrTotalSizeForPayload() or NlAttrTotalSizeForData?
Acked-by: Nithin Raju
-- Ntihin
___
dev mailing list
dev@openvswitch.org
http://o
On Oct 14, 2014, at 1:03 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> I don't have a strong opinion on the names, but I thought we want to keep NL
> utilities names as the Linux datapath.
Now that I am looked at patch 2 of 4, the names you had given are fine. Pls.
rename the input parameter 'payloa
hi Eitan,
Looks good but for some comments I had, mostly minor though.
Acked-by: Nithin Raju
> diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
> index 26cd431..5037b42 100644
> --- a/datapath-windows/ovsext/User.c
> +++ b/datapath-windows/ovsext/User.c
On Oct 10, 2014, at 11:08 AM, Eitan Eliahu wrote:
> Remove hard coded queue is, pass the key rather the tunnel key,
> remove the none NL implementation
LG.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswit
rather than OvsTunKeyAttrSize() including
OvsFlowKeyAttrSize()?
Looks good otherwise.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ovsHdr->dp_ifindex);
> -
> -if (rc == STATUS_SUCCESS) {
> -*replyLen = msgOut->nlMsg.nlmsgLen;
> +/* No trasanctional errors as of now.
> + * If we have something then we need to convert rc to
> + * nlError. */
> +
On Oct 14, 2014, at 8:32 AM, Sorin Vinturis
wrote:
> In the ingress datapath the creation of a missed packet doesn't
> need to be guarded by the dispatchLock. Same for the NBL context
> initialization.
>
> In the OvsInjectPacketThroughActions function extracting flow
> parameters (OvsExtractFlo
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8..50ea2ff 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b
Acked-by: Nithin Raju
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we have made the Flow parsing policies global.
> Pakcet execute handling requires these policies.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
> ---
> datapath-wind
ket now, pointer will just point
> to corresponding offset in input buffer.
>
> OvsExecuteDpIoctl =>
> We only need input buffer now. Hence Changed the function signature.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
>
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
> command handler.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
Th
hi Ankur,
Change looks good but for the comments. I'll wait for the next version to ACK
the change.
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
> command.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliah
Signed-off-by: Samuel Ghinet
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8..076cd1a 100644
--- a/datapath-w
The first of the patch is the rebased version of Samuel Ghinet's
original patch. The second is fixes.
Nithin Raju (2):
datapath-windows: Add netlink command vport set
datapath-windows: Fixes in OvsSetVportCmdHandler()
datapath-windows/ovsext/Datapath.c |
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 40 -
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 40 -
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8
The first of the patch is the rebased version of Samuel Ghinet's
original patch. The second is fixes.
Nithin Raju (2):
datapath-windows: Add netlink command vport set
datapath-windows: Fixes in OvsSetVportCmdHandler()
datapath-windows/ovsext/Datapath.c |
hi Eitan,
I think there are additional changes needed in OvsReadDpIoctl() for checksum
calculation. It might be easier to explain it in a patch:
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index e27bd76..9d15ef9 100644
--- a/datapath-windows/ovsext/User.c
+++ b/da
On Oct 15, 2014, at 3:26 PM, Ankur Sharma wrote:
> In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
> command.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev m
got included in
the patch. Looks good otherwise.
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
set_flag()
and netdev_windows_set_etheraddr(), saying that the functionality is not
implemented/required?
Somoene casually browsing through the code should realize that the
functionality is not required/implemented for Windows.
Looks good otherwise.
Acked-
On Oct 15, 2014, at 4:14 PM, Ankur Sharma
wrote:
> Changes look fine.
> Please remove following comment
> /*XXX: this function is dummy */
>
> Acked-by: Ankur Sharma
Thanks for the review. The 'dummy' comment has been removed in 2/2 patch.
-- Nithin
_
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 42 +++--
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 9a4827a
On Oct 15, 2014, at 5:09 PM, Ben Pfaff
wrote:
>>>
>>> Changes look fine.
>>> Please remove following comment
>>> /*XXX: this function is dummy */
>>>
>>> Acked-by: Ankur Sharma
>>
>> Thanks for the review. The 'dummy' comment has been removed in 2/2 patch.
>
> I don't see where that happen
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c |
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext
On Oct 15, 2014, at 8:33 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> Perhaps, it would be better to have the check for gOvsSwitchContext much
> earlier at the Dispatcher function and avoid this check in
> ValidateNetlinkCmd() and in every handler function as well.
Eitan,
Some of the commands suc
I have gotten to a stage where I can test this now
from vswitchd.
Looks good.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Thursday, October 16, 2014 3:09 PM
> To: Nithin Raju
> Cc: Eitan Eliahu; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: packet miss read NL
> command
>
> OK.
In this patch, we fix a few buglets found during while testing packet
receive functionality.
Nithin Raju (4):
datapath-windows: event read should not fail when no events
datapath-windows: fixes in Flow.c in key parsing
datapath-windows: Fixes in packet created for userspace
lib/netlink
The semantics are read operation are generally to return 0 bytes and
STATUS_SUCCESS when there are no events.
Also, added a fix to assign the PID to the synthetic OVS_MESSAGE formed
for the command validation.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |4
1
In nl_sock_recv__() on Windows, we realloc a new ofpbuf to copy received
data if the caller specified buffer is small. While we do so, we need
reset some of the other stack variables to point to the new ofpbuf.
Other fixes are around using 'error' rather than 'errno'.
A
A couple of miscellaneous fixes in code that creates a packet for
userspace as well as when we copy the packet to memory specified by
userspace.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 43 ---
1 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index f3ee726..fa61262 100644
--- a/datapath-windows
> +
> +nlMsg = (PNL_MSG_HDR)NlBufAt(&nlBuf, 0, 0);
> +nlMsg->nlmsgLen = NlBufSize(&nlBuf);
>
> [ANKUR]: Should we not align the msgLen here.?
Each of the attributes written out to the nlBuf are already aligned. If you
look at the nlAttrLen of each attribute, it is not set to the aligned
> -Original Message-
> From: Ankur Sharma
> Sent: Friday, October 17, 2014 10:05 AM
> To: Nithin Raju; dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 2/4] datapath-windows: fixes in Flow.c in key
> parsing
>
> Hi Nithin,
>
> While reading the ETHERTYPE
> @@ -548,6 +548,8 @@ nl_sock_recv__(struct nl_sock *sock, struct ofpbuf *buf,
> bool wait)
> } else {
> if (retval >= buf->allocated) {
> ofpbuf_reinit(buf, retval);
> +nlmsghdr = ofpbuf_base(buf);
> +nlmsgh
The semantics are read operation are generally to return 0 bytes and
STATUS_SUCCESS when there are no events.
Also, added a fix to assign the PID to the synthetic OVS_MESSAGE formed
for the command validation.
Signed-off-by: Nithin Raju
Acked-by: Nithin Raju
---
datapath-windows/ovsext
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 57 +--
1 files changed, 36 insertions(+), 21 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index f3ee726..bc9ef87 100644
--- a/datapath-windows
In nl_sock_recv__() on Windows, we realloc a new ofpbuf to copy received
data if the caller specified buffer is small. While we do so, we need
reset some of the other stack variables to point to the new ofpbuf.
Other fixes are around using 'error' rather than 'errno'.
Signed
A couple of miscellaneous fixes in code that creates a packet for
userspace as well as when we copy the packet to memory specified by
userspace.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 12 +---
1 files changed, 9 insertions(+), 3
In this series of patches we add support for packet receive in Windows
userspace. With this patch, we can ping between 2 VMs on the same host
on the same OVS bridge.
Nithin Raju (5):
lib/util.c: add ovs_windows_only() cpp macro
datapath-windows: return success when duplicate flow is added
er.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index bc9ef87..14c3072 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-window
It is convenient to have a macro which we can use to wrap Windows
specific code without using the #ifdef _WIN32/#endif combo each time.
Signed-off-by: Nithin Raju
---
lib/util.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/lib/util.h b/lib/util.h
index f171dbf
In this patch, we add support in userspace for packet subscribe API
similar to the join/leave MC group API that is used for port events.
The kernel code has already been commited.
Acked-by: Nithin Raju
---
lib/netlink-socket.c | 59 ++
1 files
We have not yet tested the wakup via pending IRP functionality on
Windows yet. Hence we use poll_immediate_wake().
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index
ux as well.
Signed-off-by: Nithin Raju
---
lib/dpif-netlink.c | 336 ++
lib/netlink-socket.c |5 +-
2 files changed, 288 insertions(+), 53 deletions(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 67c2814..4b4c042 100644
---
On Oct 22, 2014, at 8:58 AM, Ben Pfaff
wrote:
> I'm not sure I'm happy about this.
>
> For the only uses of this macro introduced in this patch series, which
> are assertions on variables that are always present, the code does not
> have to be Windows-only after the preprocessor. One could sim
On Oct 22, 2014, at 9:06 AM, Nithin Raju
wrote:
>
> I'm not sure I'm happy about this.
>
> For the only uses of this macro introduced in this patch series, which
> are assertions on variables that are always present, the code does not
> have to be Windows-only
> I think:
>ovs_assert(!WINDOWS || n_handlers <= 1);
> is probably the way that I would write it. (I guess I was thinking
> backward when I mentioned && earlier.
Sounds good. The '&&' was a little confusing. Thanks for the clarification.
-- Nithin
> struct dpif_handler {
> struct dpif_channel *channels;/* Array of channels for each handler. */
> struct epoll_event *epoll_events;
> int epoll_fd; /* epoll fd that includes channel socks. */
> int n_events; /* Num events returned by epoll_wait(). *
On Oct 22, 2014, at 3:07 PM, Eitan Eliahu
wrote:
>> ovs_assert(index <= VPORT_SOCK_POOL_SIZE);
> index = (index == VPORT_SOCK_POOL_SIZE - 1) ? 0 : index + 1;
>
> I think that index should never be greater than ( VPORT_SOCK_POOL_SIZE - 1)
> if I understand the logic here.
Got it. There's one
as well.
3. Tested with pool size == 2 as well, though in this patch we set the
pool size = 1.
Signed-off-by: Nithin Raju
---
lib/dpif-netlink.c | 348 +++
1 files changed, 293 insertions(+), 55 deletions(-)
diff --git a/lib/dpif-netlink.c
In this patch, we add support in userspace for packet subscribe API
similar to the join/leave MC group API that is used for port events.
The kernel code has already been commited.
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c | 60 ++
lib
On Oct 21, 2014, at 5:24 PM, Ankur Sharma wrote:
> This patch introduces data structure for holding instances hashed by pid.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvs
is better to reset the contents of 'pidLink'.
Use: InitializeListHead(&(instance->pidLink));
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 22, 2014, at 6:30 AM, Sorin Vinturis
wrote:
> [Sorin]
> The lines above searches through the pidHashArray for the requested pid, but
> fails to check the first element of the array.
Did you mean to say, that we don't check the first element in the linked list?
The first element is 'he
On Oct 21, 2014, at 5:24 PM, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
> ---
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 21, 2014, at 5:24 PM, Ankur Sharma wrote:
> Refactored CreateQueue function so that packets are enqueued to correct
> corresponding queue.
>
> Signed-off-by: Ankur Sharma
Looks good mostly. One comment I had was if it was the right thing to use
gOvsControlLock. This can lead to a dead
On Oct 21, 2014, at 5:24 PM, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
In this patch, we add support in userspace for packet subscribe API
similar to the join/leave MC group API that is used for port events.
The kernel code has already been commited.
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c | 62 ++
lib
501 - 600 of 936 matches
Mail list logo
