Re: [ovs-dev] [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table

2014-08-01 Thread Nikolay Aleksandrov
On 08/01/2014 10:51 AM, Thomas Graf wrote: > Generic implementation of a resizable, scalable, concurrent hash table > based on [0]. The implementation supports both, fixed size keys specified > via an offset and length, or arbitrary keys via own hash and compare > functions. > > Lookups are lockle

Re: [ovs-dev] [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable

2014-08-01 Thread Nikolay Aleksandrov
On 08/01/2014 01:58 PM, Thomas Graf wrote: > The sizing of the hash table and the practice of requiring a lookup > to retrieve the pprev to be stored in the element cookie before the > deletion of an entry is left intact. > > Signed-off-by: Thomas Graf > Acked-by: Patrick McHardy > --- <> > @@ -

Re: [ovs-dev] [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-08-01 Thread Nikolay Aleksandrov
On 08/01/2014 01:58 PM, Thomas Graf wrote: > Heavy Netlink users such as Open vSwitch spend a considerable amount of > time in netlink_lookup() due to the read-lock on nl_table_lock. Use of > RCU relieves the lock contention. > > Makes use of the new resizable hash table to avoid locking on the >

Re: [ovs-dev] [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-08-01 Thread Nikolay Aleksandrov
On 08/01/2014 05:15 PM, Thomas Graf wrote: > On 08/01/14 at 04:51pm, Nikolay Aleksandrov wrote: >> Hmm, in both the rhashtable_insert() and rhashtable_remove() calls in the >> netlink code you're using GFP_ATOMIC flags but if rhashtable_expand/shring >> gets >> c

Re: [ovs-dev] [PATCH net-next 1/3] lib: Resizable, Scalable, Concurrent Hash Table

2014-08-02 Thread Nikolay Aleksandrov
> 4 files changed, 1019 insertions(+), 1 deletion(-) > create mode 100644 include/linux/rhashtable.h > create mode 100644 lib/rhashtable.c > Reviewed-by: Nikolay Aleksandrov ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-08-02 Thread Nikolay Aleksandrov
Thomas Graf > --- > net/netlink/af_netlink.c | 285 > ++- > net/netlink/af_netlink.h | 18 +-- > net/netlink/diag.c | 11 +- > 3 files changed, 119 insertions(+), 195 deletions(-) > Reviewed-by: Nikolay Aleksandrov ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable

2014-08-02 Thread Nikolay Aleksandrov
ardy > --- > net/netfilter/nft_hash.c | 291 > +-- > 1 file changed, 55 insertions(+), 236 deletions(-) > Reviewed-by: Nikolay Aleksandrov ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev