Re: [ovs-dev] [PATCH] netdev-dpdk: Use rte_eth_is_valid_port instead of manual check

2016-08-12 Thread Mauricio Vasquez
On 08/12/2016 05:57 PM, Ciara Loftus wrote: Signed-off-by: Ciara Loftus It is a necessary fix, specially if hotplug will be introduced. Acked-by: Mauricio Vásquez B --- lib/netdev-dpdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev

Re: [ovs-dev] Question about other_config : pmd-cpu-mask options

2016-09-08 Thread Mauricio Vasquez
Hi Junguk, On 09/08/2016 05:07 PM, Junguk Cho wrote: Hi, I used OVS with dpdk. When I started ovs, I used this option to pin some cores for ovs. sudo ovs-vsctl --no-wait set Open_vSwitch . other_config:pmd-cpu-mask=0xf000 In my setup, it has two sockets, but with this option, two cores in

Re: [ovs-dev] Setting pmd-cpu-mask in cluster-on-die mode

2016-09-18 Thread Mauricio Vasquez
y creates pmd threads in sockets where there are ports, in the case of physical ports the numa node is defined by where the ports are connected on the server, in the case of dpdkvhostuser ports, it is defined by where memory of the virtio device is allocated. Probably in your case physical

Re: [ovs-dev] Setting pmd-cpu-mask in cluster-on-die mode

2016-09-20 Thread Mauricio Vasquez
Mauricio Vasquez : Hello Jeremias, On 09/18/2016 05:46 PM, Jeremias Blendin wrote: Hi, I set pmd-cpu-mask on a server running its processors in cluster-on-die mode. This means, that the actual cpu topology is shown to the os as shown below. The problem I have is that although OVS is allowed to use

Re: [ovs-dev] Documentation for DPDK-ivshmem library

2016-10-18 Thread Mauricio Vasquez
[5]https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK-ADVANCED.md#52-phy-vm-phy-ivshmem If you have any other questions don't hesitate in writing them here, Mauricio Vasquez. On 10/18/2016 02:43 PM, abhishekb wrote: Hello, I'm a student at IIT Bombay pursuing my Masters, I have

[ovs-dev] [PATCH v4] netdev-dpdk: add hotplug support

2016-05-10 Thread Mauricio Vasquez B
device, it has to be added to a bridge using the add-port command, similarly, before detaching a device it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- v4: - fix typo in commit message - remove unnecessary whitespace change in INSTALL.DPDK.md v3: - create

[ovs-dev] [PATCH v5] netdev-dpdk: add hotplug support

2016-05-13 Thread Mauricio Vasquez B
-detach After the user attaches a new device, it has to be added to a bridge using the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- v5: - use two appctl commands instead of a single one - rebase to

[ovs-dev] [PATCH v6] netdev-dpdk: add hotplug support

2016-05-26 Thread Mauricio Vasquez B
-detach After the user attaches a new device, it has to be added to a bridge using the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B Tested-by: ian.sto...@intel.com --- v6: - add explicit comment about

[ovs-dev] [PATCH] acinclude: fix issue when configuring with --with-dpdk

2016-06-01 Thread Mauricio Vasquez B
or in that case. Signed-off-by: Mauricio Vasquez B --- acinclude.m4 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index f3de855..0a14856 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -161,10 +161,11 @@ dnl Configure DPDK source tree

[ovs-dev] [PATCH v7] netdev-dpdk: add hotplug support

2016-07-15 Thread Mauricio Vasquez B
-detach After the user attaches a new device, it has to be added to a bridge using the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- v7: - rebase to master v6: - add explicit comment about supporting

[ovs-dev] [PATCH 2/2] README: add referente to DPDK installation

2016-07-28 Thread Mauricio Vasquez B
there was not any reference to the DPDK installation in the main README file. Signed-off-by: Mauricio Vasquez B --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 13a132a..cf53437 100644 --- a/README.md +++ b/README.md @@ -94,6 +94,8 @@ To use Open

[ovs-dev] [PATCH 1/2] README: add missing reference to INSTALL.SELinux.md

2016-07-28 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 69c4912..13a132a 100644 --- a/README.md +++ b/README.md @@ -120,6 +120,7 @@ b...@openvswitch.org [INSTALL.KVM.md]:INSTALL.KVM.md [INSTALL.Libvirt.md

[ovs-dev] [PATCH] ovn: make external_ids naming uniform

2016-08-11 Thread Mauricio Vasquez B
In some places it is called "external-ids" while in others "external_ids" is used. This commit changes it to external_ids in all of them. Signed-off-by: Mauricio Vasquez B --- ovn/controller/ovn-controller.8.xml | 12 ++-- ovn/ovn-architecture.7.xml |

[ovs-dev] [PATCH 2/2] tests/dpdk/ring_client: extend range of supported dpdkr ports

2016-02-23 Thread Mauricio Vasquez B
Current implementation of the ring_client test only supports until the dpdkr255 port, this patch extends it to support the full range of possible dpdkr ports. Signed-off-by: Mauricio Vasquez B --- v3: use str_to_uint tests/dpdk/ring_client.c | 46

[ovs-dev] [PATCH 1/2] lib/netdev-dpdk: make device name parsing more robust

2016-02-23 Thread Mauricio Vasquez B
Current implementation of dpdk_dev_parse_name does not perform a robust error handling, port names as "dpdkr" and "dpdkr1x" are considered valid. With this patch only positive port numbers in decimal notation are considered valid. Signed-off-by: Mauricio Vasquez B --- v

[ovs-dev] [PATCH] INSTALL.DPDK: remove issue with QEMU v2.4.0 and dpdkvhostuser

2016-03-09 Thread Mauricio Vasquez B
The patch mentioned in the commit e73b7508fb58 ("INSTALL.DPDK: Mention issue with QEMU v2.4.0 & dpdkvhostuser") is present in DPDK v2.2.0, then this issue is not valid anymore. Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.md | 12 1 file changed, 12 deletions(-)

[ovs-dev] [RFC] lib/netdev-dpdk: add hotplug support

2016-03-19 Thread Mauricio Vasquez B
the user attaches a new device, it can use the add-port command to use it in a switch, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 79 +++ 1

[ovs-dev] [PATCH 3/3] NEWS: dpdk port hotplug is now supported

2016-03-28 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index ea7f3a1..2ba8659 100644 --- a/NEWS +++ b/NEWS @@ -26,6 +26,7 @@ Post-v2.5.0 assignment. * Type of log messages from PMD threads changed from INFO to DBG. * QoS

[ovs-dev] [PATCH 1/3] netdev-dpdk: add hotplug support

2016-03-28 Thread Mauricio Vasquez B
device, it has to be added to a bridge using the to use the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 73 +++ 1 file

[ovs-dev] [PATCH 2/3] INSTALL.DPDK: add port hotplug documentation

2016-03-28 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.md | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index 9ec8bf6..4095402 100644 --- a/INSTALL.DPDK.md +++ b/INSTALL.DPDK.md @@ -81,7 +81,7 @@ Using the DPDK with

[ovs-dev] [PATCH v2] netdev-dpdk: add hotplug support

2016-04-01 Thread Mauricio Vasquez B
device, it has to be added to a bridge using the to use the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.md | 26 +++- NEWS | 1 + lib/netdev-dpdk.c | 88

[ovs-dev] [PATCH v3] netdev-dpdk: add hotplug support

2016-04-13 Thread Mauricio Vasquez B
device, it has to be added to a bridge using the to use the add-port command, similarly, before detaching a device, it has to be removed using the del-port command. Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.md | 26 +- NEWS | 1 + lib/netdev-dpdk.c | 102

[ovs-dev] [PATCH] doc: fix bad link to dpdk advance installation guide

2016-10-18 Thread Mauricio Vasquez B
The link was pointing to a wrong place after the file was converted to rst. Fixes: 167703d664fc ("doc: Convert INSTALL.DPDK to rST") Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/INSTALL.

[ovs-dev] [PATCH] doc: fix duplicated colons in rst documents

2016-10-20 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.rst | 148 +- INSTALL.Debian.rst| 20 +-- INSTALL.Docker.rst| 76 +++--- INSTALL.KVM.rst | 24 ++-- INSTALL.Windows.rst | 136

[ovs-dev] [PATCH v2] doc: v2: fix bad link to dpdk advance installation guide

2016-10-20 Thread Mauricio Vasquez B
Previous fix was also wrong. Fixes: 167703d ("doc: Convert INSTALL.DPDK to rST") Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/INSTALL.DPDK.rst b/INSTALL.DPDK.rst index 5780909..4ca9b27 10

[ovs-dev] [PATCH v2] doc: fix duplicated colons in rst documents

2016-10-31 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- FAQ.rst | 106 +- INSTALL.DPDK.rst | 74 +-- INSTALL.Debian.rst| 10 ++--- INSTALL.Docker.rst| 38 +- INSTALL.KVM.rst | 12

[ovs-dev] [PATCH] lib/netdev-dpdk: increase ring name length for dpdkr ports

2016-01-09 Thread Mauricio Vasquez B
A ring name length of 10 characters is not enough for dpdkr ports starting from dpdkr10, then it is increased to 20 characters. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c

[ovs-dev] [PATCH v2] lib/netdev-dpdk: increase ring name length for dpdkr ports

2016-01-10 Thread Mauricio Vasquez B
A ring name length of 10 characters is not enough for dpdkr ports starting from dpdkr10, then it is increased to RTE_RING_NAMESIZE characters. Signed-off-by: Mauricio Vasquez B --- v2: - Use RTE_RING_NAMESIZE instead of a numerical constant. lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3

[ovs-dev] [PATCH 2/3] tests/dpdk/ring_client: extend range of supported dpdkr ports

2016-01-23 Thread Mauricio Vasquez B
Current implementation allows to support only until the dpdkr255 port, this patch extends it to support the full range of possible dpdkr ports. Signed-off-by: Mauricio Vasquez B --- tests/dpdk/ring_client.c | 43 ++- 1 file changed, 26 insertions(+), 17

[ovs-dev] [PATCH 1/3] lib/netdev-dpdk: make device name parsing more robust

2016-01-23 Thread Mauricio Vasquez B
Current implementation of dpdk_dev_parse_name does not perform a robust error handling, port names as "dpdkr" or "dpdkr1x" are considered valid. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 22 -- 1 file changed, 20 insertions(+), 2 deleti

[ovs-dev] [PATCH 3/3] lib/netdev-dpdk: increase ring name length for dpdkr ports

2016-01-23 Thread Mauricio Vasquez B
A ring name length of 10 characters is not enough for dpdkr ports starting from dpdkr10, then it is increased to RTE_RING_NAMESIZE characters. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b

[ovs-dev] [PATCH v2 2/2] tests/dpdk/ring_client: extend range of supported dpdkr ports

2016-01-25 Thread Mauricio Vasquez B
Current implementation of the ring_client test only supports up to the dpdkr255 port, this patch extends it to support the full range of possible dpdkr ports. Signed-off-by: Mauricio Vasquez B --- v2: - replace strtol by strtoul Thanks to Aaron Conole! tests/dpdk/ring_client.c | 44

[ovs-dev] [PATCH v2 1/2] lib/netdev-dpdk: make device name parsing more robust

2016-01-25 Thread Mauricio Vasquez B
Current implementation of dpdk_dev_parse_name does not perform a robust error handling, port names as "dpdkr", "dpdkr1x", "dpdkr 5" are considered valid. With this path only positive port numbers in decimal notation are considered valid. Signed-off-by: Maurici

[ovs-dev] [PATCH] netdev-dpdk: assume dpdkr peer can be multi-producer/consumer

2015-11-16 Thread Mauricio Vasquez B
. Signed-off-by: Mauricio Vasquez B --- lib/netdev-dpdk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4658416..e3a0771 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1931,9 +1931,9 @@ dpdk_ring_create(const char