64-bit glibc appears to avoid syscalls for clock_gettime(), so we can get
higher resolution timing and avoid having a timer firing off SIGALRM
without introducing extra overhead.
Signed-off-by: Leo Alterman
---
lib/timeval.c | 46 --
1 file changed
64-bit glibc appears to avoid syscalls for clock_gettime(), so we can get
higher resolution timing and avoid having a timer firing off SIGALRM
without introducing extra overhead.
Signed-off-by: Leo Alterman
---
lib/timeval.c| 36 +---
lib/timeval.h
lockfile_lock() accepts a timeout argument but, aside from unit tests
pertaining to timeout, its value is always 0. Since this feature relies on
a periodic SIGALRM signal, which is no longer a given after refactoring
timeval.c, the cleanest solution is to just remove it.
Signed-off-by: Leo
Thanks guys. Submitted revised patch series which checks for Linux, uses
fewer preprocessor conditions, and deals with some of the resulting unit
test fallout.
~Leo
On Wed, Aug 8, 2012 at 12:24 PM, Ben Pfaff wrote:
> On Tue, Aug 07, 2012 at 05:00:59PM -0700, Leo Alterman wrote:
> &g
lockfile_lock() accepts a timeout argument but, aside from unit tests
pertaining to timeout, its value is always 0. Since this feature relies on
a periodic SIGALRM signal, which is not a given if we're not caching time,
the cleanest solution is just to remove it.
Signed-off-by: Leo Alt
64-bit Linux appears to avoid syscalls for clock_gettime(), so we can get
higher resolution timing and avoid having a timer firing off SIGALRM
without introducing extra overhead.
Signed-off-by: Leo Alterman
---
lib/timeval.c| 36 +---
lib/timeval.h
Thanks, Ben. Incorporated changes and resubmitted patch set since the order
changed.
On Wed, Aug 8, 2012 at 9:26 PM, Ben Pfaff wrote:
> On Wed, Aug 08, 2012 at 05:52:58PM -0700, Leo Alterman wrote:
> > lockfile_lock() accepts a timeout argument but, aside from unit tests
> >
Oh whoops. I did make that change, it must have gotten lost when rebasing.
Will make sure it's in there.
On Thu, Aug 9, 2012 at 2:10 PM, Ben Pfaff wrote:
> On Thu, Aug 09, 2012 at 01:14:49PM -0700, Leo Alterman wrote:
> > +#if defined __LP64__ && defined __linux__
>
&
Signed-off-by: Leo Alterman
---
datapath/README |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/README b/datapath/README
index b8a048b..8fa2dd1 100644
--- a/datapath/README
+++ b/datapath/README
@@ -118,7 +118,7 @@ essentially like this, ignoring metadata