[ovs-dev] [RFC PATCH] openvswitch: Use net_ratelimit in OVS_NLERR

2014-02-02 Thread Joe Perches
Perhaps it'd make sense to use net_ratelimit() instead of printk_once for OVS_NLERR --- net/openvswitch/datapath.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/openvswitch/datapath.h b/net/openvswitch/datapath.h index 6be9fbb..0f5e77c 100644 --- a/net/openvswitch

Re: [ovs-dev] [RFC PATCH] openvswitch: Use net_ratelimit in OVS_NLERR

2014-02-03 Thread Joe Perches
On Mon, 2014-02-03 at 13:46 -0800, Jesse Gross wrote: > On Sun, Feb 2, 2014 at 10:55 PM, Joe Perches wrote: > > Perhaps it'd make sense to use net_ratelimit() > > instead of printk_once for OVS_NLERR > > I guess I could see it going either way but I'm not sur

[ovs-dev] [PATCH] openvswitch: Use net_ratelimit in OVS_NLERR

2014-02-03 Thread Joe Perches
Each use of pr__once has a per-site flag. Some of the OVS_NLERR messages look as if seeing them multiple times could be useful, so use net_ratelimit() instead of pr_info_once. Signed-off-by: Joe Perches --- > OK, I guess it's fine. Can you provide a signed-off-by line? net/ope

Re: [ovs-dev] [PATCH] openvswitch: flow_netlink: Use pr_fmt to OVS_NLERR output

2014-02-03 Thread Joe Perches
Add "openvswitch: " prefix to OVS_NLERR output to match the other OVS_NLERR output of datapath.c Signed-off-by: Joe Perches --- net/openvswitch/flow_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c ind

[ovs-dev] [PATCH net-next] openvswitch: Use ether_addr_copy

2014-02-18 Thread Joe Perches
It's slightly smaller/faster for some architectures. Signed-off-by: Joe Perches --- net/openvswitch/actions.c | 4 ++-- net/openvswitch/flow.c | 16 net/openvswitch/flow_netlink.c | 12 ++-- 3 files changed, 16 insertions(+), 16 deletions(-) diff --

Re: [ovs-dev] [PATCH] openvswitch: Fix alignment of struct sw_flow_key.

2013-09-05 Thread Joe Perches
On Thu, 2013-09-05 at 14:40 -0400, David Miller wrote: > From: Jesse Gross > Date: Thu, 5 Sep 2013 11:36:19 -0700 > > On Thu, Sep 5, 2013 at 11:17 AM, David Miller wrote: > >> From: Jesse Gross > >> Date: Thu, 5 Sep 2013 10:41:27 -0700 > >> > >>> -} __aligned(__alignof__(long)); > >>> +} __alig

Re: [ovs-dev] [PATCH net-next 04/11] openvswitch: Restructure datapath.c and flow.c

2013-10-29 Thread Joe Perches
On Tue, 2013-10-29 at 17:22 -0700, Jesse Gross wrote: > Over the time datapath.c and flow.c has became pretty large files. > Following patch restructures functionality of component into three > different components: [] > net/openvswitch/Makefile |2 + > net/openvswitch/datapath.c |

Re: [ovs-dev] [PATCH net-next 04/11] openvswitch: Restructure datapath.c and flow.c

2013-10-29 Thread Joe Perches
On Tue, 2013-10-29 at 18:25 -0700, Joe Perches wrote: > On Tue, 2013-10-29 at 17:22 -0700, Jesse Gross wrote: > > Over the time datapath.c and flow.c has became pretty large files. > > Following patch restructures functionality of component into three > > different comp

[ovs-dev] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-18 Thread Joe Perches
*) ipv4_addr_(__be32) ipv6_addr_(const struct in6_addr *) Add temporary backward compatibility #defines for the old names too. Joe Perches (21): etherdevice: Rename is__ether_addr tests to eth_addr_ net: Convert is__ether_addr uses to eth_addr_ arch: Convert is__ether_addr uses to eth_addr_

[ovs-dev] [PATCH net-next 02/21] net: Convert is__ether_addr uses to eth_addr_

2012-10-18 Thread Joe Perches
Convert the old ether_addr tests to eth_addr_. Adds api consistency. Signed-off-by: Joe Perches --- net/802/stp.c |4 +- net/8021q/vlan_dev.c |6 ++-- net/8021q/vlan_netlink.c |2 +- net/batman-adv/bat_iv_ogm.c

[ovs-dev] [RFC net-next 0/2] net: Use net__ratelimit

2012-05-14 Thread Joe Perches
net_ratelimit() like __ratelimit() is too easy to misuse. Add simplifying macros similar to pr__ratelimited that combines the test of net_ratelimit and logging. Joe Perches (2): net: Add net_ratelimited_function and net__ratelimited macros net: Convert net_ratelimit uses to net__ratelimited

Re: [ovs-dev] [RFC net-next 0/2] net: Use net__ratelimit

2012-05-15 Thread Joe Perches
On Tue, 2012-05-15 at 13:45 -0400, David Miller wrote: > From: Joe Perches > Date: Mon, 14 May 2012 00:56:24 -0700 > > > net_ratelimit() like __ratelimit() is too easy to misuse. > > > > Add simplifying macros similar to pr__ratelimited > > that combines the