option table is specified
for a particular switch over OpenFlow, it is currently global to all
switches. This will be addressed in a future patch.
Based on work originally done by Madhu Challa.
Signed-off-by: Jesse Gross
---
NEWS | 6 +-
build-aux/extract-ofp-field
of doing so is undefined.
This only adds the OpenFlow infrastructure but doesn't actually
do anything with the information yet after the messages have been
decoded.
Signed-off-by: Jesse Gross
---
include/openflow/nicira-ext.h | 72 +
lib/automake.mk | 1 +
t length is, such as in the case of a string parsed by
ovs-ofctl), these semantics should provide deterministic results
that are easy to understand and not require most existing code
to be aware of variable length fields.
Signed-off-by: Jesse Gross
---
lib/nx-matc
which won't work.
* Use a consistent mapping table during the course of translation.
* Tests
Follow-up work in the near future:
* The mapping table is shared across OpenFlow switches but should not be.
* Support for zero-length options.
* More sanity checking and informative messages
irrelevant arguments to be omitted.
Signed-off-by: Jesse Gross
---
lib/dpif-netdev.c | 24 ++--
lib/odp-util.c| 53 ---
lib/odp-util.h| 31 -
lib/tnl-ports.c
gt; --- a/NEWS
> +++ b/NEWS
> @@ -1,9 +1,8 @@
> -v2.3.2 - xx xxx
> +v2.3.2 - 17 Jun 2015
> -
> - The MAC learning feature now includes per-port fairness to mitigate
> MAC flooding attacks.
>
> -
You clipped off the second blank
On Wed, Jun 17, 2015 at 4:03 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> NEWS |4
> configure.ac |2 +-
> debian/changelog |7 +++
> 3 files changed, 12 insertions(+), 1 deletions(-)
Ack
On Wed, Jun 17, 2015 at 4:16 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> NEWS |2 +-
> configure.ac |2 +-
> debian/changelog |4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
Ack
On Wed, Jun 17, 2015 at 4:16 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> NEWS |4
> configure.ac |2 +-
> debian/changelog |7 +++
> 3 files changed, 12 insertions(+), 1 deletions(-)
Ack
Thanks, applied to master.
On Thu, Jun 18, 2015 at 4:26 PM, Andy Zhou wrote:
> Signed-off-by: Andy Zhou
>
> On Wed, Jun 17, 2015 at 10:41 AM, Jesse Gross wrote:
>> Serializing between userspace flows and netlink attributes currently
>> requires several additional paramet
ork in the near future:
* The mapping table is shared across OpenFlow switches but should not be.
* Support for zero-length options.
* More sanity checking and informative messages.
Jesse Gross (11):
metaflow: Allow fields to be marked as variable length.
nx-match: Support variable length hea
annotated with not only their size
but whether the field can be smaller than that. The following
patches will change OpenFlow parsing based on that.
Signed-off-by: Jesse Gross
---
build-aux/extract-ofp-fields | 23 +++
lib/meta-flow.h | 1 +
2 files changed, 16
continue to use the length for non-variable fields to ensure that
we don't accept something that can never match.
Signed-off-by: Jesse Gross
---
lib/nx-match.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 21
When reading in hex strings that form NXM fields, we don't need to
enforce size constraints if the fields are variable length.
Instead, we can set the header size based on the string length.
Signed-off-by: Jesse Gross
---
lib/nx-match.c | 20 ++--
1 file changed, 18 inser
implementation
already required callers to pass in the exact (fixed) size of
the field or it would not work properly, so there is no danger
that this will change the behavior for non-variable length
fields.
Signed-off-by: Jesse Gross
---
lib/nx-match.c | 20 ++--
1 file changed, 18
that are generally
sensible without specific knowledge of what is being transmitted.
(Of course, other implementations, such as controllers, may know
exactly the expected length of the field and are free to encode
it that way even if it has leading zeros.)
Signed-off-by: Jesse Gross
---
lib/meta
field.
Signed-off-by: Jesse Gross
---
lib/meta-flow.c | 7 +--
lib/meta-flow.h | 26 +-
tests/learn.at | 2 +-
tests/ovn.at| 1 -
4 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 526f88e..c4295c5 100644
and
the userspace implementation of Geneve does not currently support
options anyways.
Signed-off-by: Jesse Gross
---
lib/flow.c| 7 ++-
lib/packets.h | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index 7350a17..6bfe738 100644
--- a
of doing so is undefined.
This only adds the OpenFlow infrastructure but doesn't actually
do anything with the information yet after the messages have been
decoded.
Signed-off-by: Jesse Gross
---
include/openflow/nicira-ext.h | 70 +
lib/automake.mk | 1 +
option table is specified
for a particular switch over OpenFlow, it is currently global to all
switches. This will be addressed in a future patch.
Based on work originally done by Madhu Challa.
Signed-off-by: Jesse Gross
---
NEWS | 1 +
build-aux/extract-ofp-fields | 13 +-
t length is, such as in the case of a string parsed by
ovs-ofctl), these semantics should provide deterministic results
that are easy to understand and not require most existing code
to be aware of variable length fields.
Signed-off-by: Jesse Gross
---
lib/nx-matc
aw netlink information. Fortunately, that is also readily
available so this passes it down from the appropriate callers.
Signed-off-by: Jesse Gross
---
lib/dpctl.c | 3 ++-
lib/dpif-netdev.c | 3 ++-
lib/odp-util.c
On Thu, Dec 19, 2013 at 7:20 AM, Thomas Graf wrote:
> Following commit (''netlink: Do not enforce alignment of last Netlink
> attribute''), signal the ability to receive unaligned Netlink messages
> to the datapath to enable utilization of zerocopy optimizations.
>
> Opening a datapath is now done
On Tue, Dec 17, 2013 at 10:22 AM, Jesse Gross wrote:
> This is apparently used by CentOS 6.5.
>
> Reported-by: Phil Daws
> Reported-by: Madko
> Signed-off-by: Jesse Gross
> ---
> v2: Check for netdev_features_t in netdevice.h instead as this works
> on all kernel v
On Fri, Dec 20, 2013 at 5:30 PM, Pravin B Shelar wrote:
> RHEL6-openstack kernel has backported lockdep_rtnl_is_held().
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On Fri, Dec 20, 2013 at 5:30 PM, Pravin B Shelar wrote:
> RHEL6-openstack kernel has already replaced skb_has_frags
> with skb_has_frag_list().
>
> Fix compilation error on RHEL6-openstack.
>
> Signed-off-by: Pravin B Shelar
Ack
On Fri, Dec 20, 2013 at 8:17 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/gre.h
> b/datapath/linux/compat/include/net/gre.h
> index 91fb7af..2678af5 100644
> --- a/datapath/linux/compat/include/net/gre.h
> +++ b/datapath/linux/compat/include/net/gre.h
> @@ -4,7 +4,7
On Sat, Dec 21, 2013 at 6:11 PM, Pravin Shelar wrote:
> On Sat, Dec 21, 2013 at 9:48 AM, Jesse Gross wrote:
>> On Fri, Dec 20, 2013 at 8:17 PM, Pravin B Shelar wrote:
>>> diff --git a/datapath/linux/compat/include/net/gre.h
>>> b/datapath/linux/compat/include/
On Sun, Dec 22, 2013 at 3:12 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/gre.c b/datapath/linux/compat/gre.c
> index f35f11f..5b2a892 100644
> --- a/datapath/linux/compat/gre.c
> +++ b/datapath/linux/compat/gre.c
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,11,0)
> +static cons
On Sun, Dec 22, 2013 at 3:36 PM, Chris Luke wrote:
> Pravin Shelar wrote (on Sun 22 Dec, 2013 at 20:12 GMT):
>>
>> On Sun, Dec 22, 2013 at 9:21 AM, Chris Luke wrote:
>>>
>>> Just a note; this adds datapath/linux/compat/include/linux/bug.h but
>>> doesn?t
>>>
>>> add that filename to datapath/linu
On Sun, Dec 22, 2013 at 10:43 PM, Pravin B Shelar wrote:
> RHEL6-openstack kernel has backported gre DEMUX module,
> Therefore add configure check to detect it.
>
> Signed-off-by: Pravin B Shelar
> Bug #21936
Acked-by: Jesse Gross
On Mon, Dec 23, 2013 at 12:13 AM, Chris Luke wrote:
> Open vSwitch handles the OPFF_NORMAL action by passing packets
> into a simple layer 2 learning switch. This commit adds the option to have
> packets passed back to the kernel as though Open vSwitch never touched
> them. This allows, for instan
On Mon, Dec 30, 2013 at 2:29 PM, Ben Pfaff wrote:
> On Tue, Dec 24, 2013 at 04:02:36PM +0200, Lorand Jakab wrote:
>> Implementation of the pop_eth and push_eth actions in the kernel, also
>> layer 3 flow support. Jesse Gross provided feedback on a previous
>> version of t
On Wed, Jan 1, 2014 at 2:30 AM, Oded Lazar wrote:
> Hey guys,
> I'm Looking into implementing QinQ in OVS and I read in the mailing lists
> that a patch has already been created and Ravi/Jesse stopped working on it
> about a year ago. I want to port it to OVS 2.x and hopefully commit it.
I doubt
lan header and I
> need to add another one on top. Current ovs implementations don't allow such
> thing, right? (ovs-ofctl push_vlan keeps changing my vlan header instead of
> adding a new one)
>
> That's why I wanted to get into implementing QinQ.
>
>
> On Wednesd
On Wed, Jan 1, 2014 at 11:27 AM, Oded Lazar wrote:
> Sorry, that was an honest mistake. Let's say I want to tweak push_vlan to
> add a new tag, even if theres an existing one-
> I saw that there's a check to see if there's a vlan header on the frame and
> if so, it 'pushes down' the current header
les/methods I need
> to look for? It's my first OVS code edit.
>
> Thanks!
>
> On Wednesday, January 1, 2014, Jesse Gross wrote:
>>
>> On Wed, Jan 1, 2014 at 11:27 AM, Oded Lazar wrote:
>> > Sorry, that was an honest mistake. Let's say I want to tw
On Sun, Dec 29, 2013 at 2:50 AM, Ben Pfaff wrote:
> I've been a little frustrated with the current approach to MPLS, because it
> seems quite difficult to understand. One particularly difficult bit for
> me is the variables used during translation, e.g. mpls_depth_delta and
> pre_push_mpls_lse.
On Mon, Dec 23, 2013 at 11:46 PM, Chris Luke wrote:
> Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
>>
>> On Mon, Dec 23, 2013 at 12:13 AM, Chris Luke wrote:
>>>
>>> Open vSwitch handles the OPFF_NORMAL action by passing packets
>>> into a simple
On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote:
>> On Jan 2, 2014, at 16:51, Jesse Gross wrote:
>>> On Mon, Dec 23, 2013 at 11:46 PM, Chris Luke wrote:
>>> Jesse Gross wrote (on Tue 24 Dec, 2013 at 03:05 GMT):
>>>> * This type of concept has come up before
Signed-off-by: Jesse Gross
---
FAQ | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FAQ b/FAQ
index 1edcd94..635e548 100644
--- a/FAQ
+++ b/FAQ
@@ -641,6 +641,17 @@ A: In version 1.9.0, OVS switched to using a single
datapath that is
shared by all bridges of that type. The
On Fri, Jan 3, 2014 at 12:40 PM, Justin Pettit wrote:
> On Fri, Jan 3, 2014 at 9:33 AM, Jesse Gross wrote:
>>
>>
>> +A: On Linux kernels before 3.11, the OVS GRE module and Linux GRE module
>> + cannot be loaded at the same time. It is likely that on your system
>
On Fri, Jan 3, 2014 at 2:43 PM, Joe Stringer wrote:
> This patch adds the logic used for TCP and UDP in b0f3a2feef
> (datapath: Use percpu allocator for flow-stats.) to SCTP. This should
> help to detect longer-lived flows that match on SCTP, for use with the
> per-cpu allocator for flow-stats.
>
This is backported by RHEL7.
Reported-by: Ashok Byahatti
Signed-off-by: Jesse Gross
---
acinclude.m4 | 2 ++
datapath/linux/compat/include/net/sctp/checksum.h | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/acinclude.m4 b
On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote:
> Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT):
>
>> On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote:
>>>>
>>>> On Jan 2, 2014, at 16:51, Jesse Gross wrote:
>>>>>
>>>
On Fri, Jan 3, 2014 at 12:47 AM, Chris Luke wrote:
> I just discovered a quirk worth being aware of: The two LLDP daemons
> out there work in a subtly different way.
>
> 'lldpd' uses PF_PACKET with ETH_P_ALL as the prtotocol, meaning
> it captures all layer 2 frames. Same thing with the packet
> c
Thanks for the review, I applied this.
On Fri, Jan 3, 2014 at 7:05 PM, Joe Stringer wrote:
> Looks good, thanks Jesse.
>
> Acked-by: Joe Stringer
>
> On 3 January 2014 15:44, Jesse Gross wrote:
>> This is backported by RHEL7.
>>
>> Reported-by: Ashok Byahat
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 5137c2f..46b3634 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> * @OVS_ACTION_ATTR_OUTPUT: Output packet to port.
> @@ -569,6 +5
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
> Implementation of the pop_eth and push_eth actions in the kernel, also
> layer 3 flow support. Jesse Gross provided feedback on a previous
> version of this RFC patch, all of those comments are resolved here.
>
> Signed-off-b
On Mon, Jan 6, 2014 at 2:14 PM, Lori Jakab wrote:
> On 1/6/14 6:30 PM, Jesse Gross wrote:
>>
>> On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
>>>
>>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>>> index 5137c
On Fri, Jan 3, 2014 at 10:00 PM, Chris Luke wrote:
> Jesse Gross wrote (on Fri 03 Jan, 2014 at 23:48 GMT):
>
>> On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote:
>>>
>>> Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT):
>>>
>>>>
On Mon, Jan 6, 2014 at 3:49 PM, Chris Luke wrote:
> Jesse Gross wrote (on Mon 06 Jan, 2014 at 20:29 GMT):
>
>> On Fri, Jan 3, 2014 at 10:00 PM, Chris Luke wrote:
>>>
>>> Jesse Gross wrote (on Fri 03 Jan, 2014 at 23:48 GMT):
>>>
>>>>
s but
sw_flow_mask only by 8 bytes due to padding.
Compile tested only.
Signed-off-by: Ben Pfaff
Acked-by: Andy Zhou
Signed-off-by: Jesse Gross
---
net/openvswitch/flow.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h
From: Andy Zhou
API changes only for code readability. No functional chnages.
This patch removes the underscored version. Added a new API
ovs_flow_tbl_lookup_stats() that returns the n_mask_hits.
Reported by: Ben Pfaff
Reviewed-by: Thomas Graf
Signed-off-by: Andy Zhou
Signed-off-by: Jesse
Flow lookup can happen either in packet processing context or userspace
context but it was annotated as requiring RCU read lock to be held. This
also allows OVS mutex to be held without causing warnings.
Reported-by: Justin Pettit
Signed-off-by: Jesse Gross
Reviewed-by: Thomas Graf
---
net
From: Daniel Borkmann
As we're only doing a kfree() anyway in the RCU callback, we can
simply use kfree_rcu, which does the same job, and remove the
function rcu_free_sw_flow_mask_cb() and rcu_free_acts_callback().
Signed-off-by: Daniel Borkmann
Signed-off-by: Jesse Gross
---
net/openvs
: Change ovs_flow_tbl_lookup_xx() APIs
Ben Pfaff (2):
openvswitch: Correct comment.
openvswitch: Shrink sw_flow_mask by 8 bytes (64-bit) or 4 bytes (32-bit).
Daniel Borkmann (1):
net: ovs: use kfree_rcu instead of
rcu_free_{sw_flow_mask_cb,acts_callback}
Jesse Gross (1
Signed-off-by: Jesse Gross
---
net/netlink/af_netlink.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index bca50b9..6433489 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1769,6 +1769,9 @@ struct sk_buff
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_table.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index 099a1a9..51f6d7f 100644
--- a/net
-by: Thomas Graf
Reviewed-by: Daniel Borkmann
Signed-off-by: Jesse Gross
---
include/net/genetlink.h | 4
net/netlink/genetlink.c | 21 +
2 files changed, 25 insertions(+)
diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 1b177ed..93695f0 100644
d_0 [k] memcpy
+ 1.09% kpktgend_1 [k] memcpy
+ 1.04% kpktgend_3 [k] memcpy
+ 0.96% ovs-vswitchd [k] copy_user_generic_string
Signed-off-by: Thomas Graf
Reviewed-by: Daniel Borkmann
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c |
From: Ben Pfaff
Signed-off-by: Ben Pfaff
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_table.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index e425427..f96ebd5 100644
--- a/net/openvswitch
From: Thomas Graf
Make the skb zerocopy logic written for nfnetlink queue available for
use by other modules.
Signed-off-by: Thomas Graf
Reviewed-by: Daniel Borkmann
Acked-by: David S. Miller
Signed-off-by: Jesse Gross
---
include/linux/skbuff.h | 3 ++
net/core/skbuff.c
+ 3.32% vhost-5153 [k] memcpy
+ 0.68% vhost-5153 [k] skb_zerocopy
(megaflows disabled)
Signed-off-by: Thomas Graf
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 37 +
1 file changed, 29 insertions(+), 8 deletions(-)
diff --git
From: Stephen Hemminger
Several functions and datastructures could be local
Found with 'make namespacecheck'
Signed-off-by: Stephen Hemminger
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/datapath.h | 2 --
net/openvswitch/vport.c| 6 +
spread by RSS). In other situations,
it uses the current strategy, saving memory and allocation time.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 50 +++---
net/openvswitch/flow.c | 96
From: Thomas Graf
Allows removing the net and dp_ifindex argument and simplify the
code.
Signed-off-by: Thomas Graf
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/net
From: Thomas Graf
The copy & csum optimization is no longer present with zerocopy
enabled. Compute the checksum in skb_gso_segment() directly by
dropping the HW CSUM capability from the features passed in.
Signed-off-by: Thomas Graf
Signed-off-by: Jesse Gross
---
net/openvswitch/datapa
From: Thomas Graf
Drop user features if an outdated user space instance that does not
understand the concept of user_features attempted to create a new
datapath.
Signed-off-by: Thomas Graf
Signed-off-by: Jesse Gross
---
include/uapi/linux/openvswitch.h | 10 +-
net/openvswitch
From: Thomas Graf
Signed-off-by: Thomas Graf
Reviewed-by: Daniel Borkmann
Signed-off-by: Jesse Gross
---
include/uapi/linux/openvswitch.h | 4
net/openvswitch/datapath.c | 14 ++
net/openvswitch/datapath.h | 2 ++
3 files changed, 20 insertions(+)
diff --git a
On Mon, Jan 6, 2014 at 10:53 PM, Simon Horman wrote:
> On Thu, Jan 02, 2014 at 11:51:15AM -0500, Jesse Gross wrote:
>> On Sun, Dec 29, 2013 at 2:50 AM, Ben Pfaff wrote:
>> > I've been a little frustrated with the current approach to MPLS, because it
>> > seems qui
Good catch, thanks.
I'll let David pick this up directly since I just flushed my patch queue.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jan 8, 2014 at 7:03 AM, James Page wrote:
> Bump kernel support for datapath module to include 3.12.
>
> Make use of native vxlan kernel module for Linux >= 3.12 or if
> the kernel in use supports the required vxlan functions.
>
> Note: ipv6 enablement with vxlan is not supported by this c
On Wed, Jan 8, 2014 at 9:49 AM, Zoltan Kiss wrote:
> Hi,
>
> I've tried the latest net-next on a Xenserver install with 1.9.3 userspace,
> and it seems this patch series broke it (at least after reverting that
> locally it works now). I haven't went too far yet checking what's the
> problem, but i
On Tue, Jan 7, 2014 at 11:03 PM, Simon Horman wrote:
> On Tue, Jan 07, 2014 at 09:30:54PM -0500, Jesse Gross wrote:
>> I was talking about the case where there is a single pass and you have
>> multiple MPLS pop actions. This previously wasn't possible because
>> userspa
On Wed, Jan 8, 2014 at 9:50 AM, James Page
>
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 08/01/14 14:34, Jesse Gross wrote:
>>> Note: ipv6 enablement with vxlan is not supported by this
>>> change.
>>>>
>>>>
On Thu, Jan 9, 2014 at 5:19 PM, Andy Zhou wrote:
> diff --git a/datapath/flow_table.c b/datapath/flow_table.c
> index 4232b82..4170a96 100644
> --- a/datapath/flow_table.c
> +++ b/datapath/flow_table.c
> void ovs_flow_free(struct sw_flow *flow, bool deferred)
> {
> if (!flow)
>
On Thu, Jan 9, 2014 at 9:17 AM, Ben Pfaff wrote:
> On Thu, Jan 02, 2014 at 11:51:15AM -0500, Jesse Gross wrote:
>> On Sun, Dec 29, 2013 at 2:50 AM, Ben Pfaff wrote:
>> > I've been a little frustrated with the current approach to MPLS, because it
>> > seems qui
On Sun, Jan 12, 2014 at 4:05 AM, Philip Roth wrote:
> Hey,
> I'm noticing a weird behaviour when a vlan tagged frame arrives to push_vlan
> method.
> I'm sending a vlan tagged frame to ovs throught port 1 and have the
> following rule:
> "table=1,in_port=1,actions=push_vlan:0x8100,2" & I'm sniffin
On Fri, Jan 10, 2014 at 4:10 PM, Ben Pfaff wrote:
> On Fri, Jan 10, 2014 at 03:50:09PM -0800, Jesse Gross wrote:
>> On Thu, Jan 9, 2014 at 9:17 AM, Ben Pfaff wrote:
>> > On Thu, Jan 02, 2014 at 11:51:15AM -0500, Jesse Gross wrote:
>> >> On Sun, Dec 29, 201
On Mon, Jan 13, 2014 at 4:31 PM, Zoltan Kiss wrote:
> On 13/01/14 18:04, Zoltan Kiss wrote:
>>
>> On 08/01/14 15:10, Jesse Gross wrote:
>>>
>>> On Wed, Jan 8, 2014 at 9:49 AM, Zoltan Kiss
>>> wrote:
>>>>
>>>> Hi,
>>
On Wed, Jan 15, 2014 at 1:06 PM, Andy Zhou wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index b42fd8b..6ae4ecf 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1305,10 +1306,13 @@ static void __dp_destroy(struct datapath *dp)
> list_del_rcu(&dp->lis
On Tue, Jan 14, 2014 at 7:03 PM, David Miller wrote:
> From: Thomas Graf
> Date: Tue, 14 Jan 2014 16:27:49 +
>
>> While the zerocopy method is correctly omitted if user space
>> does not support unaligned Netlink messages. The attribute is
>> still not padded correctly as skb_zerocopy() will
On Sat, Jan 11, 2014 at 4:33 PM, Luigi Rizzo wrote:
> Hi,
> in porting the ovs kernel code to the FreeBSD kernel,
> compiling with -Wcast-qual -Werror gives some
>
>warning: cast discards qualifiers from pointer target type
>
> due to 'const' being ignored. Another couple of warnings
> are on
ted-by: Joe Stringer
> Signed-off-by: Andy Zhou
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jan 15, 2014 at 3:46 PM, Luigi Rizzo wrote:
> On Wed, Jan 15, 2014 at 03:10:35PM -0800, Jesse Gross wrote:
>> On Sat, Jan 11, 2014 at 4:33 PM, Luigi Rizzo wrote:
>> > Hi,
>> > in porting the ovs kernel code to the FreeBSD kernel,
>> > compiling
On Wed, Jan 8, 2014 at 4:15 PM, Jarno Rajahalme wrote:
> 'perf' report on current master shows that kernel-side locking is
> taking more than 20% of the overall OVS execution time under TCP_CRR
> tests with flow tables that make all new connections go to userspace
> and that create huge amount of
On Tue, Jan 21, 2014 at 11:19 AM, Luigi Rizzo wrote:
>
>
>
> On Tue, Jan 21, 2014 at 9:54 AM, Jesse Gross wrote:
>>
>> On Wed, Jan 15, 2014 at 3:46 PM, Luigi Rizzo wrote:
>> > On Wed, Jan 15, 2014 at 03:10:35PM -0800, Jesse Gross wrote:
>> >>
On Thu, Jan 23, 2014 at 8:18 AM, Daniele Di Proietto
wrote:
> commit c58cc9a460fd158e5250e59902e96ac677dc115f (datapath: Allow user space to
> announce ability to accept unaligned Netlink messages) introduced
> OVS_DP_ATTR_USER_FEATURES netlink attribute in datapath responses,
> but the attribute
On Thu, Jan 23, 2014 at 8:19 AM, Daniele Di Proietto
wrote:
> In few functions, const formal parameters are assigned or cast to
> non-const.
> These changes suppress warnings if compiled with -Wcast-qual.
>
> Signed-off-by: Daniele Di Proietto
Applied, thanks.
___
On Wed, Jan 29, 2014 at 9:20 AM, wrote:
> From: Pravin
>
> ovs_flow_free() is not called under ovs-lock during packet
> execute path. Since packet execute does not touch flow->mask,
> there is no need to take that lock either. So move assert in
> case where flow->mask is checked.
>
> Found by co
On Wed, Jan 29, 2014 at 8:51 AM, Andy Zhou wrote:
> Last commit 738a2445c0 introduced a bug where the mask list of
> a flow table was freed even when the table's flows and mask list is
> reused by another table.
>
> Bug #32932
>
> Reported-by: Len Gao
> Signed-off-by
On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote:
> On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote:
>> On Wed, Jan 29, 2014 at 9:20 AM, wrote:
>>> From: Pravin
>>>
>>> ovs_flow_free() is not called under ovs-lock during packet
>>> exec
Not overlooked, just overwhelmed at the moment. :) Thanks for your patience.
On Wed, Jan 29, 2014 at 6:32 AM, Chris Luke wrote:
> This list has been busy just recently, so I am wondering if my teeny
> patchset has been overlooked. :)
>
> Cheers,
> Chris.
>
>
>> -Original Message-
>> From:
On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote:
> On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote:
>> On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote:
>>> On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote:
>>>> On Wed, Jan 29, 2014 at 9:20 A
On Wed, Jan 29, 2014 at 4:05 PM, Junguk Cho wrote:
>
> When OVS_VPORT_CMD_SET is used and which tool ( ex) ovs-vsctl ) call this?
It's primarily used when changing options on ports such as tunnels.
However, it is not an external interface that it directly called by an
end user.
__
On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote:
> On Wed, Jan 29, 2014 at 4:38 PM, Jesse Gross wrote:
>> On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote:
>>> On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote:
>>>> On Wed, Jan 29, 2014 at 11:22 AM, Prav
On Wed, Jan 29, 2014 at 7:18 PM, Jesse Gross wrote:
> On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote:
>> On Wed, Jan 29, 2014 at 4:38 PM, Jesse Gross wrote:
>>> On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote:
>>>> On Wed, Jan 29, 2014 at 4:21 PM, Je
On Thu, Jan 30, 2014 at 1:31 PM, Thomas Morin wrote:
> Hi,
>
> I ran into the same issue as the one described below (post on ovs-discuss a
> few months back).
>
> The goal is to use a vport tunnel configured to use a flow-based remote IP,
> e.g:
> ovs-vscl add-port br-vnet tun-port -- set Inte
flow updates can arrive with a
> micro flow other than the original. Change the return code to
> EEXIST and remove the kernel error log message.
>
> Signed-off-by: Andy Zhou
Acked-by: Jesse Gross
You can remove the extra set of braces now too.
___
901 - 1000 of 3414 matches
Mail list logo
