Re: [ovs-dev] [PATCH 00/16] generic hashtable implementation

2012-08-14 Thread J. Bruce Fields
On Tue, Aug 14, 2012 at 06:24:34PM +0200, Sasha Levin wrote: > SUNRPC/cache: use new hashtable implementation .. > lockd: use new hashtable implementation FWIW, these look fine (and I ran them through some nfs tests and didn't see any problems). --b. __

Re: [ovs-dev] [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > +static int __init nlm_init(void) > +{ > + hash_init(nlm_files); > + return 0; > +} > + > +module_init(nlm_init); That's giving me: fs/lockd/svcsubs.o: In function `nlm_init': /home/bfields/linux-2.6/fs/lockd/svcsubs.c:454: mu

Re: [ovs-dev] [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 02:13:54PM +0200, Sasha Levin wrote: > On 08/22/2012 01:47 PM, J. Bruce Fields wrote: > > On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > >> +static int __init nlm_init(void) > >> +{ > >> + ha

Re: [ovs-dev] [PATCH v7 09/16] SUNRPC/cache: use new hashtable implementation

2012-10-29 Thread J. Bruce Fields
On Mon, Oct 29, 2012 at 11:13:43AM -0400, Mathieu Desnoyers wrote: > * Linus Torvalds (torva...@linux-foundation.org) wrote: > > On Mon, Oct 29, 2012 at 5:42 AM, Mathieu Desnoyers > > wrote: > > > > > > So defining e.g.: > > > > > > #include > > > > > > #define DFR_HASH_BITS (PAGE_SHIFT - ilog2(